Dear York Sun,
In message <1312923045-2612-6-git-send-email-york...@freescale.com> you wrote:
> Update MPC8349EMDS to use unified DDR driver instead of spd_sdram.c.
> The unified driver can initialize data using DDR controller. No need to
> use DMA if just to initialze for ECC.
>
> Signed-off-by: York Sun <york...@freescale.com>
> Signed-off-by: Kim Phillips <kim.phill...@freescale.com>
Checkpatch says:
WARNING: do not add new typedefs
#149: FILE: board/freescale/mpc8349emds/ddr.c:14:
+typedef struct {
Please fix.
> +++ b/board/freescale/mpc8349emds/ddr.c
> @@ -0,0 +1,93 @@
> +/*
> + * Copyright 2011 Freescale Semiconductor, Inc.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * Version 2 as published by the Free Software Foundation.
U-Boot requires GPLv2+ in all new files. Please fix globally.
> +typedef struct {
> + u32 datarate_mhz_low;
> + u32 datarate_mhz_high;
> + u32 n_ranks;
> + u32 clk_adjust;
> + u32 cpo;
> + u32 write_data_delay;
> + u32 force_2T;
We don't allow CamelCaps identifiers. Please fix globally.
> + /* Get clk_adjust, cpo, write_data_delay,2T, according to the board ddr
> + * freqency and n_banks specified in board_specific_parameters table.
> + */
Incorrect multiline comment style. Please fix globally.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
"One thing they don't tell you about doing experimental physics is
that sometimes you must work under adverse conditions... like a state
of sheer terror." - W. K. Hartmann
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
