Re: [trojita] Re: GSoC merge request

2013-08-14 Thread Pali Rohár
On Thursday 08 August 2013 13:23:42 Thomas Lübking wrote: > On Donnerstag, 8. August 2013 11:24:35 CEST, Kevin Krammer wrote: > > I think what Thomas was suggesting was to make the action > > objects directly accessible instead of making Qt traverse > > the QObject tree to find them. > > Exactly.

Re: [trojita] Re: GSoC merge request

2013-08-13 Thread Pali Rohár
On Thursday 08 August 2013 09:49:37 Pali Rohár wrote: > > +void AkonadiAddressbook::openContactWindow(const QString > > &email, const QString &displayName) +{ > > +// TODO > > +#if 0 > > > > > > > > is this short-term todo or long term todo? (in latter case the > > feature should not be announ

Re: [trojita] Re: GSoC merge request

2013-08-08 Thread Pali Rohár
On Thursday 08 August 2013 19:32:13 Thomas Lübking wrote: > On Donnerstag, 8. August 2013 15:52:56 CEST, Pali Rohár wrote: > > For emails with lot of recipients this could lead to > > application crash... For each email address trojita is > > starting job. > > You mean for OOM due to job overhead?

Re: [trojita] Re: GSoC merge request

2013-08-08 Thread Pali Rohár
On Monday 29 July 2013 19:35:22 Thomas Lübking wrote: > + > +AddressbookJob *job = m_completionRequests.take(toEdit); > + > +if (job) { > +disconnect(job, 0, 0, 0); > +job->stop(); > +job->deleteLater(); > +} > > The completion race (you type faster than the bac

Re: [trojita] Re: GSoC merge request

2013-08-08 Thread Kevin Krammer
On Thursday, 2013-08-08, Jan Kundrát wrote: > On Thursday, 8 August 2013 10:44:44 CEST, Pali Rohár wrote: > > In XML file are defined menubars and toolbars with all K/QActions. > > It matching objectName(). In your cpp code you need to push all > > KActions objects to some list (KActionCollection).

Re: [trojita] Re: GSoC merge request

2013-08-08 Thread Pali Rohár
On Thursday 08 August 2013 10:26:49 Jan Kundrát wrote: > On Thursday, 8 August 2013 10:15:53 CEST, Pali Rohár wrote: > > KMail is written as KDE KPart application. > > I know nothing about KParts, so let me rephrase my suggestion > -- if there's something in KMail which is setting up the > menus e

Re: [trojita] Re: GSoC merge request

2013-08-08 Thread Pali Rohár
On Thursday 08 August 2013 10:10:54 Jan Kundrát wrote: > On Thursday, 8 August 2013 09:49:37 CEST, Pali Rohár wrote: > > KDE XML menu file contains above object names. So if > > somebody change them, it will break Kontact plugin (Kontact > > will not show any Trojita menus/buttons). So here can be

Re: [trojita] Re: GSoC merge request

2013-08-08 Thread Kevin Krammer
On Thursday, 2013-08-08, Pali Rohár wrote: > On Thursday 08 August 2013 09:38:16 Kevin Krammer wrote: > > On Thursday, 2013-08-08, Pali Rohár wrote: > > > KResourceAddressbook sounds good. Current name is > > > "KDE Addressbook (traditional)". Do you want to change it? > > > > I would use "Legacy

Re: [trojita] Re: GSoC merge request

2013-08-08 Thread Pali Rohár
On Thursday 08 August 2013 09:38:16 Kevin Krammer wrote: > On Thursday, 2013-08-08, Pali Rohár wrote: > > On Tuesday 30 July 2013 23:23:13 Kevin Krammer wrote: > > > On Tuesday, 2013-07-30, Thomas Lübking wrote: > > > > @Kevin > > > > How are chances about having query restrictions in > > > > akona

Re: [trojita] Re: GSoC merge request

2013-08-08 Thread Pali Rohár
On Tuesday 30 July 2013 22:58:42 Thomas Lübking wrote: > Set #2 of comments: > > +QAction *actionComposeMail = m_window->findChild *>(QLatin1String("action_compose_mail")); +QAction > *actionComposeDraft = m_window->findChild *>(QLatin1String("action_compose_draft")); ... > +QAction *a

Re: [trojita] Re: GSoC merge request

2013-08-08 Thread Kevin Krammer
On Thursday, 2013-08-08, Pali Rohár wrote: > On Tuesday 30 July 2013 23:23:13 Kevin Krammer wrote: > > On Tuesday, 2013-07-30, Thomas Lübking wrote: > > > +const KABC::Addressee::List &list = job->contacts(); > > > Since KABC is claimed deprecated, is there no replacement > > > API? > > > > K

Re: [trojita] Re: GSoC merge request

2013-08-08 Thread Pali Rohár
On Tuesday 30 July 2013 23:23:13 Kevin Krammer wrote: > On Tuesday, 2013-07-30, Thomas Lübking wrote: > > +void AkonadiAddressbookCompletionJob::result() > > +{ > > +NameEmailList completion; > > + > > +const KABC::Addressee::List &list = job->contacts(); > > Since KABC is claimed deprecate

Re: [trojita] Re: GSoC merge request

2013-08-08 Thread Pali Rohár
On Wednesday 31 July 2013 00:01:29 Thomas Lübking wrote: > On Dienstag, 30. Juli 2013 23:23:13 CEST, Kevin Krammer wrote: > >> +void KDEAddressbookProcess::slotApplicationLoaded() > >> this is superfluous, you can bind the finished signal to > > > > Might even connect the signal to deleteLater dir

Re: [trojita] Re: GSoC merge request

2013-08-06 Thread Pali Rohár
On Wednesday 31 July 2013 21:02:24 Thomas Lübking wrote: > +KWalletPassword::KWalletPassword(QObject *parent) : > PasswordInterface(parent) +{ > +/* > + NOTE: This is only way how to set application name to > KWallet widget. > > Just to be sure: > +TrojitaPlugin::TrojitaPlugin(KontactInte

Re: [trojita] Re: GSoC merge request

2013-07-30 Thread Kevin Krammer
On Tuesday, 2013-07-30, Thomas Lübking wrote: > +void AkonadiAddressbookCompletionJob::result() > +{ > +NameEmailList completion; > + > +const KABC::Addressee::List &list = job->contacts(); > Since KABC is claimed deprecated, is there no replacement API? KABC is a module dealing with cont

Re: [trojita] Re: GSoC merge request

2013-07-10 Thread Pali Rohár
On Wednesday 10 July 2013 20:59:21 Caspar Schutijser wrote: > On Wednesday, July 10, 2013 1:16:39 PM CEST, Pali Rohár wrote: > > I fixed this problem. Also that one which caused that tests > > was not possible to compile. Patches pushed to my same git > > branch. > > Thanks :) > > > I read throu

Re: [trojita] Re: GSoC merge request

2013-07-10 Thread Pali Rohár
On Wednesday 10 July 2013 21:35:09 Caspar Schutijser wrote: > Hi Pali, > > One other thing, related to the GUI: the minimumSize of the > added QComboBoxes in the settings dialog cause a horizontal > scrollbar to appear in the settings dialog, at least on my > computer. How about lowering the width

Re: [trojita] Re: GSoC merge request

2013-07-10 Thread Pali Rohár
On Monday 08 July 2013 22:04:33 Caspar Schutijser wrote: > Hi Pali, > > On Monday, July 8, 2013 6:10:36 PM CEST, Pali Rohár wrote: > > today I cleaned my git tree and created new (rebased) branch > > which is ready for comments and then for merging to master. > > One piece of feedback for now. >