Re: svn commit: r316938 - head/sbin/savecore

2017-04-15 Thread Rodney W. Grimes
> On Friday, April 14, 2017 07:40:57 PM Ngie Cooper wrote: > > > > > On Apr 14, 2017, at 18:49, Rodney W. Grimes > > > wrote: > > > Do we use KiB, MiB, GiB,... any place else in the system? I cant think of > > > a place we do this, so please, lets not start doing this here? > > The du manpage

Re: svn commit: r316938 - head/sbin/savecore

2017-04-15 Thread Julian Elischer
On 15/4/17 4:14 am, Slawa Olhovchenkov wrote: On Fri, Apr 14, 2017 at 01:49:51PM -0600, Alan Somers wrote: On Fri, Apr 14, 2017 at 1:41 PM, Ngie Cooper wrote: Author: ngie Date: Fri Apr 14 19:41:48 2017 New Revision: 316938 URL: https://svnweb.freebsd.org/changeset/base/316938 Log: saveco

Re: svn commit: r316938 - head/sbin/savecore

2017-04-15 Thread Julian Elischer
On 15/4/17 4:37 am, Larry Rosenman wrote: On 4/14/17, 3:33 PM, "Ngie Cooper (yaneurabeya)" wrote: > On Apr 14, 2017, at 13:26, Larry Rosenman wrote: > > On 4/14/17, 3:19 PM, "Ngie Cooper (yaneurabeya)" wrote: > >> On Apr 14, 2017, at 13:14, Slawa Olhovchenkov

Re: svn commit: r316938 - head/sbin/savecore

2017-04-15 Thread Mark Johnston
On Sat, Apr 15, 2017 at 11:39:52AM +0300, Slawa Olhovchenkov wrote: > On Fri, Apr 14, 2017 at 03:05:25PM -0700, Mark Johnston wrote: > > > > And with textdumps available, the benefit > > > of having compression is limited because we can request for minidump > > > or full dumps only when the textdu

Re: svn commit: r316938 - head/sbin/savecore

2017-04-15 Thread Mark Johnston
On Fri, Apr 14, 2017 at 11:42:04PM -0700, Rodney W. Grimes wrote: > > On Fri, Apr 14, 2017 at 06:30:17PM -0700, Rodney W. Grimes wrote: > > > > The patch to add compression support is here and should largely still > > > > work: > > > > https://people.freebsd.org/~markj/patches/core-compression/2014

Re: svn commit: r316938 - head/sbin/savecore

2017-04-15 Thread Bruce Evans
On Sat, 15 Apr 2017, John Baldwin wrote: On Friday, April 14, 2017 07:40:57 PM Ngie Cooper wrote: On Apr 14, 2017, at 18:49, Rodney W. Grimes wrote: Do we use KiB, MiB, GiB,... any place else in the system? I cant think of a place we do this, so please, lets not start doing this here? Th

Re: svn commit: r316938 - head/sbin/savecore

2017-04-15 Thread Slawa Olhovchenkov
On Sat, Apr 15, 2017 at 07:00:57AM -0700, Rodney W. Grimes wrote: > > On Fri, Apr 14, 2017 at 03:05:25PM -0700, Mark Johnston wrote: > > > > > > And with textdumps available, the benefit > > > > of having compression is limited because we can request for minidump > > > > or full dumps only when t

Re: svn commit: r316938 - head/sbin/savecore

2017-04-15 Thread John Baldwin
On Friday, April 14, 2017 07:40:57 PM Ngie Cooper wrote: > > > On Apr 14, 2017, at 18:49, Rodney W. Grimes > > wrote: > > Do we use KiB, MiB, GiB,... any place else in the system? I cant think of > > a place we do this, so please, lets not start doing this here? The du manpage does at least.

Re: svn commit: r316938 - head/sbin/savecore

2017-04-15 Thread Alexey Dokuchaev
On Fri, Apr 14, 2017 at 11:42:04PM -0700, Rodney W. Grimes wrote: > On Fri, Apr 14, 2017 at 10:37:29PM -0700, Mark Johnston wrote: > > ... > > Does "lkm" mean "loadable kernel module"? If so, why? > > Yes, so you dont have to reboot to write and debug new versions, so > you can have a kernel witho

Re: svn commit: r316938 - head/sbin/savecore

2017-04-15 Thread Rodney W. Grimes
> On Fri, Apr 14, 2017 at 03:05:25PM -0700, Mark Johnston wrote: > > > > And with textdumps available, the benefit > > > of having compression is limited because we can request for minidump > > > or full dumps only when the textdumps are not good enough for > > > diagnosing the kernel bug. > > >

Re: svn commit: r316938 - head/sbin/savecore

2017-04-15 Thread Alexey Dokuchaev
On Fri, Apr 14, 2017 at 06:41:32PM -0700, Rodney W. Grimes wrote: > On Apr 14, 2017, at 13:46, Slawa Olhovchenkov wrote: > > On Fri, Apr 14, 2017 at 01:45:22PM -0700, Ngie Cooper (yaneurabeya) wrote: > > > > On Apr 14, 2017, at 13:42, Slawa Olhovchenkov wrote: > > > > ... > > > > No, something li

Re: svn commit: r316938 - head/sbin/savecore

2017-04-15 Thread Slawa Olhovchenkov
On Fri, Apr 14, 2017 at 03:05:25PM -0700, Mark Johnston wrote: > > And with textdumps available, the benefit > > of having compression is limited because we can request for minidump > > or full dumps only when the textdumps are not good enough for > > diagnosing the kernel bug. > > Sure, but in t

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Rodney W. Grimes
> On Fri, Apr 14, 2017 at 06:30:17PM -0700, Rodney W. Grimes wrote: > > > The patch to add compression support is here and should largely still > > > work: > > > https://people.freebsd.org/~markj/patches/core-compression/20141110-kern_dump.diff > > > > > > I've been hesitant about pushing it forwa

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Mark Johnston
On Fri, Apr 14, 2017 at 07:00:36PM -0700, Conrad Meyer wrote: > Larry, > > You just need to run netdumpd on the nearby server. It could be a > port (although I'm not aware that it is ported yet). I was working on a port makefile for netdumpd before this thread started. :) It would be a bit more

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Mark Johnston
On Fri, Apr 14, 2017 at 06:30:17PM -0700, Rodney W. Grimes wrote: > > The patch to add compression support is here and should largely still > > work: > > https://people.freebsd.org/~markj/patches/core-compression/20141110-kern_dump.diff > > > > I've been hesitant about pushing it forward: > > - Th

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Rodney W. Grimes
[ Charset UTF-8 unsupported, converting... ] > > > On Apr 14, 2017, at 20:05, Rodney W. Grimes > > wrote: > > > >>> > >>> On Apr 14, 2017, at 18:49, Rodney W. Grimes > >>> wrote: > >>> > On Friday, April 14, 2017 07:41:48 PM Ngie Cooper wrote: > > Author: ngie > > Date: Fri Apr

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Rodney W. Grimes
> > > On Apr 14, 2017, at 19:40, Ngie Cooper (yaneurabeya) > > wrote: > > > >> > >> On Apr 14, 2017, at 18:49, Rodney W. Grimes > >> wrote: > >> > >>> On Friday, April 14, 2017 07:41:48 PM Ngie Cooper wrote: > Author: ngie > Date: Fri Apr 14 19:41:48 2017 > New Revision: 3169

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Ngie Cooper (yaneurabeya)
> On Apr 14, 2017, at 20:05, Rodney W. Grimes > wrote: > >>> >>> On Apr 14, 2017, at 18:49, Rodney W. Grimes >>> wrote: >>> On Friday, April 14, 2017 07:41:48 PM Ngie Cooper wrote: > Author: ngie > Date: Fri Apr 14 19:41:48 2017 > New Revision: 316938 > URL: https://svn

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Rodney W. Grimes
> > > On Apr 14, 2017, at 18:49, Rodney W. Grimes > > wrote: > > > >> On Friday, April 14, 2017 07:41:48 PM Ngie Cooper wrote: > >>> Author: ngie > >>> Date: Fri Apr 14 19:41:48 2017 > >>> New Revision: 316938 > >>> URL: https://svnweb.freebsd.org/changeset/base/316938 > >>> > >>> Log: > >>>

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Ngie Cooper (yaneurabeya)
> On Apr 14, 2017, at 19:40, Ngie Cooper (yaneurabeya) > wrote: > >> >> On Apr 14, 2017, at 18:49, Rodney W. Grimes >> wrote: >> >>> On Friday, April 14, 2017 07:41:48 PM Ngie Cooper wrote: Author: ngie Date: Fri Apr 14 19:41:48 2017 New Revision: 316938 URL: https://svn

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Ngie Cooper (yaneurabeya)
> On Apr 14, 2017, at 18:49, Rodney W. Grimes > wrote: > >> On Friday, April 14, 2017 07:41:48 PM Ngie Cooper wrote: >>> Author: ngie >>> Date: Fri Apr 14 19:41:48 2017 >>> New Revision: 316938 >>> URL: https://svnweb.freebsd.org/changeset/base/316938 >>> >>> Log: >>> savecore: fix space calc

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Conrad Meyer
That has not actually been committed yet. Mark Johnston has a patch for it. On Fri, Apr 14, 2017 at 7:17 PM, Larry Rosenman wrote: > > On 4/14/17, 9:16 PM, "Conrad Meyer" wrote: > > On Fri, Apr 14, 2017 at 7:02 PM, Larry Rosenman wrote: > > It looked like the netdump code might need so

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Larry Rosenman
On 4/14/17, 9:16 PM, "Conrad Meyer" wrote: On Fri, Apr 14, 2017 at 7:02 PM, Larry Rosenman wrote: > It looked like the netdump code might need some stuff for current –CURRENT. Not for the server (netdumpd) — it's just a simple UDP daemon that writes incoming UDP streams to

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Conrad Meyer
On Fri, Apr 14, 2017 at 7:02 PM, Larry Rosenman wrote: > It looked like the netdump code might need some stuff for current –CURRENT. Not for the server (netdumpd) — it's just a simple UDP daemon that writes incoming UDP streams to disk. Best, Conrad __

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Rodney W. Grimes
> > On 4/14/17, 8:35 PM, "Rodney W. Grimes" > > wrote: > > > > > Yeah, I have the following: > > > borg.lerctr.org /home/ler $ swapctl -l > > > Device: 1024-blocks Used: > > > /dev/mfid0p38388608 0 > > > /dev/mfid1p38388608 0 > > > /dev/mfid2

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Larry Rosenman
It looked like the netdump code might need some stuff for current –CURRENT. -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 214-642-9640 E-Mail: l...@lerctr.org US Mail: 17716 Limpia Crk, Round Rock, TX 78664-7281 On 4/14/17, 9:00 PM, "Conrad Meye

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Larry Rosenman
On 4/14/17, 8:59 PM, "Rodney W. Grimes" wrote: > On 4/14/17, 8:35 PM, "Rodney W. Grimes" wrote: > > > Yeah, I have the following: > > borg.lerctr.org /home/ler $ swapctl -l > > Device: 1024-blocks Used: > > /dev/mfid0p38388608 0 >

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Conrad Meyer
Larry, You just need to run netdumpd on the nearby server. It could be a port (although I'm not aware that it is ported yet). Best, Conrad On Fri, Apr 14, 2017 at 6:37 PM, Larry Rosenman wrote: > On 4/14/17, 8:35 PM, "Rodney W. Grimes" > wrote: > >> Yeah, I have the following: > > borg.l

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Rodney W. Grimes
> On 4/14/17, 8:35 PM, "Rodney W. Grimes" > wrote: > > > Yeah, I have the following: > > borg.lerctr.org /home/ler $ swapctl -l > > Device: 1024-blocks Used: > > /dev/mfid0p38388608 0 > > /dev/mfid1p38388608 0 > > /dev/mfid2p38388608

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Rodney W. Grimes
> On Friday, April 14, 2017 07:41:48 PM Ngie Cooper wrote: > > Author: ngie > > Date: Fri Apr 14 19:41:48 2017 > > New Revision: 316938 > > URL: https://svnweb.freebsd.org/changeset/base/316938 > > > > Log: > > savecore: fix space calculation with respect to `minfree` in > > check_space(..) > >

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Rodney W. Grimes
[ Charset UTF-8 unsupported, converting... ] > On Fri, Apr 14, 2017 at 01:45:22PM -0700, Ngie Cooper (yaneurabeya) wrote: > > > > > > On Apr 14, 2017, at 13:42, Slawa Olhovchenkov wrote: > > > > ? > > > > > No, something like: > > > % swapinfo > > > Device 1K-blocks UsedAvail

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Larry Rosenman
On 4/14/17, 8:35 PM, "Rodney W. Grimes" wrote: > Yeah, I have the following: > borg.lerctr.org /home/ler $ swapctl -l > Device: 1024-blocks Used: > /dev/mfid0p38388608 0 > /dev/mfid1p38388608 0 > /dev/mfid2p38388608 0 > /dev/mf

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Rodney W. Grimes
> On 4/14/17, 3:39 PM, "Ngie Cooper (yaneurabeya)" > wrote: > > > > On Apr 14, 2017, at 13:37, Larry Rosenman wrote: > > > > On 4/14/17, 3:33 PM, "Ngie Cooper (yaneurabeya)" > wrote: > > > >> On Apr 14, 2017, at 13:26, Larry Rosenman wrote: > >> > >> On 4/

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Rodney W. Grimes
> On Fri, Apr 14, 2017 at 01:49:51PM -0600, Alan Somers wrote: > > On Fri, Apr 14, 2017 at 1:41 PM, Ngie Cooper wrote: > > > Author: ngie > > > Date: Fri Apr 14 19:41:48 2017 > > > New Revision: 316938 > > > URL: https://svnweb.freebsd.org/changeset/base/316938 > > > > > > Log: > > > savecore: f

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Mark Johnston
On Fri, Apr 14, 2017 at 02:28:57PM -0700, Xin LI wrote: > On Fri, Apr 14, 2017 at 1:29 PM, Mark Johnston wrote: > > - I'm not sure how encryption should compose with compression. It seems > > intuitively obvious that we should compress before encrypting if the > > compression is to be of any u

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Ngie Cooper (yaneurabeya)
> On Apr 14, 2017, at 2:40 PM, John Baldwin wrote: > > On Friday, April 14, 2017 07:41:48 PM Ngie Cooper wrote: >> Author: ngie >> Date: Fri Apr 14 19:41:48 2017 >> New Revision: 316938 >> URL: https://svnweb.freebsd.org/changeset/base/316938 >> >> Log: >> savecore: fix space calculation with

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread John Baldwin
On Friday, April 14, 2017 07:41:48 PM Ngie Cooper wrote: > Author: ngie > Date: Fri Apr 14 19:41:48 2017 > New Revision: 316938 > URL: https://svnweb.freebsd.org/changeset/base/316938 > > Log: > savecore: fix space calculation with respect to `minfree` in check_space(..) > > - Use strtoll(3

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Xin LI
On Fri, Apr 14, 2017 at 1:29 PM, Mark Johnston wrote: > - I'm not sure how encryption should compose with compression. It seems > intuitively obvious that we should compress before encrypting if the > compression is to be of any use, but I don't know enough to know > whether the compression

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Xin LI
No, this is not the threat model for swaps. On Fri, Apr 14, 2017 at 1:47 PM, Ronald Klop wrote: > On Fri, 14 Apr 2017 22:29:18 +0200, Mark Johnston wrote: > >> On Fri, Apr 14, 2017 at 01:49:51PM -0600, Alan Somers wrote: >>> >>> On Fri, Apr 14, 2017 at 1:41 PM, Ngie Cooper wrote: >>> > Author:

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Conrad Meyer
On Fri, Apr 14, 2017 at 1:41 PM, Alan Somers wrote: > On Fri, Apr 14, 2017 at 2:29 PM, Mark Johnston wrote: >> I've been hesitant about pushing it forward: >> - The dump_write* APIs need some simplification after the addition of >> encrypted dump support and support for dumping to 4Kn drives. >

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Ngie Cooper (yaneurabeya)
> On Apr 14, 2017, at 13:48, Larry Rosenman wrote: … > No can do, the rest of the space is pool. >_>… that sucks. This is part of the reason why I still make my swap partitions >greater than or equal to the amount of memory I have in systems :/.. The best recommendation I have is either: wait

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Larry Rosenman
On 4/14/17, 3:46 PM, "Ngie Cooper (yaneurabeya)" wrote: > On Apr 14, 2017, at 13:43, Larry Rosenman wrote: > > On 4/14/17, 3:39 PM, "Ngie Cooper (yaneurabeya)" wrote: > >> On Apr 14, 2017, at 13:37, Larry Rosenman wrote: >> >> On 4/14/17, 3:33 PM, "Ngie Coo

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Ngie Cooper (yaneurabeya)
> On Apr 14, 2017, at 13:46, Slawa Olhovchenkov wrote: > > On Fri, Apr 14, 2017 at 01:45:22PM -0700, Ngie Cooper (yaneurabeya) wrote: > >> >>> On Apr 14, 2017, at 13:42, Slawa Olhovchenkov wrote: >> >> … >> >>> No, something like: >>> % swapinfo >>> Device 1K-blocks UsedAva

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Ronald Klop
On Fri, 14 Apr 2017 22:29:18 +0200, Mark Johnston wrote: On Fri, Apr 14, 2017 at 01:49:51PM -0600, Alan Somers wrote: On Fri, Apr 14, 2017 at 1:41 PM, Ngie Cooper wrote: > Author: ngie > Date: Fri Apr 14 19:41:48 2017 > New Revision: 316938 > URL: https://svnweb.freebsd.org/changeset/base/3

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Ngie Cooper (yaneurabeya)
> On Apr 14, 2017, at 13:43, Larry Rosenman wrote: > > On 4/14/17, 3:39 PM, "Ngie Cooper (yaneurabeya)" > wrote: > >> On Apr 14, 2017, at 13:37, Larry Rosenman wrote: >> >> On 4/14/17, 3:33 PM, "Ngie Cooper (yaneurabeya)" >> wrote: >> >>> On Apr 14, 2017, at 13:26, Larry Rosenman wrote:

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Slawa Olhovchenkov
On Fri, Apr 14, 2017 at 01:45:22PM -0700, Ngie Cooper (yaneurabeya) wrote: > > > On Apr 14, 2017, at 13:42, Slawa Olhovchenkov wrote: > > … > > > No, something like: > > % swapinfo > > Device 1K-blocks UsedAvail Capacity > > /dev/ada0p2 335544320 33554432 0% >

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Ngie Cooper (yaneurabeya)
> On Apr 14, 2017, at 13:42, Slawa Olhovchenkov wrote: … > No, something like: > % swapinfo > Device 1K-blocks UsedAvail Capacity > /dev/ada0p2 335544320 33554432 0% > /dev/ada1p2 335544320 33554432 0% > Total671088640 67108

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Larry Rosenman
On 4/14/17, 3:39 PM, "Ngie Cooper (yaneurabeya)" wrote: > On Apr 14, 2017, at 13:37, Larry Rosenman wrote: > > On 4/14/17, 3:33 PM, "Ngie Cooper (yaneurabeya)" wrote: > >> On Apr 14, 2017, at 13:26, Larry Rosenman wrote: >> >> On 4/14/17, 3:19 PM, "Ngie Coo

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Slawa Olhovchenkov
On Fri, Apr 14, 2017 at 01:33:36PM -0700, Ngie Cooper (yaneurabeya) wrote: > > > On Apr 14, 2017, at 13:26, Larry Rosenman wrote: > > > > On 4/14/17, 3:19 PM, "Ngie Cooper (yaneurabeya)" > > wrote: > > > >> On Apr 14, 2017, at 13:14, Slawa Olhovchenkov wrote: > >> > >> On Fri, Apr 14, 2017

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Alan Somers
On Fri, Apr 14, 2017 at 2:29 PM, Mark Johnston wrote: > On Fri, Apr 14, 2017 at 01:49:51PM -0600, Alan Somers wrote: >> On Fri, Apr 14, 2017 at 1:41 PM, Ngie Cooper wrote: >> > Author: ngie >> > Date: Fri Apr 14 19:41:48 2017 >> > New Revision: 316938 >> > URL: https://svnweb.freebsd.org/changese

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Ngie Cooper (yaneurabeya)
> On Apr 14, 2017, at 13:37, Larry Rosenman wrote: > > On 4/14/17, 3:33 PM, "Ngie Cooper (yaneurabeya)" > wrote: > >> On Apr 14, 2017, at 13:26, Larry Rosenman wrote: >> >> On 4/14/17, 3:19 PM, "Ngie Cooper (yaneurabeya)" >> wrote: >> >>> On Apr 14, 2017, at 13:14, Slawa Olhovchenkov wr

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Larry Rosenman
On 4/14/17, 3:33 PM, "Ngie Cooper (yaneurabeya)" wrote: > On Apr 14, 2017, at 13:26, Larry Rosenman wrote: > > On 4/14/17, 3:19 PM, "Ngie Cooper (yaneurabeya)" wrote: > >> On Apr 14, 2017, at 13:14, Slawa Olhovchenkov wrote: >> >> On Fri, Apr 14, 2017 at 01

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Ngie Cooper (yaneurabeya)
> On Apr 14, 2017, at 13:26, Larry Rosenman wrote: > > On 4/14/17, 3:19 PM, "Ngie Cooper (yaneurabeya)" > wrote: > >> On Apr 14, 2017, at 13:14, Slawa Olhovchenkov wrote: >> >> On Fri, Apr 14, 2017 at 01:49:51PM -0600, Alan Somers wrote: >> >>> On Fri, Apr 14, 2017 at 1:41 PM, Ngie Cooper

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Mark Johnston
On Fri, Apr 14, 2017 at 01:49:51PM -0600, Alan Somers wrote: > On Fri, Apr 14, 2017 at 1:41 PM, Ngie Cooper wrote: > > Author: ngie > > Date: Fri Apr 14 19:41:48 2017 > > New Revision: 316938 > > URL: https://svnweb.freebsd.org/changeset/base/316938 > > > > Log: > > savecore: fix space calculati

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Larry Rosenman
On 4/14/17, 3:19 PM, "Ngie Cooper (yaneurabeya)" wrote: > On Apr 14, 2017, at 13:14, Slawa Olhovchenkov wrote: > > On Fri, Apr 14, 2017 at 01:49:51PM -0600, Alan Somers wrote: > >> On Fri, Apr 14, 2017 at 1:41 PM, Ngie Cooper wrote: >>> Author: ngie >>> Date:

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Ngie Cooper (yaneurabeya)
> On Apr 14, 2017, at 13:14, Slawa Olhovchenkov wrote: > > On Fri, Apr 14, 2017 at 01:49:51PM -0600, Alan Somers wrote: > >> On Fri, Apr 14, 2017 at 1:41 PM, Ngie Cooper wrote: >>> Author: ngie >>> Date: Fri Apr 14 19:41:48 2017 >>> New Revision: 316938 >>> URL: https://svnweb.freebsd.org/chan

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Slawa Olhovchenkov
On Fri, Apr 14, 2017 at 01:49:51PM -0600, Alan Somers wrote: > On Fri, Apr 14, 2017 at 1:41 PM, Ngie Cooper wrote: > > Author: ngie > > Date: Fri Apr 14 19:41:48 2017 > > New Revision: 316938 > > URL: https://svnweb.freebsd.org/changeset/base/316938 > > > > Log: > > savecore: fix space calculat

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Ngie Cooper (yaneurabeya)
> On Apr 14, 2017, at 13:04, Ngie Cooper (yaneurabeya) > wrote: > > >> On Apr 14, 2017, at 13:02, Alan Somers wrote: > > ... > >> Right: check_size() needs to know the on-disk size of the core dump. >> But it doesn't have any way to know the on-disk size until after it's >> written everythi

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Ngie Cooper (yaneurabeya)
> On Apr 14, 2017, at 13:02, Alan Somers wrote: ... > Right: check_size() needs to know the on-disk size of the core dump. > But it doesn't have any way to know the on-disk size until after it's > written everything to disk. That's why I simply disabled the check at > $WORK. Another possibili

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Alan Somers
On Fri, Apr 14, 2017 at 1:58 PM, Ngie Cooper (yaneurabeya) wrote: > >> On Apr 14, 2017, at 12:49, Alan Somers wrote: >> >> On Fri, Apr 14, 2017 at 1:41 PM, Ngie Cooper wrote: >>> Author: ngie >>> Date: Fri Apr 14 19:41:48 2017 >>> New Revision: 316938 >>> URL: https://svnweb.freebsd.org/changese

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Ngie Cooper (yaneurabeya)
> On Apr 14, 2017, at 12:49, Alan Somers wrote: > > On Fri, Apr 14, 2017 at 1:41 PM, Ngie Cooper wrote: >> Author: ngie >> Date: Fri Apr 14 19:41:48 2017 >> New Revision: 316938 >> URL: https://svnweb.freebsd.org/changeset/base/316938 >> >> Log: >> savecore: fix space calculation with respect

Re: svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Alan Somers
On Fri, Apr 14, 2017 at 1:41 PM, Ngie Cooper wrote: > Author: ngie > Date: Fri Apr 14 19:41:48 2017 > New Revision: 316938 > URL: https://svnweb.freebsd.org/changeset/base/316938 > > Log: > savecore: fix space calculation with respect to `minfree` in check_space(..) > > - Use strtoll(3) instea

svn commit: r316938 - head/sbin/savecore

2017-04-14 Thread Ngie Cooper
Author: ngie Date: Fri Apr 14 19:41:48 2017 New Revision: 316938 URL: https://svnweb.freebsd.org/changeset/base/316938 Log: savecore: fix space calculation with respect to `minfree` in check_space(..) - Use strtoll(3) instead of atoi(3), because atoi(3) limits the representable data to