On Thu, 1 Jun 2023 10:12:02 GMT, Stefan Karlsson wrote:
>> Kelvin Nilsen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Make the order of young/old collector checks consistent (#1)
>
> src/hotspot/share/gc/shared/gcConfiguration.cpp lin
On Sun, 4 Jun 2023 21:39:58 GMT, Kelvin Nilsen wrote:
>> OpenJDK Colleagues:
>>
>> Please review this proposed integration of Generational mode for Shenandoah
>> GC under https://bugs.openjdk.org/browse/JDK-8307314.
>>
>> Generational mode of Shenandoah is enabled by adding
>> `-XX:+UnlockExp
On Thu, 1 Aug 2024 15:20:41 GMT, Chris Plummer wrote:
>> The alternative is of course to not burden the VM and heap dumpers with this
>> but instead provide tooling to process a HPROF heap dump to zero the
>> contents of Strings and other fields.
>
>> The alternative is of course to not burden
On Thu, 1 Aug 2024 21:46:04 GMT, Henry Lin wrote:
>> Adds a command line option `-redact` to `jcmd` and `-XX:+HeapDumpRedacted`
>> enabling redacted heap dumps. When enabled, the output binary heap dump has
>> zeroes written out in place of the original primitive values in the object
>> fields
> This PR merges JEP 404, a generational mode for the Shenandoah garbage
> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We would
> like to target JDK24 with this PR.
William Kemper has updated the pull request with a new target base due to a
merge or a rebase.
On Thu, 10 Oct 2024 18:47:38 GMT, Roman Kennke wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 478 commits:
>>
>> - Fix merge error
>> - Merge remote-tracking branch
On Thu, 10 Oct 2024 12:48:05 GMT, Roman Kennke wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 478 commits:
>>
>> - Fix merge error
>> - Merge remote-tracking branch
On Fri, 11 Oct 2024 15:13:07 GMT, Roman Kennke wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 478 commits:
>>
>> - Fix merge error
>> - Merge remote-tracking branch
On Thu, 10 Oct 2024 13:14:15 GMT, Roman Kennke wrote:
>> src/hotspot/share/gc/shenandoah/heuristics/shenandoahHeuristics.hpp line 79:
>>
>>> 77:
>>> 78: protected:
>>> 79: static const uint Moving_Average_Samples = 10; // Number of samples
>>> to store in moving averages
>>
>> I've never se
On Fri, 11 Oct 2024 10:14:31 GMT, Roman Kennke wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 478 commits:
>>
>> - Fix merge error
>> - Merge remote-tracking branch
On Fri, 11 Oct 2024 11:01:54 GMT, Roman Kennke wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 478 commits:
>>
>> - Fix merge error
>> - Merge remote-tracking branch
On Fri, 11 Oct 2024 21:20:55 GMT, William Kemper wrote:
>> src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp line 535:
>>
>>> 533: ShenandoahPacer* pacer() const { return
>>> _pacer; }
>>> 534:
>>> 5
On Thu, 10 Oct 2024 17:44:03 GMT, Roman Kennke wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 478 commits:
>>
>> - Fix merge error
>> - Merge remote-tracking branch
> This PR merges JEP 404, a generational mode for the Shenandoah garbage
> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We would
> like to target JDK24 with this PR.
William Kemper has updated the pull request with a new target base due to a
merge or a re
> This PR merges JEP 404, a generational mode for the Shenandoah garbage
> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We would
> like to target JDK24 with this PR.
William Kemper has updated the pull request with a new target base due to a
merge or a rebase.
On Fri, 11 Oct 2024 21:17:59 GMT, William Kemper wrote:
>> src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp line 579:
>>
>>> 577: st->print("Status: ");
>>> 578: if (has_forwarded_objects()) st->print(
> This PR merges JEP 404, a generational mode for the Shenandoah garbage
> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We would
> like to target JDK24 with this PR.
William Kemper has updated the pull request with a new target base due to a
merge or a rebase.
On Fri, 11 Oct 2024 21:21:57 GMT, William Kemper wrote:
>> src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp line 396:
>>
>>> 394: }
>>> 395:
>>> 396: inline bool ShenandoahHeap::is_old(oop obj) const {
>>
>> What is the difference
On Mon, 21 Oct 2024 21:16:50 GMT, William Kemper wrote:
>> This PR merges JEP 404, a generational mode for the Shenandoah garbage
>> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We
>> would like to target JDK24 with this PR.
>
> William Kem
On Wed, 9 Oct 2024 03:26:30 GMT, Liang Mao wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 478 commits:
>>
>> - Fix merge error
>> - Merge remote-tracking branch 'jdk/
On Sat, 26 Oct 2024 02:05:28 GMT, Zhengyu Gu wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 492 commits:
>>
>> - Merge remote-tracking branch 'shenandoah/master
On Sat, 26 Oct 2024 01:33:23 GMT, Zhengyu Gu wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 492 commits:
>>
>> - Merge remote-tracking branch 'shenandoah/master
> This PR merges JEP 404, a generational mode for the Shenandoah garbage
> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We would
> like to target JDK24 with this PR.
William Kemper has updated the pull request with a new target base due to a
merge or a rebase.
On Wed, 30 Oct 2024 02:09:46 GMT, Liang Mao wrote:
>> We disabled tiered compilation to force everything to compile through C2 to
>> get more consistent results.
>
> @earthling-amzn ，thanks for providing your options. Looks like disabling
> pacing would help the score.
>
> -XX:+UseShenandoahG
> This PR merges JEP 404, a generational mode for the Shenandoah garbage
> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We would
> like to target JDK24 with this PR.
William Kemper has updated the pull request with a new target base due to a
merge or a rebase.
This PR merges JEP 404, a generational mode for the Shenandoah garbage
collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We would
like to target JDK24 with this PR.
-
Commit messages:
- 8337511: Implement JEP-404: Generational Shenandoah (Experimental)
Changes:
On Fri, 11 Oct 2024 13:43:46 GMT, Roman Kennke wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 478 commits:
>>
>> - Fix merge error
>> - Merge remote-tracking branch
On Thu, 10 Oct 2024 12:58:56 GMT, Roman Kennke wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 478 commits:
>>
>> - Fix merge error
>> - Merge remote-tracking branch
On Fri, 11 Oct 2024 22:12:25 GMT, Y. Srinivas Ramakrishna
wrote:
>> src/hotspot/share/gc/shenandoah/shenandoahCardStats.hpp line 40:
>>
>>> 38: DIRTY_SCAN_OBJS = 6,
>>> 39: ALTERNATIONS= 7,
>>> 40: MAX_CARD_STAT_TYPE = 8
>>
>> Are the numerical values relevant or what is the
> This PR merges JEP 404, a generational mode for the Shenandoah garbage
> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We would
> like to target JDK24 with this PR.
William Kemper has updated the pull request incrementally with one additional
commit since
On Mon, 25 Nov 2024 18:22:09 GMT, Aleksey Shipilev wrote:
>> I'll make some adjustments here. Note that `OLD_MARKING` also implies (and
>> sets) `MARKING`, and - unlike `YOUNG_MARKING` - is not exclusive with
>> `EVACUTION` and `UPDATEREFS`. Perhaps an explanatory comment is the best
>> option
On Thu, 21 Nov 2024 18:30:31 GMT, Aleksey Shipilev wrote:
>> Yes, in single gen mode we set `MARKING` and `YOUNG_MARKING` together. See
>> https://github.com/openjdk/shenandoah/blob/master/src/hotspot/share/gc/shenandoah/shenandoahGlobalGeneration.cpp#L81
>
> We should really either predicate it
> This PR merges JEP 404, a generational mode for the Shenandoah garbage
> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We would
> like to target JDK24 with this PR.
William Kemper has updated the pull request with a new target base due to a
merge or a rebase.
On Wed, 20 Nov 2024 19:55:35 GMT, Aleksey Shipilev wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 510 commits:
>>
>> - Merge branch 'merge-latest' into great-genshen-pr
On Fri, 15 Nov 2024 15:12:30 GMT, Martin Doerr wrote:
>> The new test TestAllocOutOfMemory.java#large failed on some PPC64 machines:
>>
>> Exception: java.lang.OutOfMemoryError thrown from the
>> UncaughtExceptionHandler in thread "main"
>>
>> java.lang.RuntimeException: 'java.lang.OutOfMemory
On Fri, 15 Nov 2024 17:01:29 GMT, Aleksey Shipilev wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 510 commits:
>>
>> - Merge branch 'merge-latest' into great-genshen-pr
On Mon, 18 Nov 2024 16:22:31 GMT, Aleksey Shipilev wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 510 commits:
>>
>> - Merge branch 'merge-latest' into great-genshen-pr
On Tue, 19 Nov 2024 17:31:15 GMT, Aleksey Shipilev wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 510 commits:
>>
>> - Merge branch 'merge-latest' into great-genshen-pr
On Tue, 19 Nov 2024 17:35:14 GMT, Aleksey Shipilev wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 510 commits:
>>
>> - Merge branch 'merge-latest' into great-genshen-pr
On Wed, 20 Nov 2024 16:47:20 GMT, Aleksey Shipilev wrote:
>> No, in single gen mode regions that are not `FREE` are affiliated with
>> `YOUNG`.
>
> That's weird. We have `Young`, `Old` and `Global` generations. Why
> affiliation is not `Free`, `Young`, `Old`, and `Global` then?
Yes, it's a lit
On Tue, 19 Nov 2024 23:56:56 GMT, William Kemper wrote:
>> src/hotspot/share/gc/shenandoah/shenandoahReferenceProcessor.cpp line 455:
>>
>>> 453: // Note: would be sufficient to mark only the card that holds the
>>> start of this Reference object.
>>
On Mon, 18 Nov 2024 16:42:50 GMT, Aleksey Shipilev wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 510 commits:
>>
>> - Merge branch 'merge-latest' into great-genshen-pr
On Tue, 19 Nov 2024 12:38:59 GMT, Aleksey Shipilev wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 510 commits:
>>
>> - Merge branch 'merge-latest' into great-genshen-pr
On Mon, 18 Nov 2024 16:20:09 GMT, Aleksey Shipilev wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 510 commits:
>>
>> - Merge branch 'merge-latest' into great-genshen-pr
On Tue, 19 Nov 2024 16:46:36 GMT, Aleksey Shipilev wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 510 commits:
>>
>> - Merge branch 'merge-latest' into great-genshen-pr
On Thu, 14 Nov 2024 19:26:12 GMT, Aleksey Shipilev wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 510 commits:
>>
>> - Merge branch 'merge-latest' into great-genshen-pr
On Thu, 14 Nov 2024 19:16:30 GMT, Aleksey Shipilev wrote:
>> See, with current code, default Shenandoah prints this:
>>
>>
>> [0.025s][info][gc] GC(0) Concurrent reset (NON-GENERATIONAL) (unload
>> classes) 0.135ms
>> [0.025s][info][gc] GC(0) Pause Init Mark (NON-GENERATIONAL) (unload classes)
On Fri, 15 Nov 2024 15:12:30 GMT, Martin Doerr wrote:
>> The new test TestAllocOutOfMemory.java#large failed on some PPC64 machines:
>>
>> Exception: java.lang.OutOfMemoryError thrown from the
>> UncaughtExceptionHandler in thread "main"
>>
>> java.lang.RuntimeException: 'java.lang.OutOfMemory
On Fri, 15 Nov 2024 14:05:51 GMT, Aleksey Shipilev wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 510 commits:
>>
>> - Merge branch 'merge-latest' into great-genshen-pr
On Wed, 13 Nov 2024 11:01:59 GMT, Aleksey Shipilev wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 503 commits:
>>
>> - Merge openjdk/jdk tip into great-genshen-pr-redux
>
On Wed, 13 Nov 2024 10:57:08 GMT, Aleksey Shipilev wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 503 commits:
>>
>> - Merge openjdk/jdk tip into great-genshen-pr-redux
>
On Tue, 12 Nov 2024 19:41:14 GMT, Aleksey Shipilev wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 510 commits:
>>
>> - Merge branch 'merge-latest' into great-genshen-pr
On Wed, 13 Nov 2024 23:14:23 GMT, William Kemper wrote:
>> src/hotspot/share/gc/shenandoah/shenandoahAsserts.hpp line 238:
>>
>>> 236: #define shenandoah_assert_control_or_vm_thread_at_safepoint()
>>> 237: #define shenandoah_assert_g
On Tue, 12 Nov 2024 14:25:30 GMT, Aleksey Shipilev wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 503 commits:
>>
>> - Merge openjdk/jdk tip into great-genshen-pr-redux
>
On Thu, 14 Nov 2024 23:39:08 GMT, Martin Doerr wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 510 commits:
>>
>> - Merge branch 'merge-latest' into great-genshen-pr
> This PR merges JEP 404, a generational mode for the Shenandoah garbage
> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We would
> like to target JDK24 with this PR.
William Kemper has updated the pull request with a new target base due to a
merge or a rebase.
On Tue, 26 Nov 2024 00:37:32 GMT, William Kemper wrote:
>> This PR merges JEP 404, a generational mode for the Shenandoah garbage
>> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We
>> would like to target JDK24 with this PR.
>
> William Kem
On Wed, 13 Nov 2024 12:23:26 GMT, Aleksey Shipilev wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 503 commits:
>>
>> - Merge openjdk/jdk tip into great-genshen-pr-redux
>
On Fri, 15 Nov 2024 14:11:10 GMT, Aleksey Shipilev wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 510 commits:
>>
>> - Merge branch 'merge-latest' into great-genshen-pr
> This PR merges JEP 404, a generational mode for the Shenandoah garbage
> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We would
> like to target JDK24 with this PR.
William Kemper has updated the pull request incrementally with two additional
commits since
On Mon, 30 Sep 2024 22:02:45 GMT, William Kemper wrote:
> This PR merges JEP 404, a generational mode for the Shenandoah garbage
> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We would
> like to target JDK24 with this PR.
This pull request has now been i
This test makes assertions about the number of gc manager beans and the number
of memory pools. The generational mode for Shenandoah adds another memory pool.
-
Commit messages:
- Fix summary, remove debugging
- Separate test for Shenandoah's generational mode
Changes: https://git
On Thu, 12 Dec 2024 00:01:41 GMT, William Kemper wrote:
> This test makes assertions about the number of gc manager beans and the
> number of memory pools. The generational mode for Shenandoah adds another
> memory pool.
This pull request has now been integrated.
Changeset: cfa04d
> This test makes assertions about the number of gc manager beans and the
> number of memory pools. The generational mode for Shenandoah adds another
> memory pool.
William Kemper has updated the pull request incrementally with one additional
commit since the last revision:
Update
> This PR merges JEP 404, a generational mode for the Shenandoah garbage
> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We would
> like to target JDK24 with this PR.
William Kemper has updated the pull request with a new target base due to a
merge or a rebase.
On Thu, 21 Nov 2024 09:14:57 GMT, Aleksey Shipilev wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 524 commits:
>>
>> - Merge remote-tracking branch 'shenandoah/master
On Tue, 19 Nov 2024 23:17:48 GMT, William Kemper wrote:
>> src/hotspot/share/gc/shenandoah/shenandoahMarkClosures.hpp line 34:
>>
>>> 32: class ShenandoahHeapRegion;
>>> 33:
>>> 34: class ShenandoahFinalMarkUpdateRegionStateClosure : public
>>&g
On Thu, 21 Nov 2024 17:02:58 GMT, Aleksey Shipilev wrote:
>> Hmm, I find the version in the PR much more readable. How about we upstream
>> these changes separately?
>
> Yes, let's do that, if you have cycles.
https://bugs.openjdk.org/browse/JDK-8344797
-
PR Review Comment: https:
On Thu, 21 Nov 2024 10:15:27 GMT, Aleksey Shipilev wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 524 commits:
>>
>> - Merge remote-tracking branch 'shenandoah/master
On Thu, 21 Nov 2024 10:16:16 GMT, Aleksey Shipilev wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 524 commits:
>>
>> - Merge remote-tracking branch 'shenandoah/master
On Thu, 21 Nov 2024 20:10:20 GMT, William Kemper wrote:
>> src/hotspot/share/gc/shenandoah/shenandoahMarkingContext.cpp line 64:
>>
>>> 62: }
>>> 63: }
>>> 64: return _mark_bit_map.is_bitmap_clear_range(start, end);
>>
>> Compre
On Thu, 21 Nov 2024 13:50:42 GMT, Aleksey Shipilev wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 524 commits:
>>
>> - Merge remote-tracking branch 'shenandoah/master
On Thu, 21 Nov 2024 20:20:12 GMT, Y. Srinivas Ramakrishna
wrote:
>> src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp line 1972:
>>
>>> 1970: // Check that if concurrent weak root is set then active_gen isn't
>>> null
>>> 1971: assert(!is_concurrent_weak_root_in_progress() ||
>>> active_
On Thu, 21 Nov 2024 13:22:42 GMT, Aleksey Shipilev wrote:
>> William Kemper has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 524 commits:
>>
>> - Merge remote-tracking branch 'shenandoah/master
On Tue, 21 Jan 2025 18:48:13 GMT, William Kemper wrote:
> This is a clean backport and addresses a fairly critical issue where in a
> mistimed heap dump may cause heap corruption or vm crashes for Shenandoah GC.
This pull request has now been integrated.
Changeset: febcfd69
Author:W
This occurs when an attempt to produce a heap dump conflicts with a concurrent
cycle. The heap dump vm operation attempts to run a cycle directly on the VM
thread with no regard for the state of the concurrent collection. Although
Shenandoah _is_ technically capable of running an entire _full_ G
On Fri, 17 Jan 2025 23:12:14 GMT, William Kemper wrote:
> This occurs when an attempt to produce a heap dump conflicts with a
> concurrent cycle. The heap dump vm operation attempts to run a cycle directly
> on the VM thread with no regard for the state of the concurrent c
This is a clean backport and addresses a fairly critical issue where in a
mistimed heap dump may cause heap corruption or vm crashes for Shenandoah GC.
-
Commit messages:
- Backport 6a29a8110ec38b4adc8163ba8651cbc935353f1d
Changes: https://git.openjdk.org/jdk/pull/23221/files
Web
On Thu, 12 Jun 2025 23:42:41 GMT, William Kemper wrote:
> Remove `GCCause::_no_cause_specified` (only referenced by Shenandoah) and add
> a case for `_shenandoah_humongous_allocation_failure` in `GCCause::to_string`
> and the `SA` analog.
This pull request has now been integrated.
We can remove `GCCause::_no_cause_specified` and need to add a case for
`_shenandoah_humongous_allocation_failure` in `GCCause::to_string`. We are also
missing `_shenandoah_humongous_allocation_failure` in the `SA` analog.
-
Commit messages:
- Fix typo
- Clean up/fix gc causes for
On Thu, 12 Jun 2025 23:42:41 GMT, William Kemper wrote:
> We can remove `GCCause::_no_cause_specified` and need to add a case for
> `_shenandoah_humongous_allocation_failure` in `GCCause::to_string`. We are
> also missing `_shenandoah_humongous_allocation_failure` in the `SA` ana
81 matches
Mail list logo
