On Thu, 21 Nov 2024 20:20:12 GMT, Y. Srinivas Ramakrishna <y...@openjdk.org> wrote:
>> src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp line 1972: >> >>> 1970: // Check that if concurrent weak root is set then active_gen isn't >>> null >>> 1971: assert(!is_concurrent_weak_root_in_progress() || >>> active_generation() != nullptr, "Error"); >>> 1972: shenandoah_assert_generations_reconciled(); >> >> Why all of this is checked here? I would have thought `gc_state` machinery >> should only check things related to gc-state. > > Likely debugging detritus that I unintentionally left behind. Feel free to > delete. > I think the `shenandoah_assert_generations_reconciled()` is already checked > in a most spots where it's needed. https://bugs.openjdk.org/browse/JDK-8344797 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21273#discussion_r1852949534
