On Thu, 1 Aug 2024 21:46:04 GMT, Henry Lin <d...@openjdk.org> wrote: >> Adds a command line option `-redact` to `jcmd` and `-XX:+HeapDumpRedacted` >> enabling redacted heap dumps. When enabled, the output binary heap dump has >> zeroes written out in place of the original primitive values in the object >> fields. There is a new jtreg test `heapDumpRedactedTest.java` that tests >> that the fields are properly redacted. > > Henry Lin has updated the pull request incrementally with three additional > commits since the last revision: > > - refactored redact conditional > - format HeapDumpRedactedTest.java > - Revert "add jmap redact" > > This reverts commit e87b74e7d9d58867f7d64bb0ae331cba665e05d4.
This review has gone quiet. I sense that there are no major technical objections to the change, but that the consensus prefers to leave this functionality to external tools. If there are no further comments by the end of the week, we will withdraw this pull request. ------------- PR Comment: https://git.openjdk.org/jdk/pull/20409#issuecomment-2299665864
