On Thu, 10 Oct 2024 13:14:15 GMT, Roman Kennke <rken...@openjdk.org> wrote:
>> src/hotspot/share/gc/shenandoah/heuristics/shenandoahHeuristics.hpp line 79: >> >>> 77: >>> 78: protected: >>> 79: static const uint Moving_Average_Samples = 10; // Number of samples >>> to store in moving averages >> >> I've never seen that style for constants in HotSpot before. I'd either make >> it MOVING_AVERAGE_SAMPLES or MovingAverageSamples. I think the latter is >> more prevalent, but I am not certain. > > Oh but I see that it's used in this source file. Hmm... So maybe stick with > it for now and make a follow-up change? Yes. I agree this is idiosyncratic formatting for the rest of HotSpot, but it is consistent with pre-existing constants in this file: static const intx Concurrent_Adjust = -1; // recover from penalties static const intx Degenerated_Penalty = 10; // how much to penalize average GC duration history on Degenerated GC static const intx Full_Penalty = 20; // how much to penalize average GC duration history on Full GC ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21273#discussion_r1797428779
