On Tue, 10 Sep 2024 21:47:15 GMT, Magnus Ihse Bursie wrote:
> sort out the mess that is libawt_headless/libawt_xawt
sounds good. can you point me to a JBS?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/20666#discussion_r1753307449
On Tue, 10 Sep 2024 19:11:30 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Thu, 15 Aug 2024 20:28:28 GMT, Dhamoder Nalla wrote:
>> Use the GetTempPath2 APIs instead of the GetTempPath APIs in native code
>> across the OpenJDK repository to retrieve the temporary directory path, as
>> GetTempPath2 provides enhanced security. While GetTempPath may still
>> function
On Tue, 10 Sep 2024 00:27:23 GMT, Chris Plummer wrote:
> This test fails periodically. It only prints the exception message when it
> fails. It should print the entire stack trace so we have a better idea of why
> it is failing.
>
> Testing: This test is not run until tier5 CI testing, so I'm
Man page update to warn of deprecation of the jshdb debug subcommand and
--connect option.
-
Commit messages:
- 8339927: Man page update for deprecating jhsdb debugd for removal
Changes: https://git.openjdk.org/jdk/pull/20946/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr
On Wed, 11 Sep 2024 11:53:19 GMT, Kevin Walls wrote:
> Man page update to warn of deprecation of the jshdb debug subcommand and
> --connect option.
New text:
JHSDB(1) JDK Commands
JHSDB(1)
> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301) to
> Windows.
>
> System.map and System.dump_map are implemented using the Windows API and
> provide roughly the same information in the same format. Most of the heavy
> lifting was implemented by @tstuefe in #16301 -
On Tue, 10 Sep 2024 15:03:41 GMT, Sonia Zaldana Calles
wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix overly restrictive test
>
> src/hotspot/os/windows/memMapPrinter_windows.cpp line 98:
>
>> 96: out.p
On Wed, 11 Sep 2024 08:24:16 GMT, Emanuel Peter wrote:
> @rkennke Can you please explain the changes in these tests:
>
> ```
> test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationMismatchedAccess.java
> test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationNotRun.java
> test/hotspot/jtreg/
On Tue, 10 Sep 2024 15:42:57 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This PR addresses [8204681](https://bugs.openjdk.org/browse/JDK-8204681)
>> enabling support for timestamp expansion in filenames specified in
>> `-XX:HeapDumpPath` using `%t`.
>>
>> As mentioned in this comment
On Tue, 10 Sep 2024 15:09:03 GMT, Sonia Zaldana Calles
wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix overly restrictive test
>
> I am not a Reviewer but this looks mostly good to me.
@SoniaZaldana thank you
On Tue, 10 Sep 2024 19:11:30 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Tue, 10 Sep 2024 20:53:46 GMT, Gerard Ziemski wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also in
On Wed, 11 Sep 2024 13:32:49 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Wed, 11 Sep 2024 13:32:49 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Wed, 11 Sep 2024 13:34:28 GMT, Roman Kennke wrote:
> > @rkennke Can you please explain the changes in these tests:
> > ```
> > test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationMismatchedAccess.java
> > test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationNotRun.java
> > test/hotspot/
On Tue, 10 Sep 2024 19:11:30 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Wed, 11 Sep 2024 14:13:37 GMT, Sonia Zaldana Calles
wrote:
> Hi Simon,
>
> Thanks! Looks good.
>
> Just had a question about the empty filename issue. I don’t think there is a
> case where a filename parameter should accept an empty string (but I might be
> wrong).
>
> If that’s the case
> This PR changes the status of realpath() from a Posix-specific API to a
> globally available API, i.e. adding it to the "Hotspot Porting API". Code
> would refer to os::realpath() instead of os::Posix::realpath().
>
> This requires the addition of a stub routine in os_posix.cpp and a Windows
On Wed, 11 Sep 2024 14:31:43 GMT, Simon Tooke wrote:
>> This PR changes the status of realpath() from a Posix-specific API to a
>> globally available API, i.e. adding it to the "Hotspot Porting API". Code
>> would refer to os::realpath() instead of os::Posix::realpath().
>>
>> This requires t
On Thu, 5 Sep 2024 21:03:56 GMT, David Holmes wrote:
>> Simon Tooke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - simplify windwos realpath() implementation
>> - get rid of os::posix::realpath() and os::win32::realpath()
>
> src/hot
> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301) to
> Windows.
>
> System.map and System.dump_map are implemented using the Windows API and
> provide roughly the same information in the same format. Most of the heavy
> lifting was implemented by @tstuefe in #16301 -
On Wed, 11 Sep 2024 14:12:48 GMT, Thomas Stuefe wrote:
>> Simon Tooke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - prevent VM crash on invalid jcmd
>> - changes from review
>
> src/hotspot/share/services/diagnosticCommand.cpp line
On Tue, 10 Sep 2024 19:11:30 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Wed, 11 Sep 2024 14:48:53 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Wed, 11 Sep 2024 14:48:53 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Tue, 10 Sep 2024 13:47:47 GMT, Kevin Walls wrote:
>> Remove very very old serialization compatibility logic from JMX.
>>
>> This relates to keeping the JDK's JMX implementation compatible with JMX
>> versions from when JMX was a separate component, before being integrated
>> into JDK 5. It
On Wed, 11 Sep 2024 14:48:53 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Wed, 11 Sep 2024 01:03:55 GMT, David Holmes wrote:
> EDIT: Oh dear. I see I have been under a misapprehension about these template
> parameters, I tend to always thing such things are type parameters but they
> are not. MT would make sense for a type parameter, but mt would be more
> sensib
On Wed, 21 Aug 2024 09:54:08 GMT, Thomas Stuefe wrote:
>> Hi all,
>>
>> This PR addresses [8204681](https://bugs.openjdk.org/browse/JDK-8204681)
>> enabling support for timestamp expansion in filenames specified in
>> `-XX:HeapDumpPath` using `%t`.
>>
>> As mentioned in this comments for th
On Tue, 10 Sep 2024 20:53:46 GMT, Gerard Ziemski wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also in
On Wed, 11 Sep 2024 12:47:30 GMT, Johan Sjölen wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix FullGCForwarding initialization
>
> src/hotspot/share/memory/classLoaderMetaspace.cpp line 115:
>
>> 113: if (wa
On Wed, 11 Sep 2024 14:15:12 GMT, Roberto Castañeda Lozano
wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix FullGCForwarding initialization
>
> src/hotspot/share/memory/metaspace/binList.hpp line 202:
>
>> 200
On Wed, 11 Sep 2024 16:14:39 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/memory/metaspace/binList.hpp line 202:
>>
>>> 200: b_last = b;
>>> 201: }
>>> 202: if (UseNewCode)printf("\n");
>>
>> I guess this line is a leftover to be removed?
>
> Yep thanks for spotting
So th
On Wed, 11 Sep 2024 14:59:52 GMT, Kevin Walls wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> changes per review
>
> src/hotspot/os/windows/memMapPrinter_windows.cpp line 98:
>
>> 96: out.put('r');
>> 97:
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Wed, 11 Sep 2024 17:23:11 GMT, Simon Tooke wrote:
>> src/hotspot/os/windows/memMapPrinter_windows.cpp line 98:
>>
>>> 96: out.put('r');
>>> 97: } else {
>>> 98: fatal("Unknown Windows memory state value: 0x%x", mem_info.State);
>>
>> Are these really fatal? We don't want to
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Wed, 11 Sep 2024 17:26:15 GMT, Thomas Stuefe wrote:
>> I was thinking about this - my original intent was to be fatal only on a
>> debug build, not release. I have added a message in the output, and changed
>> these to warnings (for both release and debug)
>
> I would prefer an assert here.
> Please review this fix for cgroups-based metrics reporting in the
> `jdk.internal.platform` package. This fix is supposed to address wrong
> reporting of certain limits if the limits aren't set at the leaf nodes.
>
> For example, on cg v2, the memory limit interface file is `memory.max`.
> Co
On Wed, 11 Sep 2024 14:49:50 GMT, Simon Tooke wrote:
>
> I agree, and will probably do this next week. If it looks good to you, could
> you please mark as reviewed? You're on the list of reviewers.
FYI, I filed [JDK-8339970](https://bugs.openjdk.org/browse/JDK-8339970) to
track this.
---
> This PR changes the status of realpath() from a Posix-specific API to a
> globally available API, i.e. adding it to the "Hotspot Porting API". Code
> would refer to os::realpath() instead of os::Posix::realpath().
>
> This requires the addition of a stub routine in os_posix.cpp and a Windows
On Tue, 10 Sep 2024 00:27:23 GMT, Chris Plummer wrote:
> This test fails periodically. It only prints the exception message when it
> fails. It should print the entire stack trace so we have a better idea of why
> it is failing.
>
> Testing: This test is not run until tier5 CI testing, so I'm
On Tue, 10 Sep 2024 00:27:23 GMT, Chris Plummer wrote:
> This test fails periodically. It only prints the exception message when it
> fails. It should print the entire stack trace so we have a better idea of why
> it is failing.
>
> Testing: This test is not run until tier5 CI testing, so I'm
> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>
> **Overview**
>
> - A new `-XX:+AOTClassLinking` flag is added. See [JEP
> 498](https://bugs.openjdk.org/browse/JDK-8315737) and the
> [CSR](https://bugs.openjdk.org/bro
On Tue, 10 Sep 2024 10:08:35 GMT, Andrew Dinn wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @dholmes-ora comments: logging indents
>
> src/hotspot/share/cds/aotClassLinker.hpp line 71:
>
>> 69: //
>> 70: class AOTCla
> This patch cleans up the use of `get_new_method()` so callers don't have to
> worry about throwing `NoSuchMethodError`. The method is refactored to throw
> the error and avoid ever returning nullptr. Verified with tier1-5 tests.
Matias Saavedra Silva has updated the pull request incrementally
On Wed, 11 Sep 2024 17:38:57 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Tue, 10 Sep 2024 00:27:23 GMT, Chris Plummer wrote:
> This test fails periodically. It only prints the exception message when it
> fails. It should print the entire stack trace so we have a better idea of why
> it is failing.
>
> Testing: This test is not run until tier5 CI testing, so I'm
On Wed, 11 Sep 2024 14:48:53 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Tue, 10 Sep 2024 20:53:46 GMT, Gerard Ziemski wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also in
On Wed, 11 Sep 2024 11:53:19 GMT, Kevin Walls wrote:
> Man page update to warn of deprecation of the jshdb debug subcommand and
> --connect option.
Looks okay.
-
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20946#pullrequestreview-2298999
On Wed, 11 Sep 2024 21:02:41 GMT, Matias Saavedra Silva
wrote:
>> This patch cleans up the use of `get_new_method()` so callers don't have to
>> worry about throwing `NoSuchMethodError`. The method is refactored to throw
>> the error and avoid ever returning nullptr. Verified with tier1-5 test
On Wed, 11 Sep 2024 11:53:19 GMT, Kevin Walls wrote:
> Man page update to warn of deprecation of the jshdb debug subcommand and
> --connect option.
Why is `debugd` deprecated? I think it is useful for Kubernetes deployment.
For example, if the app in container hangs, we can attach ephemeral co
On Wed, 11 Sep 2024 11:53:19 GMT, Kevin Walls wrote:
> Man page update to warn of deprecation of the jshdb debug subcommand and
> --connect option.
I talked about use case of `jhsdb debugd` on Kubernetes (in Japanese...)
https://www.youtube.com/watch?v=5evMwwPUl14&t=346s
-
PR Comm
On Wed, 11 Sep 2024 19:17:19 GMT, Simon Tooke wrote:
>> This PR changes the status of realpath() from a Posix-specific API to a
>> globally available API, i.e. adding it to the "Hotspot Porting API". Code
>> would refer to os::realpath() instead of os::Posix::realpath().
>>
>> This requires t
On Fri, 28 Jun 2024 22:30:52 GMT, Chris Plummer wrote:
> Once the main thread has detected that the spawned thread is in the BLOCKED
> state, the spawned thread's LingeredAppWithLock.lockMethod() should be
> visible on the top of the stack, but it is not, so the "waiting to lock"
> message is
On Fri, 6 Sep 2024 13:12:29 GMT, Coleen Phillimore wrote:
>> This patch cleans up the use of `get_new_method()` so callers don't have to
>> worry about throwing `NoSuchMethodError`. The method is refactored to throw
>> the error and avoid ever returning nullptr. Verified with tier1-5 tests.
>
>
On Fri, 6 Sep 2024 12:51:38 GMT, Coleen Phillimore wrote:
> We do the same thing with illegal_access_error() where the arguments may not
> match and there's a special case for this and no_such_method_error() in
> dependencies. Are the compilers confused by this too?
If the compiler used the va
On Tue, 10 Sep 2024 06:50:13 GMT, David Holmes wrote:
>> So that implies that you trust my reading of this code. It is complicated
>> enough that testing both seems like a safe thing to do and somewhat
>> clarifying, or else adding an assert like:
>>
>> assert(new_method != nullptr || old
On Wed, 11 Sep 2024 21:02:41 GMT, Matias Saavedra Silva
wrote:
>> This patch cleans up the use of `get_new_method()` so callers don't have to
>> worry about throwing `NoSuchMethodError`. The method is refactored to throw
>> the error and avoid ever returning nullptr. Verified with tier1-5 test
On Wed, 11 Sep 2024 11:53:19 GMT, Kevin Walls wrote:
> Man page update to warn of deprecation of the jshdb debug subcommand and
> --connect option.
Marked as reviewed by cjplummer (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/20946#pullrequestreview-2299166203
On Wed, 11 Sep 2024 21:02:41 GMT, Matias Saavedra Silva
wrote:
>> This patch cleans up the use of `get_new_method()` so callers don't have to
>> worry about throwing `NoSuchMethodError`. The method is refactored to throw
>> the error and avoid ever returning nullptr. Verified with tier1-5 test
On Thu, 12 Sep 2024 03:44:32 GMT, Dean Long wrote:
>> The assert works for me.
>
> Can we assert the stronger statement: `(new_method == nullptr) ==
> (old_method->is_deleted())` ?
Yeah I like that better too.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/20874#discussion_
64 matches
Mail list logo
