On Wed, 11 Sep 2024 14:31:43 GMT, Simon Tooke <[email protected]> wrote:
>> This PR changes the status of realpath() from a Posix-specific API to a
>> globally available API, i.e. adding it to the "Hotspot Porting API". Code
>> would refer to os::realpath() instead of os::Posix::realpath().
>>
>> This requires the addition of a stub routine in os_posix.cpp and a Windows
>> implementation of realpath(), using Windows _fullpath().
>>
>> This PR depends on #20597 in that it removes the need for one #ifdef in that
>> PR. Because of that, this PR will be modified when and if #20597 is
>> integrated.
>>
>> Please note that guidelines for doing this appear in
>> src/hotspot/share/runtime/os.hpp
>
> Simon Tooke has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - move os::realpath() to previous location
> - move os::realpath() to previous location
src/hotspot/os/posix/os_posix.cpp line 1031:
> 1029:
> 1030: // Sleep forever; naked call to OS-specific sleep; use with CAUTION
> 1031: void os::infinite_sleep() {
Ouch, looks like something broke in one of the commits, the new diff it's
showing isn't pretty (infinite_sleep and friends have been displaced in the
file, at least on my end)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20683#discussion_r1754761196
