On Wed, 11 Sep 2024 17:23:11 GMT, Simon Tooke <[email protected]> wrote:
>> src/hotspot/os/windows/memMapPrinter_windows.cpp line 98:
>>
>>> 96: out.put('r');
>>> 97: } else {
>>> 98: fatal("Unknown Windows memory state value: 0x%x", mem_info.State);
>>
>> Are these really fatal? We don't want to risk ending the target process
>> with a jcmd. Maybe a warning, as part of the command output (not the JVM's
>> stdout/err) if we want to say something?
>
> I was thinking about this - my original intent was to be fatal only on a
> debug build, not release. I have added a message in the output, and changed
> these to warnings (for both release and debug)
I would prefer an assert here. It will crash in debug builds, which is fine,
since if it crashes it is either a bug or an hitherto unknown state. In any
case something that should be fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20597#discussion_r1755209895
