On Wed, 11 Sep 2024 21:02:41 GMT, Matias Saavedra Silva <matsa...@openjdk.org> 
wrote:

>> This patch cleans up the use of `get_new_method()` so callers don't have to 
>> worry about throwing `NoSuchMethodError`. The method is refactored to throw 
>> the error and avoid ever returning nullptr. Verified with tier1-5 tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Coleen suggestion

I think using a callee with the wrong signature could cause problems in other 
places, not just the compiler.  Doesn't GC oopmap scanning depend on the 
signature of the callee method?  And it might seem harmless if those "extra" 
arguments are not scanned, I believe there is a JVMTI API that can query those 
values.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20874#issuecomment-2345216935

Reply via email to