On Fri, 5 May 2023 07:49:10 GMT, Andrew Dinn wrote:
>> Looks good.
>> Thank you for taking care about it!
>> Thanks,
>> Serguei
>
> @sspitsyn Thanks for the review.
@adinn Please wait for two reviews for hotspot changes unless designated as
trivial. Thanks.
-
PR Comment: https://g
On Mon, 8 May 2023 01:13:36 GMT, David Holmes wrote:
> updates seem fine.
Thanks!
@dcubed-ojdk are you good with testing? If you could approve this PR again, I
would integrate it later today?
-
PR Comment: https://git.openjdk.org/jdk/pull/10907#issuecomment-1537901860
On Thu, 4 May 2023 09:33:49 GMT, Stefan Karlsson wrote:
> When running jstat tests like the following:
> test/jdk/sun/tools/jstatd/TestJstatdServer.java
>
> with Generational ZGC we get a failure because the O (old generation
> percentage) is reported as `-` and not a number. The reason why it
On Thu, 4 May 2023 09:33:49 GMT, Stefan Karlsson wrote:
> When running jstat tests like the following:
> test/jdk/sun/tools/jstatd/TestJstatdServer.java
>
> with Generational ZGC we get a failure because the O (old generation
> percentage) is reported as `-` and not a number. The reason why it
> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory
> share/jfr/. Unfortunately the script that does the change isn't perfect, and
> so we
> need to comb through these manually to make sure nothing has gone wrong. I
> also review these changes but things slip past my ey
On Thu, 4 May 2023 07:30:49 GMT, Arno Zeller wrote:
> Unless this test is run as root, it needs sudo privileges. If it gets them,
> the test runs fine, but leaves a file with root ownership. So jtreg cannot
> delete it, and you see errors when "make clean" tries to delete it.
> It's best that
On Sat, 6 May 2023 08:14:24 GMT, Quan Anh Mai wrote:
>> src/hotspot/cpu/x86/gc/z/zBarrierSetAssembler_x86.cpp line 310:
>>
>>> 308: // A not relocatable object could have spurious raw null pointers
>>> in its fields after
>>> 309: // getting promoted to the old generation.
>>> 310:
On Sat, 6 May 2023 05:22:48 GMT, Quan Anh Mai wrote:
>> Stefan Karlsson has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 917 commits:
>>
>> - ZGC: Generational
>>
>>Co-authored-by: Stefan Karlsson
>>Co-authored-by: Pe
> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory
> share/jfr/. Unfortunately the script that does the change isn't perfect, and
> so we
> need to comb through these manually to make sure nothing has gone wrong. I
> also review these changes but things slip past my ey
> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory
> share/jfr/. Unfortunately the script that does the change isn't perfect, and
> so we
> need to comb through these manually to make sure nothing has gone wrong. I
> also review these changes but things slip past my ey
> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory
> share/jfr/. Unfortunately the script that does the change isn't perfect, and
> so we
> need to comb through these manually to make sure nothing has gone wrong. I
> also review these changes but things slip past my ey
On Mon, 8 May 2023 10:00:45 GMT, Johan Sjölen wrote:
>> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory
>> share/jfr/. Unfortunately the script that does the change isn't perfect, and
>> so we
>> need to comb through these manually to make sure nothing has gone wrong
On Fri, 5 May 2023 06:50:55 GMT, Stefan Karlsson wrote:
>> We emailed to erik to discuss this issue two months ago, and maybe he missed
>> it.
>> ZForwardingTest does not guarantee a successful invoke of os::commit_memory
>> for ZAddressHeapBase, and we saw some conflicts between ZAddressHeapBa
On Mon, 8 May 2023 09:01:07 GMT, Erik Österlund wrote:
>> I think we use the flag `UseStoreImmI16` for these kinds of situations.
>
> We did indeed run into the predecoder issue when we used testw for normal
> store barriers, so I changed to testl. However, this cmpw is only taken when
> we use
On Mon, 8 May 2023 10:09:29 GMT, Johan Sjölen wrote:
>> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory
>> share/jfr/. Unfortunately the script that does the change isn't perfect, and
>> so we
>> need to comb through these manually to make sure nothing has gone wrong
> The `finalize()` method is removed from base classes/interfaces and are
> replaced by a Cleaner callback..
Afshin Zafari has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains seven commits:
- Merge master
- Merge branch 'master' into _
On Mon, 8 May 2023 10:09:29 GMT, Johan Sjölen wrote:
>> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory
>> share/jfr/. Unfortunately the script that does the change isn't perfect, and
>> so we
>> need to comb through these manually to make sure nothing has gone wrong
On Mon, 8 May 2023 11:01:56 GMT, Johan Sjölen wrote:
>> Johan Sjölen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Dead assert
>
> Passes tier1.
Thanks @jdksjolen , I am rubberstamping this.
-
PR Comment: https://git.ope
On Mon, 8 May 2023 10:19:44 GMT, Fei Yang wrote:
>> Could you provide the values for `reserved`, `ZAddressHeapBase`, and
>> `ZAddressOffsetMax`, when this test is failing. I'd like to know if we can
>> make a workaround for you, or if we have to turn off the test for riscv.
>
> @stefank : I ran
Thanks for the response, Ron.
My comments are in line.
On Fri, May 5, 2023 at 8:10 AM Ron Pressler wrote:
>
>
> On 4 May 2023, at 21:32, Dan Heidinga wrote:
>
>
> I’ve read this draft a number of times and each time I struggled with the
> framing of the problem given Java’s success over the pa
On Mon, 8 May 2023 04:20:21 GMT, Ioi Lam wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove return variable from remove lambda, fix formatting.
>
> src/hotspot/share/classfile/stringTable.cpp line 638:
>
On Mon, 8 May 2023 05:25:04 GMT, David Holmes wrote:
>> src/hotspot/share/utilities/resourceHash.hpp line 147:
>>
>>> 145: */
>>> 146: bool put_fast(K const& key, V const& value) {
>>> 147: unsigned hv = HASH(key);
>>
>> I think `put_fast` is not clear enough. Maybe `put_must_be_absent(
On Mon, 8 May 2023 02:10:48 GMT, David Holmes wrote:
>> Paul Hohensee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8304074: [JMX] Add an approximation of total bytes allocated on the Java
>> heap by the JVM
>
> src/hotspot/share/serv
> The ResourceHashtable conversion for JDK-8292741 didn't add the resizing
> code. The old hashtable code was tuned for resizing in anticipation of large
> hashtables for JVMTI tags. This patch ports over the old hashtable resizing
> code. It also adds a ResourceHashtable::put_fast() function
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generational ZGC version that exists in the
> openjdk/jdk repository. It splits the heap i
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generational ZGC version that exists in the
> openjdk/jdk repository. It splits the heap i
On Fri, 5 May 2023 16:49:38 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Fri, 5 May 2023 16:49:38 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Fri, 5 May 2023 16:49:38 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Fri, 5 May 2023 16:49:38 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Tue, 2 May 2023 22:46:44 GMT, Dean Long wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add missing new file
>
> My review applies to the aarch64 changes.
> I have looked at the aarch64 changes twice and the lat
On Mon, 8 May 2023 02:13:14 GMT, David Holmes wrote:
>> Paul Hohensee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8304074: [JMX] Add an approximation of total bytes allocated on the Java
>> heap by the JVM
>
> src/hotspot/share/serv
On Tue, 2 May 2023 22:46:44 GMT, Dean Long wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add missing new file
>
> My review applies to the aarch64 changes.
> I have looked at the aarch64 changes twice and the lat
On Fri, 5 May 2023 16:49:38 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Fri, 5 May 2023 16:49:38 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Mon, 8 May 2023 17:04:29 GMT, Aleksey Shipilev wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Only allow lock-stack verification for owning Java threads or at safepoints
>
> src/hotspot/cpu/arm/c1_MacroAssemble
On Fri, 5 May 2023 16:49:38 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Fri, 28 Oct 2022 20:17:37 GMT, Roman Kennke wrote:
> This change adds a fast-locking scheme as an alternative to the current
> stack-locking implementation. It retains the advantages of stack-locking
> (namely fast locking in uncontended code-paths), while avoiding the overload
> of the mar
On Sat, 6 May 2023 09:45:07 GMT, Serguei Spitsyn wrote:
>> The SA document `transported_core.html` contains some tips on getting core
>> files to work when debugging it on a machine other than the one that
>> produced it. There are a few improvements that can be made based on
>> information pr
https://openjdk.org/jeps/451
Summary: Issue warnings when agents are loaded dynamically into a
running JVM. These warnings aim to prepare users for a future release
which disallows the dynamic loading of agents by default in order to
improve integrity by default. Serviceability tools that
> The fix updates JVMTI FollowReferences implementation to report references
> from virtual threads:
> - unmounted vthreads are detected, their stack references for
> JVMTI_HEAP_REFERENCE_STACK_LOCAL/JVMTI_HEAP_REFERENCE_JNI_LOCAL;
> - stacks of mounted vthreads are splitted into 2 parts (virtual
> Please review this addition to com.sun.management.ThreadMXBean that returns
> the total number of bytes allocated on the Java heap since JVM launch by both
> terminated and live threads.
>
> Because this PR adds a new interface method, I've updated the JMM_VERSION to
> 4, but would be happy t
> Please review this addition to com.sun.management.ThreadMXBean that returns
> the total number of bytes allocated on the Java heap since JVM launch by both
> terminated and live threads.
>
> Because this PR adds a new interface method, I've updated the JMM_VERSION to
> 4, but would be happy t
> Please review this addition to com.sun.management.ThreadMXBean that returns
> the total number of bytes allocated on the Java heap since JVM launch by both
> terminated and live threads.
>
> Because this PR adds a new interface method, I've updated the JMM_VERSION to
> 4, but would be happy t
> Please review this addition to com.sun.management.ThreadMXBean that returns
> the total number of bytes allocated on the Java heap since JVM launch by both
> terminated and live threads.
>
> Because this PR adds a new interface method, I've updated the JMM_VERSION to
> 4, but would be happy t
> The fix updates JVMTI FollowReferences implementation to report references
> from virtual threads:
> - unmounted vthreads are detected, their stack references for
> JVMTI_HEAP_REFERENCE_STACK_LOCAL/JVMTI_HEAP_REFERENCE_JNI_LOCAL;
> - stacks of mounted vthreads are splitted into 2 parts (virtual
On Mon, 8 May 2023 13:59:06 GMT, Coleen Phillimore wrote:
>> I would suggest `put_when_absent` to complement `put_if_absent` - with
>> suitable descriptive comments of course.
>
> This is a good name. Updated.
I cannot tell the difference between `put_when_absent` and `put_if_absent`.
Grammat
> Please review this addition to com.sun.management.ThreadMXBean that returns
> the total number of bytes allocated on the Java heap since JVM launch by both
> terminated and live threads.
>
> Because this PR adds a new interface method, I've updated the JMM_VERSION to
> 4, but would be happy t
On Sat, 6 May 2023 09:35:28 GMT, Serguei Spitsyn wrote:
>> I mean the pieces of the code that set and use
>> _is_top_frame/_last_entry_frame are close so it's easier to see the logic
>
> I'd say that it will be even better to find out what are manipulations with
> these instance fields. They ar
On Sat, 6 May 2023 09:11:51 GMT, Serguei Spitsyn wrote:
>> Alex Menkov has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - cosmetic changes in libVThreadStackRefTest.cpp
>> - collect VT stack references if initial_object is null
>> - m
> Please review this addition to com.sun.management.ThreadMXBean that returns
> the total number of bytes allocated on the Java heap since JVM launch by both
> terminated and live threads.
>
> Because this PR adds a new interface method, I've updated the JMM_VERSION to
> 4, but would be happy t
On Fri, 5 May 2023 22:21:36 GMT, Chris Plummer wrote:
> This test was very rarely failing with a exitValue 143 from the debuggee. It
> only happened when the machine was under a lot of stress. After some
> investigation it was realized that on unix OSes it should *always* expect
> exitValue 14
On Mon, 8 May 2023 22:19:53 GMT, Ioi Lam wrote:
>> This is a good name. Updated.
>
> I cannot tell the difference between `put_when_absent` and `put_if_absent`.
> Grammatically they mean the same thing to me.
My preference is to eventually make 'put' be 'put-ifwhen-absent', so I don't
care wh
On Fri, 5 May 2023 23:53:47 GMT, Chris Plummer wrote:
> The SA document `transported_core.html` contains some tips on getting core
> files to work when debugging it on a machine other than the one that produced
> it. There are a few improvements that can be made based on information
> provided
> The SA document `transported_core.html` contains some tips on getting core
> files to work when debugging it on a machine other than the one that produced
> it. There are a few improvements that can be made based on information
> provided in [JDK-8306437](https://bugs.openjdk.org/browse/JDK-83
On Thu, 4 May 2023 10:39:32 GMT, Serguei Spitsyn wrote:
>> This enhancement adds support of virtual threads to the JVMTI `StopThread`
>> function.
>> In preview releases before this enhancement the StopThread returned the
>> JVMTI_ERROR_UNSUPPORTED_OPERATION error code for virtual threads.
>>
On Mon, 8 May 2023 13:56:24 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/classfile/stringTable.cpp line 638:
>>
>>> 636: public:
>>> 637: size_t _errors;
>>> 638: VerifyCompStrings() : _table(unsigned(_items_count / 8) + 1, 0 /* do
>>> not resize */), _errors(0) {}
>>
>> Shouldn't t
On Mon, 8 May 2023 12:47:51 GMT, Stefan Karlsson wrote:
> That's unfortunate. Could you try this patch, which probes the address range
> to see if it can reserve the memory somewhere else within `[ZAddressHeapBase,
> ZAddressHeapBase+ZAddressOffsetMax)`:
> https://github.com/stefank/jdk/tree/z
On Thu, 4 May 2023 10:39:32 GMT, Serguei Spitsyn wrote:
>> This enhancement adds support of virtual threads to the JVMTI `StopThread`
>> function.
>> In preview releases before this enhancement the StopThread returned the
>> JVMTI_ERROR_UNSUPPORTED_OPERATION error code for virtual threads.
>>
On Mon, 8 May 2023 14:03:18 GMT, Volker Simonis wrote:
>> src/hotspot/share/services/management.cpp line 2107:
>>
>>> 2105: // when result is initialized.
>>> 2106: jlong result = ThreadService::exited_allocated_bytes();
>>> 2107: for (JavaThreadIteratorWithHandle jtiwh; JavaThread *
On Mon, 8 May 2023 16:41:13 GMT, Daniel D. Daugherty wrote:
>> src/hotspot/share/services/threadService.cpp line 173:
>>
>>> 171: // was not called, e.g.,
>>> JavaThread::cleanup_failed_attach_current_thread().
>>> 172: decrement_thread_counts(thread, daemon);
>>> 173:
>>> ThreadSe
On Tue, 9 May 2023 00:01:09 GMT, Chris Plummer wrote:
>> The SA document `transported_core.html` contains some tips on getting core
>> files to work when debugging it on a machine other than the one that
>> produced it. There are a few improvements that can be made based on
>> information prov
On Mon, 8 May 2023 23:13:05 GMT, Paul Hohensee wrote:
>> Please review this addition to com.sun.management.ThreadMXBean that returns
>> the total number of bytes allocated on the Java heap since JVM launch by
>> both terminated and live threads.
>>
>> Because this PR adds a new interface metho
On Mon, 8 May 2023 23:13:05 GMT, Paul Hohensee wrote:
>> Please review this addition to com.sun.management.ThreadMXBean that returns
>> the total number of bytes allocated on the Java heap since JVM launch by
>> both terminated and live threads.
>>
>> Because this PR adds a new interface metho
On Tue, 9 May 2023 01:23:23 GMT, Paul Hohensee wrote:
>> Please review this addition to com.sun.management.ThreadMXBean that returns
>> the total number of bytes allocated on the Java heap since JVM launch by
>> both terminated and live threads.
>>
>> Because this PR adds a new interface metho
> Please review this addition to com.sun.management.ThreadMXBean that returns
> the total number of bytes allocated on the Java heap since JVM launch by both
> terminated and live threads.
>
> Because this PR adds a new interface method, I've updated the JMM_VERSION to
> 4, but would be happy t
The compatible lifecycle `ThreadStart/ThreadEnd` events were added in JDK 19 to
support legacy virtual thread unaware JVMTI agents which do not enable the
can_support_virtual_threads capability. When this capability is enabled then
the `VirtualThreadStart/VirtualThreadEnd` instead of the
`Threa
On Tue, 9 May 2023 01:08:19 GMT, David Holmes wrote:
>> Paul Hohensee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Implement 32-bit linux Atomic::add()
>
> src/hotspot/share/runtime/atomic.hpp line 310:
>
>> 308:
>> 309: // Platfo
> The compatible lifecycle `ThreadStart/ThreadEnd` events were added in JDK 19
> to support legacy virtual thread unaware JVMTI agents which do not enable the
> can_support_virtual_threads capability. When this capability is enabled then
> the `VirtualThreadStart/VirtualThreadEnd` instead of the
On Mon, 8 May 2023 23:28:18 GMT, Coleen Phillimore wrote:
>> I cannot tell the difference between `put_when_absent` and `put_if_absent`.
>> Grammatically they mean the same thing to me.
>
> My preference is to eventually make 'put' be 'put-ifwhen-absent', so I don't
> care which name you two pi
> Summaries:
> 1. A few recommendations about updating the constant API is made at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html
> and I may update this patch shall the API changes be integrated before
> 2. One ASM library-specific test, `LambdaAsm` is removed. Oth
On Mon, 8 May 2023 14:15:18 GMT, Coleen Phillimore wrote:
>> The ResourceHashtable conversion for JDK-8292741 didn't add the resizing
>> code. The old hashtable code was tuned for resizing in anticipation of
>> large hashtables for JVMTI tags. This patch ports over the old hashtable
>> resiz
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generational ZGC version that exists in the
> openjdk/jdk repository. It splits the heap i
On Tue, 9 May 2023 00:50:56 GMT, Fei Yang wrote:
>> That's unfortunate. Could you try this patch, which probes the address range
>> to see if it can reserve the memory somewhere else within
>> `[ZAddressHeapBase, ZAddressHeapBase+ZAddressOffsetMax)`:
>> https://github.com/stefank/jdk/tree/zgc_g
On Tue, 9 May 2023 02:16:18 GMT, Serguei Spitsyn wrote:
>> The compatible lifecycle `ThreadStart/ThreadEnd` events were added in JDK 19
>> to support legacy virtual thread unaware JVMTI agents which do not enable
>> the can_support_virtual_threads capability. When this capability is enabled
>>
75 matches
Mail list logo
