On Mon, 8 May 2023 23:13:05 GMT, Paul Hohensee <p...@openjdk.org> wrote:

>> Please review this addition to com.sun.management.ThreadMXBean that returns 
>> the total number of bytes allocated on the Java heap since JVM launch by 
>> both terminated and live threads.
>> 
>> Because this PR adds a new interface method, I've updated the JMM_VERSION to 
>> 4, but would be happy to update it to 3_1 instead.
>
> Paul Hohensee has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Implement 32-bit linux Atomic::add()

Also note that the current placement of the `incr_exited_allocated_bytes` skips 
accounting for hidden threads because those ThreadService methods skip hidden 
threads. You need to do this update as one of the last actions of a 
terminating/detaching thread.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13814#issuecomment-1539261740

Reply via email to