On Tue, 2 May 2023 22:46:44 GMT, Dean Long <dl...@openjdk.org> wrote:

>> Roman Kennke has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Add missing new file
>
> My review applies to the aarch64 changes.
> I have looked at the aarch64 changes twice and the latest version still looks 
> good.
> All of my questions or comments have been addressed.

> > Checking platform specific code review coverage: @dean-long and 
> > @dcubed-ojdk did the review of the arm32 and aarch64 changes. @dholmes-ora 
> > and @dcubed-ojdk did the review of the X64/X86 changes.
> > Was there a specific reviewer for the RISC-V changes?
> 
> No, not really. @RealFYang contributed the code and would also be the only 
> guy that I know who would review it ;-)

The RiscV changes look okay to me.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/10907#issuecomment-1538708313

Reply via email to