On Tue, 9 May 2023 01:08:19 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Paul Hohensee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Implement 32-bit linux Atomic::add() > > src/hotspot/share/runtime/atomic.hpp line 310: > >> 308: >> 309: // Platform-specific implementation of add. Support for sizes of 4 >> 310: // and 8 bytes are required. The class must be default constructable, > > Comment change seems unnecessary. I found that I had to add 64-bit atomic add support on 32-bit platforms (working on it), so I changed the comment to match the similar cmpxchg one. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13814#discussion_r1188034535
