On Sat, 6 May 2023 09:11:51 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Alex Menkov has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - cosmetic changes in libVThreadStackRefTest.cpp
>> - collect VT stack references if initial_object is null
>> - moved transition disabler to correct functions
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/FollowReferences/libVThreadStackRefTest.cpp
> line 140:
>
>> 138: LOG("JVMTI FollowReferences error: %d\n", err);
>> 139: env->FatalError("FollowReferences failed");
>> 140: }
>
> Nit: `classesCount` and `heapCallBacks` need c-style names.
fixed
> test/hotspot/jtreg/serviceability/jvmti/vthread/FollowReferences/libVThreadStackRefTest.cpp
> line 153:
>
>> 151: }
>> 152:
>> 153: static void printCreatedClass(JNIEnv* env, jclass cls) {
>
> Nit: The function `printCreatedClass` should have a c-style name.
fixed
> test/hotspot/jtreg/serviceability/jvmti/vthread/FollowReferences/libVThreadStackRefTest.cpp
> line 181:
>
>> 179: }
>> 180:
>> 181: static std::atomic<bool> timeToExit(false);
>
> Nit: This variable should have c-style name.
fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13254#discussion_r1187961907
PR Review Comment: https://git.openjdk.org/jdk/pull/13254#discussion_r1187963355
PR Review Comment: https://git.openjdk.org/jdk/pull/13254#discussion_r1187963424
