Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v16]

2024-04-04 Thread Kevin Walls
> The deprecated Subject Delegation feature in JMX will be removed. > > This was marked in JDK 21 as deprecated for removal (JDK-8298966). Kevin Walls has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 25 commits: - Merge remote-tracki

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v15]

2024-03-26 Thread Kevin Walls
> The deprecated Subject Delegation feature in JMX will be removed. > > This was marked in JDK 21 as deprecated for removal (JDK-8298966). Kevin Walls has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits: - Merge - Missing co

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v14]

2024-03-15 Thread Daniel Fuchs
On Thu, 14 Mar 2024 21:44:52 GMT, Kevin Walls wrote: >> The deprecated Subject Delegation feature in JMX will be removed. >> >> This was marked in JDK 21 as deprecated for removal (JDK-8298966). > > Kevin Walls has updated the pull request incrementally with one additional > commit since the la

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v14]

2024-03-14 Thread Kevin Walls
> The deprecated Subject Delegation feature in JMX will be removed. > > This was marked in JDK 21 as deprecated for removal (JDK-8298966). Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: Missing code doc nit. - Changes:

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v13]

2024-03-14 Thread Kevin Walls
> The deprecated Subject Delegation feature in JMX will be removed. > > This was marked in JDK 21 as deprecated for removal (JDK-8298966). Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: Missing code doc nit. - Changes:

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v12]

2024-03-14 Thread Mandy Chung
On Thu, 14 Mar 2024 12:23:09 GMT, Kevin Walls wrote: >> The deprecated Subject Delegation feature in JMX will be removed. >> >> This was marked in JDK 21 as deprecated for removal (JDK-8298966). > > Kevin Walls has updated the pull request incrementally with one additional > commit since the la

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v5]

2024-03-14 Thread Kevin Walls
On Mon, 11 Mar 2024 15:19:08 GMT, Daniel Fuchs wrote: >>> Is there any value in keeping `SubjectDelegationPermission` after this >>> change? If so, I would mark that API deprecated for removal, so that it can >>> be removed in the next release or two. >> >> No, nothing uses SubjectDelegationPe

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v12]

2024-03-14 Thread Kevin Walls
> The deprecated Subject Delegation feature in JMX will be removed. > > This was marked in JDK 21 as deprecated for removal (JDK-8298966). Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: RMIConnectionImpl_Stub also should explicity in

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v11]

2024-03-14 Thread Daniel Fuchs
On Thu, 14 Mar 2024 11:53:11 GMT, Kevin Walls wrote: >> The deprecated Subject Delegation feature in JMX will be removed. >> >> This was marked in JDK 21 as deprecated for removal (JDK-8298966). > > Kevin Walls has updated the pull request incrementally with two additional > commits since the l

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v11]

2024-03-14 Thread Kevin Walls
> The deprecated Subject Delegation feature in JMX will be removed. > > This was marked in JDK 21 as deprecated for removal (JDK-8298966). Kevin Walls has updated the pull request incrementally with two additional commits since the last revision: - Clarify JMXConnector equivalence comment. -

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v10]

2024-03-13 Thread Kevin Walls
On Wed, 13 Mar 2024 17:39:24 GMT, Mandy Chung wrote: > The spec change looks good to me. I leave to others to review the > implementation and test changes. Thanks! - PR Comment: https://git.openjdk.org/jdk/pull/18025#issuecomment-1995445698

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v10]

2024-03-13 Thread Mandy Chung
On Tue, 12 Mar 2024 19:58:24 GMT, Kevin Walls wrote: >> The deprecated Subject Delegation feature in JMX will be removed. >> >> This was marked in JDK 21 as deprecated for removal (JDK-8298966). > > Kevin Walls has updated the pull request incrementally with one additional > commit since the la

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v10]

2024-03-12 Thread Kevin Walls
> The deprecated Subject Delegation feature in JMX will be removed. > > This was marked in JDK 21 as deprecated for removal (JDK-8298966). Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: typo - Changes: - all: https://

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v7]

2024-03-12 Thread Kevin Walls
On Tue, 12 Mar 2024 15:38:37 GMT, Kevin Walls wrote: >> It's a good suggestion. Something like this: >> >> All methods that take a `Subject` parameter will throw UOE if called with a >> non-null subject delegation. JMX subject delegation feature is no longer >> supported. > > OK sure -- did

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v9]

2024-03-12 Thread Kevin Walls
> The deprecated Subject Delegation feature in JMX will be removed. > > This was marked in JDK 21 as deprecated for removal (JDK-8298966). Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: Javadoc update - Changes: - all

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v7]

2024-03-12 Thread Kevin Walls
On Mon, 11 Mar 2024 19:24:20 GMT, Mandy Chung wrote: >> Maybe mention there too that the delegationSubject parameter is kept for >> interoperability with older remote clients. > > It's a good suggestion. Something like this: > > All methods that take a `Subject` parameter will throw UOE if ca

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v7]

2024-03-12 Thread Kevin Walls
On Mon, 11 Mar 2024 17:49:34 GMT, Mandy Chung wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> (C) oops > > src/java.management/share/classes/javax/management/remote/JMXConnector.java > line 139: > >> 137: /**

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v7]

2024-03-12 Thread Kevin Walls
On Mon, 11 Mar 2024 17:10:34 GMT, Daniel Fuchs wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> (C) oops > > src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnector.java > line 618: > >> 616:

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v8]

2024-03-12 Thread Kevin Walls
> The deprecated Subject Delegation feature in JMX will be removed. > > This was marked in JDK 21 as deprecated for removal (JDK-8298966). Kevin Walls has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v7]

2024-03-12 Thread Kevin Walls
On Mon, 11 Mar 2024 17:22:57 GMT, Daniel Fuchs wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> (C) oops > > test/jdk/javax/management/remote/mandatory/notif/DeadListenerTest.java line > 78: > >> 76: cs.sta

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v5]

2024-03-11 Thread Sean Mullan
On Mon, 11 Mar 2024 15:19:08 GMT, Daniel Fuchs wrote: > > Is there any value in keeping `SubjectDelegationPermission` after this > > change? If so, I would mark that API deprecated for removal, so that it can > > be removed in the next release or two. > > No issue with deprecation. I guess it

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v7]

2024-03-11 Thread Mandy Chung
On Mon, 11 Mar 2024 18:49:43 GMT, Daniel Fuchs wrote: >> I was wondering if we should add a note at the class-level API documentation >> to say that subject delegation has been removed (or is no longer supported), >> and that methods will throw UOE if a non-null delegation subject is passed. >

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v7]

2024-03-11 Thread Daniel Fuchs
On Mon, 11 Mar 2024 18:39:38 GMT, Daniel Fuchs wrote: >> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnection.java >> line 126: >> >>> 124: * @param className The class name of the MBean to be instantiated. >>> 125: * @param name The object name of the MBean

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v7]

2024-03-11 Thread Daniel Fuchs
On Mon, 11 Mar 2024 17:56:50 GMT, Mandy Chung wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> (C) oops > > src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnection.java > line 126: > >> 124:

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v7]

2024-03-11 Thread Mandy Chung
On Mon, 11 Mar 2024 10:09:28 GMT, Kevin Walls wrote: >> The deprecated Subject Delegation feature in JMX will be removed. >> >> This was marked in JDK 21 as deprecated for removal (JDK-8298966). > > Kevin Walls has updated the pull request incrementally with one additional > commit since the la

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v7]

2024-03-11 Thread Daniel Fuchs
On Mon, 11 Mar 2024 10:09:28 GMT, Kevin Walls wrote: >> The deprecated Subject Delegation feature in JMX will be removed. >> >> This was marked in JDK 21 as deprecated for removal (JDK-8298966). > > Kevin Walls has updated the pull request incrementally with one additional > commit since the la

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v5]

2024-03-11 Thread Daniel Fuchs
On Fri, 8 Mar 2024 10:20:36 GMT, Kevin Walls wrote: > Is there any value in keeping `SubjectDelegationPermission` after this > change? If so, I would mark that API deprecated for removal, so that it can > be removed in the next release or two. No issue with deprecation. I guess it can be remov

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v7]

2024-03-11 Thread Kevin Walls
> The deprecated Subject Delegation feature in JMX will be removed. > > This was marked in JDK 21 as deprecated for removal (JDK-8298966). Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: (C) oops - Changes: - all: http

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v6]

2024-03-11 Thread Kevin Walls
On Fri, 8 Mar 2024 22:04:28 GMT, Weijun Wang wrote: > Missing `,` after 2024. oops, thanks! - PR Review Comment: https://git.openjdk.org/jdk/pull/18025#discussion_r1519459149

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v6]

2024-03-08 Thread Weijun Wang
On Thu, 7 Mar 2024 22:00:13 GMT, Kevin Walls wrote: >> The deprecated Subject Delegation feature in JMX will be removed. >> >> This was marked in JDK 21 as deprecated for removal (JDK-8298966). > > Kevin Walls has updated the pull request incrementally with three additional > commits since the

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v5]

2024-03-08 Thread Kevin Walls
On Thu, 7 Mar 2024 19:58:35 GMT, Sean Mullan wrote: > Is there any value in keeping `SubjectDelegationPermission` after this > change? If so, I would mark that API deprecated for removal, so that it can > be removed in the next release or two. No, nothing uses SubjectDelegationPermission. Tha

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v6]

2024-03-07 Thread Kevin Walls
> The deprecated Subject Delegation feature in JMX will be removed. > > This was marked in JDK 21 as deprecated for removal (JDK-8298966). Kevin Walls has updated the pull request incrementally with three additional commits since the last revision: - Clarify deprecation comment. - typo - Rem

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v5]

2024-03-07 Thread Kevin Walls
On Thu, 7 Mar 2024 20:07:57 GMT, Sean Mullan wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Test specifically that UOE is thrown. > > src/java.management/share/classes/javax/management/remote/JMXConnector.java > l

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v5]

2024-03-07 Thread Sean Mullan
On Wed, 6 Mar 2024 11:46:16 GMT, Kevin Walls wrote: >> The deprecated Subject Delegation feature in JMX will be removed. >> >> This was marked in JDK 21 as deprecated for removal (JDK-8298966). > > Kevin Walls has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v5]

2024-03-07 Thread Sean Mullan
On Wed, 6 Mar 2024 11:46:16 GMT, Kevin Walls wrote: >> The deprecated Subject Delegation feature in JMX will be removed. >> >> This was marked in JDK 21 as deprecated for removal (JDK-8298966). > > Kevin Walls has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v5]

2024-03-07 Thread Sean Mullan
On Wed, 6 Mar 2024 11:46:16 GMT, Kevin Walls wrote: >> The deprecated Subject Delegation feature in JMX will be removed. >> >> This was marked in JDK 21 as deprecated for removal (JDK-8298966). > > Kevin Walls has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v5]

2024-03-06 Thread Kevin Walls
> The deprecated Subject Delegation feature in JMX will be removed. > > This was marked in JDK 21 as deprecated for removal (JDK-8298966). Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: Test specifically that UOE is thrown.

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v4]

2024-03-06 Thread Kevin Walls
On Wed, 6 Mar 2024 11:42:18 GMT, Kevin Walls wrote: >> The deprecated Subject Delegation feature in JMX will be removed. >> >> This was marked in JDK 21 as deprecated for removal (JDK-8298966). > > Kevin Walls has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v4]

2024-03-06 Thread Kevin Walls
> The deprecated Subject Delegation feature in JMX will be removed. > > This was marked in JDK 21 as deprecated for removal (JDK-8298966). Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: Test that SubjectDelegation is refused. --

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v2]

2024-03-04 Thread Kevin Walls
On Mon, 4 Mar 2024 13:37:53 GMT, Alan Bateman wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> RMIConnection comments update > > src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnection.java >

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v3]

2024-03-04 Thread Kevin Walls
> The deprecated Subject Delegation feature in JMX will be removed. > > This was marked in JDK 21 as deprecated for removal (JDK-8298966). Kevin Walls has updated the pull request incrementally with two additional commits since the last revision: - Update doc comments for RMIConnection. Addit

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v2]

2024-03-04 Thread Daniel Fuchs
On Mon, 4 Mar 2024 13:24:05 GMT, Kevin Walls wrote: >> The deprecated Subject Delegation feature in JMX will be removed. >> >> This was marked in JDK 21 as deprecated for removal (JDK-8298966). > > Kevin Walls has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v2]

2024-03-04 Thread Alan Bateman
On Mon, 4 Mar 2024 13:24:05 GMT, Kevin Walls wrote: >> The deprecated Subject Delegation feature in JMX will be removed. >> >> This was marked in JDK 21 as deprecated for removal (JDK-8298966). > > Kevin Walls has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v2]

2024-03-04 Thread Kevin Walls
> The deprecated Subject Delegation feature in JMX will be removed. > > This was marked in JDK 21 as deprecated for removal (JDK-8298966). Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: RMIConnection comments update - C

Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature

2024-03-01 Thread Kevin Walls
On Tue, 27 Feb 2024 10:44:20 GMT, Kevin Walls wrote: > The deprecated Subject Delegation feature in JMX will be removed. > > This was marked in JDK 21 as deprecated for removal (JDK-8298966). This covers the public interface to the feature, and tests. Locally the feature is refused during a ca

RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature

2024-03-01 Thread Kevin Walls
The deprecated Subject Delegation feature in JMX will be removed. This was marked in JDK 21 as deprecated for removal (JDK-8298966). - Commit messages: - JMXConnector to throw UnsupportedOperationException - RMIConnectionImpl to throw when RMI calls invoke with delegatedSubject.