On Thu, 7 Mar 2024 20:07:57 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Test specifically that UOE is thrown. > > src/java.management/share/classes/javax/management/remote/JMXConnector.java > line 153: > >> 151: * >> 152: * @exception UnsupportedOperationException if a non-null >> delegationSubject >> 153: * is specifed. Subject Delegation has been removed. > > Typo: s/specifed/specified/ got it thanks. > src/java.management/share/classes/javax/management/remote/JMXConnector.java > line 158: > >> 156: * and is only useful in conjunction with other APIs which are >> deprecated and >> 157: * subject to removal in a future release. Consequently, this >> method is also >> 158: * deprecated and subject to removal. There is no replacement. > > Maybe you want to change this text to be more direct here that subject > delegation is no longer supported and what this method now does. Yes, that should be updated, the feature is gone with this change. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18025#discussion_r1516884990 PR Review Comment: https://git.openjdk.org/jdk/pull/18025#discussion_r1516885582
