On Wed, 6 Mar 2024 11:46:16 GMT, Kevin Walls <kev...@openjdk.org> wrote:

>> The deprecated Subject Delegation feature in JMX will be removed.
>> 
>> This was marked in JDK 21 as deprecated for removal (JDK-8298966).
>
> Kevin Walls has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Test specifically that UOE is thrown.

src/java.management/share/classes/javax/management/remote/JMXConnector.java 
line 153:

> 151:      *
> 152:      * @exception UnsupportedOperationException if a non-null 
> delegationSubject
> 153:      * is specifed. Subject Delegation has been removed.

Typo: s/specifed/specified/

src/java.management/share/classes/javax/management/remote/JMXConnector.java 
line 158:

> 156:      * and is only useful in conjunction with other APIs which are 
> deprecated and
> 157:      * subject to removal in a future release. Consequently, this method 
> is also
> 158:      * deprecated and subject to removal. There is no replacement.

Maybe you want to change this text to be more direct here that subject 
delegation is no longer supported and what this method now does.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18025#discussion_r1516758560
PR Review Comment: https://git.openjdk.org/jdk/pull/18025#discussion_r1516761404

Reply via email to