On Mon, 4 Mar 2024 13:37:53 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> RMIConnection comments update > > src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnection.java > line 126: > >> 124: * @param className The class name of the MBean to be instantiated. >> 125: * @param name The object name of the MBean. May be null. >> 126: * @param delegationSubject No longer supported and should be null. > > I think this interface will require all methods that take a delegation > subject to specify UOE when the subject is not null. Yes, this will > invalidate implementations that are outside of the JDK but such > implementations need to be updated anyway. Yes, updated. > src/java.management/share/classes/javax/management/remote/JMXConnector.java > line 158: > >> 156: */ >> 157: @Deprecated(since="21", forRemoval=true) >> 158: public default MBeanServerConnection >> getMBeanServerConnection(Subject delegationSubject) > > Specifying the UOE in the param description is problematic. I think you want > to specify delegationSubject as not used, must be null, then declare UOE as > one of the exceptions thrown by the method. Thanks, updated. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18025#discussion_r1511402928 PR Review Comment: https://git.openjdk.org/jdk/pull/18025#discussion_r1511401561
