On Mon, 11 Mar 2024 17:22:57 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> (C) oops
>
> test/jdk/javax/management/remote/mandatory/notif/DeadListenerTest.java line
> 78:
>
>> 76: cs.start();
>> 77: JMXServiceURL addr = cs.getAddress();
>> 78: assertTrue("Expected no connections in new connector server",
>> rmiServer.connections.isEmpty());
>
> Changes to this file seem unrelated to the removal of the feature - could you
> confirm that they were intended (no issue if they were intended).
Yes, they were intentional, should have made that clear. I had a failure from
this test at some point, and the assert message made no sense to me.
e.g. "New value of count1 == 1" is shown, but that's what was expected and not
what was seen.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18025#discussion_r1521290618
