On Wed, 10 Jul 2024 09:14:11 GMT, Christoph Langer wrote:
> The change of JDK-8294960 has brought an increase of required metaspace for
> this test on AIX which seems to go beyond 23m in most cases. So I propose
> another slight increment.
>
> Why AIX needs more metaspace co
The change of JDK-8294960 has brought an increase of required metaspace for
this test on AIX which seems to go beyond 23m in most cases. So I propose
another slight increment.
Why AIX needs more metaspace compared to other platforms is probably a
different topic.
-
Commit messages
On Fri, 5 Apr 2024 12:49:53 GMT, Sandra Payne wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adjust java.1 man page
>
> Yes, exactly the latter. With this change, it opens the door for the above
> scenario t
On Wed, 27 Mar 2024 13:44:42 GMT, Matthias Baesken wrote:
>> Currently jcmd command GC.heap_dump only works with an additionally provided
>> file name.
>> Syntax : GC.heap_dump [options]
>>
>> In case the JVM has the XX - flag HeapDumpPath set, we should support an
>> additional mode where th
On Tue, 26 Mar 2024 14:18:34 GMT, Matthias Baesken wrote:
>> We still have quite a lot of OS400 / pase related coding in the hotspot AIX
>> codebase. But this does not work and was never supported in OpenJDK. So we
>> can remove this.
>
> Matthias Baesken has updated the pull request incrementa
On Mon, 25 Mar 2024 13:26:12 GMT, Matthias Baesken wrote:
> We still have quite a lot of OS400 / pase related coding in the hotspot AIX
> codebase. But this does not work and was never supported in OpenJDK. So we
> can remove this.
Welcome cleanup. I made two minor comments.
src/hotspot/os/ai
On Thu, 14 Mar 2024 13:43:09 GMT, Matthias Baesken wrote:
>> Currently jcmd command GC.heap_dump only works with an additionally provided
>> file name.
>> Syntax : GC.heap_dump [options]
>>
>> In case the JVM has the XX - flag HeapDumpPath set, we should support an
>> additional mode where th
On Thu, 14 Mar 2024 16:54:48 GMT, Chris Plummer wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> add test HeapDumpJcmdPresetPathTest
>
> src/hotspot/share/runtime/globals.hpp line 565:
>
>> 563: "trig
On Thu, 7 Mar 2024 08:16:26 GMT, Matthias Baesken wrote:
>> We define the RESTARTABLE macro again and again at a lot of places in the
>> JDK native codebase. This could be centralized to avoid repeating it again
>> and again !
>
> Matthias Baesken has updated the pull request incrementally with
On Wed, 6 Mar 2024 16:30:23 GMT, Matthias Baesken wrote:
>> We define the RESTARTABLE macro again and again at a lot of places in the
>> JDK native codebase. This could be centralized to avoid repeating it again
>> and again !
>
> Matthias Baesken has updated the pull request incrementally with
On Thu, 11 Jan 2024 16:14:39 GMT, Joachim Kern wrote:
>> In parseAllowedMask in socketTransport.c, prefixLen of mask is compared with
>> a maxValue (32 for IPv4, 128 otherwise). This fails if it is larger than
>> 32, because getaddrinfo seems to detect IPv4 family, if IPv6 address has set
>>
On Fri, 20 Oct 2023 08:22:17 GMT, Johannes Bechberger
wrote:
>> Fix `onthrow` issue by passing the event info to the `initialize` method.
>>
>> This prevents `jdb` from receiving a broken exception event and throwing an
>> internal NullPointerException, upon attaching to the JDWP-agent.
>
> Jo
On Wed, 18 Oct 2023 21:48:33 GMT, Johannes Bechberger
wrote:
>> Fix `onthrow` issue by passing the event info to the `initialize` method.
>>
>> This prevents `jdb` from receiving a broken exception event and throwing an
>> internal NullPointerException, upon attaching to the JDWP-agent.
>
> Jo
On Wed, 18 Oct 2023 21:38:05 GMT, Johannes Bechberger
wrote:
>> Fix `onthrow` issue by passing the event info to the `initialize` method.
>>
>> This prevents `jdb` from receiving a broken exception event and throwing an
>> internal NullPointerException, upon attaching to the JDWP-agent.
>
> Jo
On Tue, 17 Oct 2023 19:54:24 GMT, Johannes Bechberger
wrote:
>> Fix `onthrow` issue by passing the event info to the `initialize` method.
>>
>> This prevents `jdb` from receiving a broken exception event and throwing an
>> internal NullPointerException, upon attaching to the JDWP-agent.
>
> Jo
On Wed, 11 Oct 2023 20:11:09 GMT, Christoph Langer wrote:
>> Johannes Bechberger has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add suggested modification
>
> LGTM
> Changes look good. I'm ap
On Wed, 11 Oct 2023 10:44:53 GMT, Johannes Bechberger
wrote:
> Fix `onthrow` issue by passing the event info to the `initialize` method.
>
> This prevents `jdb` from receiving a broken exception event and throwing an
> internal NullPointerException, upon attaching to the JDWP-agent.
LGTM
---
On Sun, 8 Oct 2023 21:51:42 GMT, Christoph Langer wrote:
> Add listings for linux-ppc64le and aix-ppc64 for the 4 already problem listed
> jstat tests.
This pull request has now been integrated.
Changeset: ad6dce37
Author:Christoph Langer
URL:
https://git.openjdk.org/jdk/
Add listings for linux-ppc64le and aix-ppc64 for the 4 already problem listed
jstat tests.
-
Commit messages:
- JDK-8317705
Changes: https://git.openjdk.org/jdk/pull/16095/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16095&range=00
Issue: https://bugs.openjdk.org/brows
On Thu, 14 Sep 2023 09:20:24 GMT, Joachim Kern wrote:
>> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) ,
>> the following test started to fail on AIX :
>> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java;
>> The problem was described in
>> [JDK-8309549](https
On Wed, 5 Jul 2023 15:01:52 GMT, Matthias Baesken wrote:
>> There are a few references to rt.jar in comments and in the codebase itself.
>> Some of them might be removed or adjusted.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last revi
On Fri, 30 Jun 2023 11:37:10 GMT, Matthias Baesken wrote:
>> There are a few references to rt.jar in comments and in the codebase itself.
>> Some of them might be removed or adjusted.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last rev
On Thu, 22 Jun 2023 09:21:29 GMT, Matthias Baesken wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java
>> line 196:
>>
>>> 194:
>>> 195: /**
>>> 196: * Set whether or not to use ct.sym as an alternate
>>
>> As an alternate to what? This needs somet
On Thu, 22 Jun 2023 11:51:15 GMT, Matthias Baesken wrote:
>> Currently, a number of tests fail on macOS because they miss the core file
>> (e.g. serviceability/sa/TestJmapCore.java).
>> The reason is that configure detects on some setups that codesign does not
>> work ("checking if debug mode c
On Thu, 22 Jun 2023 09:53:29 GMT, Matthias Baesken wrote:
>> Currently, a number of tests fail on macOS because they miss the core file
>> (e.g. serviceability/sa/TestJmapCore.java).
>> The reason is that configure detects on some setups that codesign does not
>> work ("checking if debug mode c
On Tue, 20 Jun 2023 13:23:16 GMT, Matthias Baesken wrote:
> Currently, a number of tests fail on macOS because they miss the core file
> (e.g. serviceability/sa/TestJmapCore.java).
> The reason is that configure detects on some setups that codesign does not
> work ("checking if debug mode codes
On Wed, 7 Jun 2023 14:04:14 GMT, JoKern65 wrote:
>> The sys_thread_3() function contains an empty while loop, which by the
>> standard can be optimized away. Please refer to discussion in
>> https://github.com/llvm/llvm-project/issues/60622
>> The xlc17 compiler is doing so, and IBM claims that
On Fri, 2 Jun 2023 10:19:53 GMT, JoKern65 wrote:
> This pr is a split off from JDK-8308288: Fix xlc17 clang warnings in shared
> code https://github.com/openjdk/jdk/pull/14146
> It handles the part in security and servicability.
>
> Compiling on AIX with xlc17 which contains the new clang 15 fr
On Tue, 6 Jun 2023 09:51:09 GMT, JoKern65 wrote:
> The sys_thread_3() function contains an empty while loop, which by the
> standard can be optimized away. Please refer to discussion in
> https://github.com/llvm/llvm-project/issues/60622
> The xlc17 compiler is doing so, and IBM claims that the
On Tue, 6 Jun 2023 20:43:36 GMT, Martin Doerr wrote:
>> The sys_thread_3() function contains an empty while loop, which by the
>> standard can be optimized away. Please refer to discussion in
>> https://github.com/llvm/llvm-project/issues/60622
>> The xlc17 compiler is doing so, and IBM claims
On Tue, 21 Feb 2023 08:58:50 GMT, Johannes Bechberger
wrote:
>> Extends the existing AsyncGetCallTrace test case and fixes the issue.
>
> Johannes Bechberger has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update full name
> [db483a3](htt
On Mon, 27 Feb 2023 13:23:12 GMT, Julian Waters wrote:
> Ah I see, was the initial commit made with the assumption that inttypes.h was
> already included? It's just a final confirmation before integration
Could be.
-
PR: https://git.openjdk.org/jdk/pull/12744
On Sun, 26 Feb 2023 15:10:08 GMT, Julian Waters wrote:
> @RealCLanger Sorry for the ping, just wanted to check since you're the
> original commit Author for the format string, is there someplace else where
> inttypes.h or stdint.h is included or should be included that I missed?
Hah, that was
On Fri, 24 Feb 2023 15:36:36 GMT, Julian Waters wrote:
> We no longer need to define PrId64 ourselves since the Visual C++ compiler
> supports inttypes.h on the only versions we support, so we can just replace
> it with an include to the standard header instead
Marked as reviewed by clanger (R
On Thu, 5 Jan 2023 08:55:32 GMT, Matthias Baesken wrote:
> Some exception/error message changed with 8299470 so we have to adjust the
> test.
> Current error is
>
> Unexpected error 'Successor argument without leading - is expected for 'd'
> but we got '-c''
> java.lang.RuntimeException: Bad
On Wed, 4 Jan 2023 13:04:10 GMT, Matthias Baesken wrote:
>> The test serviceability/sa/sadebugd/SADebugDTest.java can pass under some
>> circumstances a negative rmiport (--rmiport -1) to SALauncher.java.
>> This leads to a somewhat misleading message
>> `[debugd] Argument is expected for 'rmip
On Wed, 4 Jan 2023 12:10:11 GMT, Matthias Baesken wrote:
>> The test serviceability/sa/sadebugd/SADebugDTest.java can pass under some
>> circumstances a negative rmiport (--rmiport -1) to SALauncher.java.
>> This leads to a somewhat misleading message
>> `[debugd] Argument is expected for 'rmip
On Wed, 16 Nov 2022 12:00:56 GMT, Lutz Schmidt wrote:
>> This small change fixes a warning that may pop up during runtime. May I
>> please request reviews? Thank you!
>
> Lutz Schmidt has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - 82967
On Tue, 15 Nov 2022 12:58:12 GMT, Lutz Schmidt wrote:
>> This small change fixes a warning that may pop up during runtime. May I
>> please request reviews? Thank you!
>
> Lutz Schmidt has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8296709
On Mon, 14 Nov 2022 11:07:52 GMT, Lutz Schmidt wrote:
> > Couldn't you simply add a second `doExec` statement in the existing test
> > rather than copy the entire test file?
>
> Actually, I first did it that way. And I did not like it. It's not just the
> doExec, you need to duplicate the chec
On Fri, 11 Nov 2022 16:26:59 GMT, Lutz Schmidt wrote:
>> This small change fixes a warning that may pop up during runtime. May I
>> please request reviews? Thank you!
>
> Lutz Schmidt has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8296709
On Thu, 10 Nov 2022 09:02:02 GMT, Lutz Schmidt wrote:
> This small change fixes a warning that may pop up during runtime. May I
> please request reviews? Thank you!
Maybe you could also call "bin/java -Xcheck:jni
-agentlib:jdwp=transport=dt_socket,server=y,suspend=n -version" which would
show
42 matches
Mail list logo
