On Fri, 11 Nov 2022 16:26:59 GMT, Lutz Schmidt <l...@openjdk.org> wrote:
>> This small change fixes a warning that may pop up during runtime. May I >> please request reviews? Thank you! > > Lutz Schmidt has updated the pull request incrementally with one additional > commit since the last revision: > > 8296709: fix testcase naming Looks good. I commented on two nits. If you don't have a quick idea on how to fix `WARNING: JNI local refs: 921, exceeds capacity: 32`, you could open a bug for it (if there isn't one already) and right away exclude the test with reference to the new bug. The alternative would be to filter out the local refs warning but then I guess this will be forgotten. After all, either way is not perfect... test/jdk/tools/launcher/TestXcheckJdwpJNIWarnings.java line 2: > 1: /* > 2: * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. Add the current year to copyright. test/jdk/tools/launcher/TestXcheckJdwpJNIWarnings.java line 30: > 28: * @test > 29: * @bug 8187442 > 30: * @summary Launching app shouldn't produce any jni warnings. Maybe better: "Launching app with debug agent shouldn't produce any jni warnings." ? ------------- Changes requested by clanger (Reviewer). PR: https://git.openjdk.org/jdk/pull/11083
