On Wed, 11 Oct 2023 20:11:09 GMT, Christoph Langer <clan...@openjdk.org> wrote:
>> Johannes Bechberger has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add suggested modification
>
> LGTM
> Changes look good. I'm approving, but I think also @RealCLanger should
> re-review since a lot has changed since his review, including the addition of
> the test.
Thanks @plummercj for checking that so thoroughly, I couldn't do that. I only
have a few minor suggestions for cleanups.
> test/jdk/com/sun/jdi/JdwpOnThrowTest.java line 145:
>
>> 143: return connector;
>> 144: }
>> 145: }
>
> Suggestion:
>
> for (Connector connector :
> Bootstrap.virtualMachineManager().allConnectors()) {
> if (connector.name().equalsIgnoreCase(name)) {
> return connector;
> }
> }
Could be written more concise, see my suggestion.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16145#issuecomment-1769337086
PR Review Comment: https://git.openjdk.org/jdk/pull/16145#discussion_r1364550559
