On Wed, 18 Oct 2023 21:38:05 GMT, Johannes Bechberger <jbechber...@openjdk.org>
wrote:
>> Fix `onthrow` issue by passing the event info to the `initialize` method.
>>
>> This prevents `jdb` from receiving a broken exception event and throwing an
>> internal NullPointerException, upon attaching to the JDWP-agent.
>
> Johannes Bechberger has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add suggested fixes
Looks good, just a few last minor flaws. 😉
test/jdk/com/sun/jdi/JdwpOnThrowTest.java line 133:
> 131:
> 132: private static Connector getConnector(String name) {
> 133: List<Connector> connectors =
> Bootstrap.virtualMachineManager().allConnectors();
This line should then go now.
test/jdk/com/sun/jdi/OnThrowTest.java line 2:
> 1: /*
> 2: * Copyright (c) 2023 SAP SE. All rights reserved.
Changing the copyright here seems wrong, nothing changed on this file.
test/jdk/com/sun/jdi/ThrowCaughtException.java line 2:
> 1: /*
> 2: * Copyright (c) 2019, 2023, Oracle and/or its affiliates. All rights
> reserved.
This copyright should be changed.
-------------
PR Review: https://git.openjdk.org/jdk/pull/16145#pullrequestreview-1686197747
PR Review Comment: https://git.openjdk.org/jdk/pull/16145#discussion_r1364569992
PR Review Comment: https://git.openjdk.org/jdk/pull/16145#discussion_r1364570407
PR Review Comment: https://git.openjdk.org/jdk/pull/16145#discussion_r1364570668
