On Mon, 25 Mar 2024 13:26:12 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
> We still have quite a lot of OS400 / pase related coding in the hotspot AIX > codebase. But this does not work and was never supported in OpenJDK. So we > can remove this. Welcome cleanup. I made two minor comments. src/hotspot/os/aix/os_aix.cpp line 607: > 605: memset(pmi, 0, sizeof(meminfo_t)); > 606: > 607: // On AIX, I use the (dynamically loaded) perfstat library to retrieve > memory statistics maybe remove the "I" pronoun in the comment here? Also the links could be placed on one line. src/hotspot/os/aix/os_aix.cpp line 626: > 624: > 625: // excerpt from > 626: // http://publib.boulder.ibm.com/infocenter/systems/index.jsp Same here. URL on one line. Does it still work? ------------- Marked as reviewed by clanger (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18471#pullrequestreview-1959796540 PR Review Comment: https://git.openjdk.org/jdk/pull/18471#discussion_r1538868553 PR Review Comment: https://git.openjdk.org/jdk/pull/18471#discussion_r1538869884
