On Sat, 26 Oct 2024 00:43:00 GMT, Alex Menkov wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: introduce new annotation @JvmtiHideEvents and use it in
>> VirtualThread/Continuation classes to disallow Fr
On Fri, 25 Oct 2024 22:09:30 GMT, Dean Long wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Add/fix comments for David
>> - Move condition to new line in nmethod::preserve_callee_argument_oops
>
> test
On Sat, 26 Oct 2024 00:41:43 GMT, Alex Menkov wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: introduce new annotation @JvmtiHideEvents and use it in
>> VirtualThread/Continuation classes to disallow Fr
On Thu, 24 Oct 2024 14:22:28 GMT, Julian Waters wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
>> u
On Thu, 24 Oct 2024 14:22:28 GMT, Julian Waters wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
>> u
On Fri, 25 Oct 2024 21:33:24 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Mon, 21 Oct 2024 21:16:50 GMT, William Kemper wrote:
>> This PR merges JEP 404, a generational mode for the Shenandoah garbage
>> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We
>> would like to target JDK24 with this PR.
>
> William Kemper has updated the pull reques
On Sat, 26 Oct 2024 00:27:25 GMT, Dean Long wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Restore use of atPointA in test StopThreadTest.java
>> - remove interruptible check from conditional in Objec
On Fri, 25 Oct 2024 21:33:24 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 25 Oct 2024 21:33:24 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 25 Oct 2024 21:33:24 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 25 Oct 2024 21:33:24 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Mon, 21 Oct 2024 21:16:50 GMT, William Kemper wrote:
>> This PR merges JEP 404, a generational mode for the Shenandoah garbage
>> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We
>> would like to target JDK24 with this PR.
>
> William Kemper has updated the pull reques
On Fri, 25 Oct 2024 20:52:29 GMT, Serguei Spitsyn wrote:
>> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
>> frames hiding mechanism.
>> Please, see a fix description in the first comment.
>>
>> Testing:
>> - Verified with new test `vthread/CheckHiddenFrames`
>> - M
On Fri, 25 Oct 2024 21:33:24 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 25 Oct 2024 21:33:24 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Tue, 22 Oct 2024 02:18:19 GMT, Patricio Chilano Mateo
wrote:
>> src/hotspot/cpu/aarch64/continuationFreezeThaw_aarch64.inline.hpp line 300:
>>
>>> 298: CodeBlob* cb = top.cb();
>>> 299:
>>> 300: if (cb->frame_size() == 2) {
>>
>> Is this a filter to identify c2 runtime stubs? Is there
On Fri, 25 Oct 2024 21:14:25 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/java/security/SecureClassLoader.java line 1:
>>
>>> 1: /*
>>
>> The class spec still mentions "permissions which are retrieved by the system
>> policy by default". Shall we remove it? Also, `getPermissions` alw
On Fri, 25 Oct 2024 20:53:23 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/java/security/AccessControlContext.java line 141:
>>
>>> 139: throws AccessControlException
>>> 140: {
>>> 141: throw new AccessControlException("");
>>
>> No message for this exception?
>
>
On Fri, 25 Oct 2024 21:09:19 GMT, Harshitha Onkar wrote:
>> test/jdk/javax/sound/midi/Soundbanks/GetSoundBankSecurityException/GetSoundBankSecurityException.java
>> line 1:
>>
>>> 1: /*
>>
>> I believe this test becomes irrelevant without `SecurityManager`.
>>
>> The summary of the test state
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Fri, 25 Oct 2024 21:33:24 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 25 Oct 2024 21:33:24 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 25 Oct 2024 21:33:24 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 25 Oct 2024 16:47:31 GMT, Alexey Ivanov wrote:
>> This doubt applies to all the tests which exercise lazy values or similar
>> logic… without and *with* the security manager.
>>
>> Now, without the security manager, the problematic cases are no longer
>> relevant; the common path *with
On Fri, 25 Oct 2024 21:23:26 GMT, Harshitha Onkar wrote:
>> The tests with “Audit Core Reflection” in their summary fall into this
>> category, we may consider removing them.
>
> @prrace Can you please advice on “Audit Core Reflection” category of tests.
> I'm not 100% sure if these tests need
The fix enables logging in the test agent to get more details about
intermittent failures.
-
Commit messages:
- fix
Changes: https://git.openjdk.org/jdk/pull/21725/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21725&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8
On Fri, 25 Oct 2024 21:06:28 GMT, Harshitha Onkar wrote:
>> test/jdk/javax/imageio/spi/AppletContextTest/IIOPluginTest.java line 42:
>>
>>> 40: } catch (ServiceConfigurationError sce) {
>>> 41: System.out.println("Expected ServiceConfigurationError \n"
>>> + sce);
>>> 42:
On Fri, 25 Oct 2024 18:08:17 GMT, Ashutosh Mehra wrote:
>> Ioi Lam has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 8342907: Implement AOT testing mode for jtreg tests (authored by
>> @katyapav)
>> - disable test that fails with hotsp
On Fri, 25 Oct 2024 21:29:05 GMT, Patricio Chilano Mateo
wrote:
>> I see that in lightweightSynchronizer.cpp we already use the name
>> `locking_thread` (although
>> `LightweightSynchronizer::inflate_into_object_header` still uses
>> `inflating_thread`). So how about using `locking_thread` in
On Wed, 23 Oct 2024 20:42:44 GMT, Patricio Chilano Mateo
wrote:
>> src/hotspot/share/runtime/objectMonitor.hpp line 299:
>>
>>> 297: // Simply set _owner field to new_value; current value must match
>>> old_value.
>>> 298: void set_owner_from_raw(int64_t old_value, int64_t new_value);
On Fri, 25 Oct 2024 21:33:24 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 25 Oct 2024 21:33:24 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 25 Oct 2024 18:34:16 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 25 Oct 2024 19:44:54 GMT, Weijun Wang wrote:
> Comments on `java.security` classes.
>
> Also, I'd like to see some clarifications on what "the installed policy" or
> "the current policy" is. The `ProtectionDomain` mentions this when talking
> about dynamic permissions. On the other han
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes have been split into the
> following initial 4 commits:
>
> - Change
A trivial JNI refactoring in Hotspot to use `ExceptionCheck()` over
`ExceptionOccurred()` when the usage is treating the return value as a boolean.
This is part of the bigger umbrella issue:
[JDK-8341542](https://bugs.openjdk.org/browse/JDK-8341542).
> ExceptionCheck
> We introduce a
On Fri, 25 Oct 2024 21:28:22 GMT, Patricio Chilano Mateo
wrote:
>> If it's always the current thread, then it should be called 'current' imo.
>
> I see that in lightweightSynchronizer.cpp we already use the name
> `locking_thread` (although
> `LightweightSynchronizer::inflate_into_object_heade
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Fri, 25 Oct 2024 05:17:51 GMT, David Holmes wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with four
>> additional commits since the last revision:
>>
>> - Rename set/has_owner_anonymous to set/has_anonymous_owner
>> - Fix comments in javaThread.hpp and Thread.
On Fri, 25 Oct 2024 12:00:43 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/runtime/synchronizer.cpp line 1440:
>>
>>> 1438: }
>>> 1439:
>>> 1440: ObjectMonitor* ObjectSynchronizer::inflate_impl(JavaThread*
>>> inflating_thread, oop object, const InflateCause cause) {
>>
>> `inflating_thr
On Fri, 25 Oct 2024 18:08:16 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Updat
On Fri, 25 Oct 2024 14:36:46 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Updat
> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
> frames hiding mechanism.
> Please, see a fix description in the first comment.
>
> Testing:
> - Verified with new test `vthread/CheckHiddenFrames`
> - Mach5 tiers 1-6 are passed
Serguei Spitsyn has updated the pull re
On Thu, 24 Oct 2024 03:01:54 GMT, Ioi Lam wrote:
>> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://openjdk.org/jeps/483).
>>
>>
>> Note: this is a combined PR of the following individual PRs
>> - https://github.com/openjdk/jdk/pull/20516
>> - https
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Fri, 25 Oct 2024 05:25:58 GMT, David Holmes wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Add/fix comments for David
>> - Move condition to new line in nmethod::preserve_callee_argument_oops
>
> s
On Fri, 25 Oct 2024 18:30:23 GMT, Harshitha Onkar wrote:
>> The updated test `bug6694823.java` works correctly on Windows and displays
>> its popup over the Windows taskbar — it is expected.
>>
>> The popup had to be moved if the security manager didn't allow to call
>> `setAlwaysOnTop(true)`.
On Fri, 25 Oct 2024 18:39:54 GMT, Patricio Chilano Mateo
wrote:
>>> The "waiting list" here is just a list of virtual threads that need
>>> unparking by the Unblocker thread - right?
>>>
>> Yes.
>
>> Some comments here about the operation would be useful.
>>
> Added a comment.
> I'm struggling
On Fri, 25 Oct 2024 18:39:23 GMT, Patricio Chilano Mateo
wrote:
>> src/hotspot/share/classfile/javaClasses.cpp line 2082:
>>
>>> 2080: }
>>> 2081:
>>> 2082: bool java_lang_VirtualThread::set_onWaitingList(oop vthread,
>>> OopHandle& list_head) {
>>
>> Some comments here about the operation w
On Fri, 25 Oct 2024 00:26:24 GMT, David Holmes wrote:
> The "waiting list" here is just a list of virtual threads that need unparking
> by the Unblocker thread - right?
>
Yes.
> src/hotspot/share/classfile/javaClasses.cpp line 2086:
>
>> 2084: jboolean vthread_on_list = Atomic::load(addr);
>
On Thu, 24 Oct 2024 03:01:40 GMT, David Holmes wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor fixes in inc/dec_held_monitor_count on aarch64 and riscv
>
> src/java.base/share/classes/java/lang/Virt
On Fri, 25 Oct 2024 17:52:59 GMT, Alexey Ivanov wrote:
>> This particular test was failing on windows & linux after SM removal. There
>> is a functional issue and for that reason I think it is better to retain
>> this test. Details documented here -
>> [JDK-8342012](https://bugs.openjdk.org/br
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes have been split into the
> following initial 4 commits:
>
> - Change
the implementation I originally provided does not in fact solve the issue!
the attach protocol initiation "handshake" requires that the "attacher" (the
caller of this code) and the "attachee"(the target JVM to be "attached" to)
*must* share a "/tmp" (or access to the attachee's `cwd`) in common
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Fri, 30 Aug 2024 00:07:50 GMT, Alex Menkov wrote:
> The fix improves Attch API protocol and implements updated protocol on
> windows; shared code is ready to implement updated protocol support on other
> platforms.
> More detailed explanations on the 1st comment.
>
> Testing: tier1,tier2,ti
On Fri, 25 Oct 2024 12:53:04 GMT, Sean Mullan wrote:
> > I changed the name of the bug and PR. Yes there are cases where a test has
> > more than one hardcoded provider.
>
> How would that work then if the property only allows you to specify one
> provider?
The tests with multiple, hardcoded
On Fri, 25 Oct 2024 13:17:23 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 25 Oct 2024 14:57:18 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Updat
On Fri, 25 Oct 2024 17:30:56 GMT, Harshitha Onkar wrote:
>> test/jdk/javax/swing/JPopupMenu/6694823/bug6694823.java line 41:
>>
>>> 39: * @bug 6694823
>>> 40: * @summary Checks that popup menu cannot be partially hidden
>>> 41: * by the task bar.
>>
>> I believe this test is irrelev
> In this PR, I removed hard-coded security providers and replaced them with a
> system property, test.provider.name. If the property is not specified, the
> provider originally used in the test is used:
>
> Cipher c = Cipher.getInstance("AES/GCM/NoPadding",
> System.getProperty("test.provider.
On Fri, 25 Oct 2024 13:17:23 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 25 Oct 2024 15:29:40 GMT, Alexey Ivanov wrote:
>> test/jdk/javax/swing/UIDefaults/6622002/bug6622002.java line 1:
>>
>>> 1: /*
>>
>> Again, I'm unsure this test has a value after the security manager is
>> removed. All it verifies is that whatever reflection is used in
>> `UIDefaults.
On Fri, 25 Oct 2024 15:12:00 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Updat
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Fri, 25 Oct 2024 12:16:55 GMT, Matthew Donovan wrote:
> I changed the name of the bug and PR. Yes there are cases where a test has
> more than one hardcoded provider.
How would that work then if the property only allows you to specify one
provider?
-
PR Comment: https://git.op
On Wed, 11 Sep 2024 18:22:00 GMT, Simon Tooke wrote:
> This is a port of #16301 to macOS.
>
> System.map and System.dump_map are implemented using the macOS API and
> provide roughly the same information in the same format. Most of the heavy
> lifting was implemented by @tstuefe in
> https:/
On Thu, 24 Oct 2024 03:01:54 GMT, Ioi Lam wrote:
>> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://openjdk.org/jeps/483).
>>
>>
>> Note: this is a combined PR of the following individual PRs
>> - https://github.com/openjdk/jdk/pull/20516
>> - https
On Thu, 24 Oct 2024 03:01:54 GMT, Ioi Lam wrote:
>> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://openjdk.org/jeps/483).
>>
>>
>> Note: this is a combined PR of the following individual PRs
>> - https://github.com/openjdk/jdk/pull/20516
>> - https
On Wed, 2 Oct 2024 13:28:13 GMT, Robert Toyonaga wrote:
>> ### Summary
>> This PR just replaces `ThreadCritical` with a lock specific to NMT.
>> `ThreadCritical` is a big lock and is unnecessary for the purposes of NMT.
>> I've implemented the new lock with a semaphore so that it can be used e
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes have been split into the
> following initial 4 commits:
>
> - Change
On Tue, 22 Oct 2024 20:23:52 GMT, Roger Riggs wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNote to de
On Wed, 23 Oct 2024 22:59:19 GMT, Coleen Phillimore wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Add comments for Coleen
>> - Fix JvmtiUnmountBeginMark
>
> src/hotspot/cpu/aarch64/continuationFreeze
On Mon, 21 Oct 2024 12:42:08 GMT, Sean Mullan wrote:
> You are changing more than SunJCE providers, so the title of this bug should
> not be specific to SunJCE. Suggest: "Replace hardcoded security providers
> with new test.provider.name system property".
>
> Are there any cases where a test h
On Fri, 25 Oct 2024 03:51:08 GMT, David Holmes wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with four
>> additional commits since the last revision:
>>
>> - Rename set/has_owner_anonymous to set/has_anonymous_owner
>> - Fix comments in javaThread.hpp and Thread.
On Thu, 24 Oct 2024 21:06:23 GMT, Harshitha Onkar wrote:
>>> It was missed when `-Djava.security.manager=allow` was removed.
>>
>> It wasn't intentional then, was it?
>>
>>> Out of curiosity: does it have any impact on the performance of CI testing
>>> if tests are run in /othervm mode when it
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 24 Oct 2024 22:13:27 GMT, David Holmes wrote:
>> We don't unmount the virtual thread here, we just temporarily change the
>> thread identity. You could think of this method as
>> switchIdentityToCarrierThread if that helps.
>
> Sorry to belabour this but why are we temporarily changing
On Fri, 25 Oct 2024 08:25:21 GMT, Axel Boldt-Christmas
wrote:
>> This is the implementation task for `JEP 490: ZGC: Remove the
>> Non-Generational Mode`. See the JEP for details.
>> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850)
>
> Axel Boldt-Christmas has updated the pull request
On Fri, 25 Oct 2024 08:25:21 GMT, Axel Boldt-Christmas
wrote:
>> This is the implementation task for `JEP 490: ZGC: Remove the
>> Non-Generational Mode`. See the JEP for details.
>> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850)
>
> Axel Boldt-Christmas has updated the pull request
On Mon, 21 Oct 2024 22:51:54 GMT, Mandy Chung wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNote to de
On Thu, 24 Oct 2024 02:47:14 GMT, David Holmes wrote:
>> Not really, it is the state we set when the virtual thread is mounted and
>> runs again. In this case it will just run to re-contest for the monitor.
>
> So really UNBLOCKED is UNBLOCKING and mirrors BLOCKING , so we have:
>
> RUNNING ->
On Thu, 24 Oct 2024 17:16:54 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Updat
> This is the implementation task for `JEP 490: ZGC: Remove the
> Non-Generational Mode`. See the JEP for details.
> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850)
Axel Boldt-Christmas has updated the pull request with a new target base due to
a merge or a rebase. The pull request n
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes have been split into the
> following initial 4 commits:
>
> - Change
On Wed, 23 Oct 2024 21:54:25 GMT, Sean Mullan wrote:
>> test/jdk/java/lang/RuntimeTests/exec/ExecCommand.java line 241:
>>
>>> 239: Properties props = System.getProperties();
>>> 240: props.setProperty(JDK_LANG_PROCESS_ALLOW_AMBIGUOUS_COMMANDS,
>>> "");
>>> 241: System.s
On Thu, 24 Oct 2024 14:22:28 GMT, Julian Waters wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
>> u
On Wed, 23 Oct 2024 11:39:26 GMT, Stefan Karlsson wrote:
> When testing Lilliput we found a failure in
> `serviceability/sa/ClhsdbJstackWithConcurrentLock.java` test when running
> with C1-only.
>
> The test uses the SA's thread printing feature to print the threads *and* the
> "concurrent lo
On Fri, 25 Oct 2024 06:49:48 GMT, Stefan Karlsson wrote:
>> When testing Lilliput we found a failure in
>> `serviceability/sa/ClhsdbJstackWithConcurrentLock.java` test when running
>> with C1-only.
>>
>> The test uses the SA's thread printing feature to print the threads *and*
>> the "concurr
On Thu, 24 Oct 2024 08:51:47 GMT, Serguei Spitsyn wrote:
>> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
>> frames hiding mechanism.
>> Please, see a fix description in the first comment.
>>
>> Testing:
>> - Verified with new test `vthread/CheckHiddenFrames`
>> - M
On Thu, 24 Oct 2024 12:17:41 GMT, Hannes Wallnöfer wrote:
>> Please review a doc-only change to fix the order of javadoc @param tags in
>> in various OpenJDK modules. This is the third and last PR to fix the order
>> of @param tags in OpenJDK libraries.
>>
>> We are working on a javadoc featur
On Thu, 24 Oct 2024 12:16:22 GMT, Stefan Karlsson wrote:
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/VM.java line 443:
>>
>>> 441:
>>> 442:Type collectedHeap = db.lookupType("CollectedHeap");
>>> 443:CIntegerType sizeType = (CIntegerType) db.lookupType("size_t
On Thu, 24 Oct 2024 02:41:43 GMT, David Holmes wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor fixes in inc/dec_held_monitor_count on aarch64 and riscv
>
> src/java.base/share/classes/java/lang/Thre
On Thu, 24 Oct 2024 21:08:47 GMT, Patricio Chilano Mateo
wrote:
>> I guess I don't understand where this piece code fits in the overall
>> transition of the virtual thread to being parked. I would have expected the
>> LockStack to already have been moved by the time we switch identities to the
On Thu, 24 Oct 2024 14:05:40 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Tue, 22 Oct 2024 13:36:43 GMT, Hannes Wallnöfer wrote:
> Please review a doc-only change to fix the order of javadoc @param tags in in
> various OpenJDK modules. This is the third and last PR to fix the order of
> @param tags in OpenJDK libraries.
>
> We are working on a javadoc feature to
On Thu, 24 Oct 2024 12:17:41 GMT, Hannes Wallnöfer wrote:
>> Please review a doc-only change to fix the order of javadoc @param tags in
>> in various OpenJDK modules. This is the third and last PR to fix the order
>> of @param tags in OpenJDK libraries.
>>
>> We are working on a javadoc featur
1 - 100 of 107 matches
Mail list logo
