On Fri, 25 Oct 2024 17:30:56 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
>> test/jdk/javax/swing/JPopupMenu/6694823/bug6694823.java line 41: >> >>> 39: * @bug 6694823 >>> 40: * @summary Checks that popup menu cannot be partially hidden >>> 41: * by the task bar. >> >> I believe this test is irrelevant without the security manager. >> >> The test above, `test/jdk/javax/swing/JPopupMenu/6691503/bug6691503.java` >> asserts that popup menus in applets don't have their always-on-top flag set >> to true, therefore such popups will be displayed below the taskbar. >> >> Popup menus in stand-alone apps have their always-on-top flag set to true, >> therefore they can be displayed on top of the taskbar. >> >> We have a specific test which verifies >> [`TaskbarPositionTest.java`](https://github.com/openjdk/jdk/blob/master/test/jdk/javax/swing/Popup/TaskbarPositionTest.java) >> that a popup menu could overlap the taskbar. > > This particular test was failing on windows & linux after SM removal. There > is a functional issue and for that reason I think it is better to retain this > test. Details documented here - > [JDK-8342012](https://bugs.openjdk.org/browse/JDK-8342012) The updated test `bug6694823.java` works correctly on Windows and displays its popup over the Windows taskbar — it is expected. The popup had to be moved if the security manager didn't allow to call `setAlwaysOnTop(true)`. > There is a functional issue and for that reason I think it is better to > retain this test. Details documented here - > [JDK-8342012](https://bugs.openjdk.org/browse/JDK-8342012) There's no functional issue. The `bug6694823.java` test was designed to pass **with the security manager**. The `bug6694823.java` test fails without the security manager because the conditions don't hold any more. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1817116860
