On Fri, 25 Oct 2024 05:25:58 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Add/fix comments for David >> - Move condition to new line in nmethod::preserve_callee_argument_oops > > src/hotspot/share/runtime/objectMonitor.cpp line 1698: > >> 1696: // on _WaitSetLock so it's not profitable to reduce the length of >> the >> 1697: // critical section. >> 1698: > > Please restore the blank line, else it looks like the comment block pertains > to the `wait_reenter_begin`, but it doesn't. Restored. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21565#discussion_r1817199027
