On Thu, 24 Oct 2024 21:06:23 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
>>> It was missed when `-Djava.security.manager=allow` was removed. >> >> It wasn't intentional then, was it? >> >>> Out of curiosity: does it have any impact on the performance of CI testing >>> if tests are run in /othervm mode when it is not needed? >> >> I guess it does, `othervm` tests launch a new VM for each test as opposed to >> re-using an already running VM. >> >> Anyway, removing `/othervm` isn't strictly required because `java/beans` are >> run in `othervm` mode. >> >> https://github.com/openjdk/jdk/blob/d1540e2a49c7a41eb771fc9896c367187d070dec/test/jdk/TEST.ROOT#L48-L49 >> >> It caught my attention because `/othervm` is removed from tests in >> `beans/XMLEncoder/*/`, that is in subfolders, whereas in the >> `beans/XMLEncoder/` folder these are left. > > @aivanov-jdk > Right, it wasn't intentional but missed when removing > `-Djava.security.manager=allow`. > >> Anyway, removing /othervm isn't strictly required because java/beans are run >> in othervm mode. > > Thank you for clarifying. Since `/othervm` doesn't impact the beans tests > I'll keep it as-is. Let me know if you still think it is good idea to remove > it, I could do a find and replace-all on beans/XMLEncoder/ test folder. @honkar-jdk I've submitted [JDK-8343062](https://bugs.openjdk.org/browse/JDK-8343062) for additional cleanup. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1816521679
