On Thu, 24 Oct 2024 03:01:54 GMT, Ioi Lam <ik...@openjdk.org> wrote:
>> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://openjdk.org/jeps/483).
>>
>> ----
>> Note: this is a combined PR of the following individual PRs
>> - https://github.com/openjdk/jdk/pull/20516
>> - https://github.com/openjdk/jdk/pull/20517
>> - https://github.com/openjdk/jdk/pull/20843
>> - https://github.com/openjdk/jdk/pull/20958
>> - https://github.com/openjdk/jdk/pull/20959
>> - https://github.com/openjdk/jdk/pull/21049
>> - https://github.com/openjdk/jdk/pull/21143
>
> Ioi Lam has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - 8342907: Implement AOT testing mode for jtreg tests (authored by @katyapav)
> - disable test that fails with hotspot_runtime_non_cds_mode
src/hotspot/share/cds/aotClassLinker.cpp line 117:
> 115:
> 116: void AOTClassLinker::add_candidate(InstanceKlass* ik) {
> 117: _candidates->put_when_absent(ik, true);
I just noticed the use of `put_when_absent` here. This means the caller should
ensure that `ik` has not already been added to the `_candidates`. We do that
currently (`try_add_candidate` calls `is_candidate` before calling
`add_candidate`) but probably worth mentioning this contract explicitly in a
comment somewhere for future readers.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21642#discussion_r1816850893
