Re: RFR: 8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode [v3]

2024-10-10 Thread Axel Boldt-Christmas
> This is the implementation task for `JEP 490: ZGC: Remove the > Non-Generational Mode`. See the JEP for details. > [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850) Axel Boldt-Christmas has updated the pull request with a new target base due to a merge or a rebase. The incremental we

Re: RFR: 8338603: DiagnosticCommandMBean operations should standardize types for parameters [v2]

2024-10-10 Thread Chris Plummer
On Thu, 10 Oct 2024 08:51:38 GMT, Kevin Walls wrote: >> DiagnosticCommandImpl should only publish parameter types in a known >> standard set, and use "STRING" on anything else. >> e.g. We can say "FILE" in the help output for jcmd, as that's for humans, >> but the MBean parameter info should co

Re: RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang [v2]

2024-10-10 Thread Kim Barrett
On Wed, 9 Oct 2024 11:44:35 GMT, Matthias Baesken wrote: >> There are a few warnings as errors occurring when building on Linux with >> clang (clang15). Mostly these are some kind of 'unused' warnings. >> Might be related to https://bugs.openjdk.org/browse/JDK-8339156 . > > Matthias Baesken has

Re: RFR: 8341797: Fix ExceptionOccurred in jdk.jdi

2024-10-10 Thread Chris Plummer
On Thu, 10 Oct 2024 21:56:39 GMT, Justin Lu wrote: > Please review this PR which is part of the bigger umbrella bug: > https://bugs.openjdk.org/browse/JDK-8341542. > > This fixes incorrect usage of `jthrowable ExceptionOccurred(JNIEnv *env)` > within _jdk.jdi_. > This corrects instances where

Re: RFR: 8341794: Fix ExceptionOccurred in jdk.attach

2024-10-10 Thread Chris Plummer
On Thu, 10 Oct 2024 21:55:37 GMT, Justin Lu wrote: > Please review this PR which is part of the bigger umbrella bug: > https://bugs.openjdk.org/browse/JDK-8341542. > > This fixes incorrect usage of `jthrowable ExceptionOccurred(JNIEnv *env)` > within _jdk.attach_. > This corrects instances whe

Re: RFR: 8341138: Rename jtreg property docker.support as container.support [v2]

2024-10-10 Thread duke
On Thu, 10 Oct 2024 14:27:08 GMT, Ramkumar Sunderbabu wrote: >> The System property "docker.support" defined in VMProps gives a wrong >> impression that it is tied to docker alone. The property is common for any >> container runtime. Hence, it needs to be renamed as "container.support". >> >>

Re: RFR: 8341797: Fix ExceptionOccurred in jdk.jdi

2024-10-10 Thread Alex Menkov
On Thu, 10 Oct 2024 21:56:39 GMT, Justin Lu wrote: > Please review this PR which is part of the bigger umbrella bug: > https://bugs.openjdk.org/browse/JDK-8341542. > > This fixes incorrect usage of `jthrowable ExceptionOccurred(JNIEnv *env)` > within _jdk.jdi_. > This corrects instances where

Re: RFR: 8341794: Fix ExceptionOccurred in jdk.attach

2024-10-10 Thread Alex Menkov
On Thu, 10 Oct 2024 21:55:37 GMT, Justin Lu wrote: > Please review this PR which is part of the bigger umbrella bug: > https://bugs.openjdk.org/browse/JDK-8341542. > > This fixes incorrect usage of `jthrowable ExceptionOccurred(JNIEnv *env)` > within _jdk.attach_. > This corrects instances whe

Re: RFR: 8341138: Rename jtreg property docker.support as container.support [v2]

2024-10-10 Thread Mikhailo Seledtsov
On Thu, 10 Oct 2024 14:27:08 GMT, Ramkumar Sunderbabu wrote: >> The System property "docker.support" defined in VMProps gives a wrong >> impression that it is tied to docker alone. The property is common for any >> container runtime. Hence, it needs to be renamed as "container.support". >> >>

RFR: 8341797: Fix ExceptionOccurred in jdk.jdi

2024-10-10 Thread Justin Lu
Please review this PR which is part of the bigger umbrella bug: https://bugs.openjdk.org/browse/JDK-8341542. This fixes incorrect usage of `jthrowable ExceptionOccurred(JNIEnv *env)` within _jdk.jdi_. This corrects instances where the return value is being treated as a boolean. Such occurrences

RFR: 8341794: Fix ExceptionOccurred in jdk.attach

2024-10-10 Thread Justin Lu
Please review this PR which is part of the bigger umbrella bug: https://bugs.openjdk.org/browse/JDK-8341542. This fixes incorrect usage of `jthrowable ExceptionOccurred(JNIEnv *env)` within _jdk.attach_. This corrects instances where the return value is being treated as a boolean. Such occurren

Re: RFR: 8341820: Check return value of hcreate_r

2024-10-10 Thread Chris Plummer
On Thu, 10 Oct 2024 08:57:44 GMT, Matthias Baesken wrote: > In symtab.c there is some coding where hcreate_r is used. We should check the > return value of the call (previously there was some guarantee checking the > return value but uncommented). > > This has been discussed in the PR of > [J

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v3]

2024-10-10 Thread Roman Kennke
On Tue, 8 Oct 2024 17:20:31 GMT, William Kemper wrote: >> This PR merges JEP 404, a generational mode for the Shenandoah garbage >> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We >> would like to target JDK24 with this PR. > > William Kemper has updated the pull request

Re: RFR: 8341436: containers/docker/TestJcmdWithSideCar.java takes needlessly long to run [v3]

2024-10-10 Thread Sebastian Lövdahl
On Wed, 9 Oct 2024 19:45:24 GMT, Kevin Walls wrote: >> Sebastian Lövdahl has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Have EventGeneratorLoop end after a more predictable duration > > Yes OEL was Oracle Linux: > > Our CI tests with d

Re: RFR: 8341819: LightweightSynchronizer::enter_for races with deflation [v2]

2024-10-10 Thread Axel Boldt-Christmas
On Thu, 10 Oct 2024 11:59:24 GMT, Axel Boldt-Christmas wrote: >> This is a regression from >> [JDK-8315884](https://bugs.openjdk.org/browse/JDK-8315884). >> >> When using `+UseObjectMonitorTable` monitors are inflated in a locked state >> effectively blocking out deflation. `LightweightSynchr

Integrated: 8341819: LightweightSynchronizer::enter_for races with deflation

2024-10-10 Thread Axel Boldt-Christmas
On Wed, 9 Oct 2024 11:16:46 GMT, Axel Boldt-Christmas wrote: > This is a regression from > [JDK-8315884](https://bugs.openjdk.org/browse/JDK-8315884). > > When using `+UseObjectMonitorTable` monitors are inflated in a locked state > effectively blocking out deflation. `LightweightSynchronizer

Re: RFR: 8341138: Rename jtreg property docker.support as container.support [v2]

2024-10-10 Thread Severin Gehwolf
On Thu, 10 Oct 2024 14:27:08 GMT, Ramkumar Sunderbabu wrote: >> The System property "docker.support" defined in VMProps gives a wrong >> impression that it is tied to docker alone. The property is common for any >> container runtime. Hence, it needs to be renamed as "container.support". >> >>

Re: RFR: 8341138: Rename jtreg property docker.support as container.support [v2]

2024-10-10 Thread Ramkumar Sunderbabu
> The System property "docker.support" defined in VMProps gives a wrong > impression that it is tied to docker alone. The property is common for any > container runtime. Hence, it needs to be renamed as "container.support". > > Positive Testing: > tier1,tier2,tier3 - to check stability > tier5 -

Re: RFR: 8341819: LightweightSynchronizer::enter_for races with deflation [v2]

2024-10-10 Thread Patricio Chilano Mateo
On Thu, 10 Oct 2024 11:59:24 GMT, Axel Boldt-Christmas wrote: >> This is a regression from >> [JDK-8315884](https://bugs.openjdk.org/browse/JDK-8315884). >> >> When using `+UseObjectMonitorTable` monitors are inflated in a locked state >> effectively blocking out deflation. `LightweightSynchr

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v3]

2024-10-10 Thread Roman Kennke
On Thu, 10 Oct 2024 13:13:14 GMT, Roman Kennke wrote: >> William Kemper has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 478 commits: >> >> - Fix merge error >> - Merge remote-tracking branch 'jdk/master' into great-genshen-pr-re

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v3]

2024-10-10 Thread Roman Kennke
On Tue, 8 Oct 2024 17:20:31 GMT, William Kemper wrote: >> This PR merges JEP 404, a generational mode for the Shenandoah garbage >> collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We >> would like to target JDK24 with this PR. > > William Kemper has updated the pull request

Re: RFR: 8341819: LightweightSynchronizer::enter_for races with deflation

2024-10-10 Thread Axel Boldt-Christmas
On Wed, 9 Oct 2024 11:16:46 GMT, Axel Boldt-Christmas wrote: > This is a regression from > [JDK-8315884](https://bugs.openjdk.org/browse/JDK-8315884). > > When using `+UseObjectMonitorTable` monitors are inflated in a locked state > effectively blocking out deflation. `LightweightSynchronizer

Re: RFR: 8341819: LightweightSynchronizer::enter_for races with deflation [v2]

2024-10-10 Thread Axel Boldt-Christmas
> This is a regression from > [JDK-8315884](https://bugs.openjdk.org/browse/JDK-8315884). > > When using `+UseObjectMonitorTable` monitors are inflated in a locked state > effectively blocking out deflation. `LightweightSynchronizer::enter_for` > assumed this to be true. But when the `-UseObjec

Re: RFR: 8341273: JVMTI is not properly hiding some continuation related methods [v3]

2024-10-10 Thread Serguei Spitsyn
On Wed, 9 Oct 2024 22:58:33 GMT, Serguei Spitsyn wrote: >> This fixes a problem in the VTMS (Virtual Thread Mount State) transition >> frames hiding mechanism. >> Please, see a fix description in the first comment. >> >> Testing: >> - Verified with new test `vthread/CheckHiddenFrames` >> - Ma

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v39]

2024-10-10 Thread Roberto Castañeda Lozano
On Tue, 8 Oct 2024 16:30:47 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> previ

RFR: 8341820: Check return value of hcreate_r

2024-10-10 Thread Matthias Baesken
In symtab.c there is some coding where hcreate_r is used. We should check the return value of the call (previously there was some guarantee checking the return value but uncommented). This has been discussed in the PR of [JDK-8341722](https://bugs.openjdk.org/browse/JDK-8341722) .

Re: RFR: 8338603: DiagnosticCommandMBean operations should standardize types for parameters [v2]

2024-10-10 Thread Kevin Walls
> DiagnosticCommandImpl should only publish parameter types in a known standard > set, and use "STRING" on anything else. > e.g. We can say "FILE" in the help output for jcmd, as that's for humans, but > the MBean parameter info should contain "STRING". Kevin Walls has updated the pull request w

Re: RFR: 8338603: DiagnosticCommandMBean operations should standardize types for parameters

2024-10-10 Thread Kevin Walls
On Wed, 9 Oct 2024 20:36:07 GMT, Chris Plummer wrote: >> DiagnosticCommandImpl should only publish parameter types in a known >> standard set, and use "STRING" on anything else. >> e.g. We can say "FILE" in the help output for jcmd, as that's for humans, >> but the MBean parameter info should c

Integrated: 8341722: Fix some warnings as errors when building on Linux with toolchain clang

2024-10-10 Thread Matthias Baesken
On Tue, 8 Oct 2024 13:38:54 GMT, Matthias Baesken wrote: > There are a few warnings as errors occurring when building on Linux with > clang (clang15). Mostly these are some kind of 'unused' warnings. > Might be related to https://bugs.openjdk.org/browse/JDK-8339156 . This pull request has now b

Re: RFR: 8341722: Fix some warnings as errors when building on Linux with toolchain clang [v2]

2024-10-10 Thread Matthias Baesken
On Wed, 9 Oct 2024 11:44:35 GMT, Matthias Baesken wrote: >> There are a few warnings as errors occurring when building on Linux with >> clang (clang15). Mostly these are some kind of 'unused' warnings. >> Might be related to https://bugs.openjdk.org/browse/JDK-8339156 . > > Matthias Baesken has