On Thu, 10 Oct 2024 21:55:37 GMT, Justin Lu <j...@openjdk.org> wrote:
> Please review this PR which is part of the bigger umbrella bug: > https://bugs.openjdk.org/browse/JDK-8341542. > > This fixes incorrect usage of `jthrowable ExceptionOccurred(JNIEnv *env)` > within _jdk.attach_. > This corrects instances where the return value is being treated as a boolean. > Such occurrences are replaced with `jboolean ExceptionCheck(JNIEnv *env)`. > > JNI Docs - ExceptionCheck >> We introduce a convenience function to check for pending exceptions without >> creating a local reference to the exception object. ... Returns JNI_TRUE >> when there is a pending exception; otherwise, returns JNI_FALSE. Marked as reviewed by cjplummer (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/21459#pullrequestreview-2361906968
