On Thu, 10 Oct 2024 14:27:08 GMT, Ramkumar Sunderbabu <rsunderb...@openjdk.org> 
wrote:

>> The System property "docker.support" defined in VMProps gives a wrong 
>> impression that it is tied to docker alone. The property is common for any 
>> container runtime. Hence, it needs to be renamed as "container.support".
>> 
>> Positive Testing:
>> tier1,tier2,tier3 - to check stability
>> tier5 - to run container tests
>> 
>> Negative Testing:
>> Ran the following groups in hosts where container is not present.
>> open/test/hotspot/jtreg/containers/
>> open/test/jdk/jdk/internal/platform/docker/
>> open/test/jdk/jdk/internal/platform/cgroup/
>
> Ramkumar Sunderbabu has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   addressing review comment

Marked as reviewed by mseledtsov (Committer).

Changes look good to me. Thank you for making these changes.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21423#pullrequestreview-2361544516
PR Comment: https://git.openjdk.org/jdk/pull/21423#issuecomment-2406168566

Reply via email to