This is the first step for [JDK-8318483 - Move CDS configuration management
into cdsConfig.hpp](https://bugs.openjdk.org/browse/JDK-8318483)
- Remove `Arguments::is_dumping_archive()` and `Arguments
assert_is_dumping_archive()`
- Add the following new APIs
class CDSConfig {
static bool is_du
On Wed, 18 Oct 2023 23:37:58 GMT, Serguei Spitsyn wrote:
> Looks good. It is more elegant now. I was thinking if it'd make sense to move:
>
> * `notifyJvmtiMount(/*hide*/true);` at start of `mount()`
> * `notifyJvmtiUnmount(/*hide*/false);` at end of unmount()
> but I guess you wanted to have
On Wed, 18 Oct 2023 07:34:19 GMT, Kimura Yukihiro wrote:
> I would like to fix this issue
> because the test dose not work as intended.
> Could someone please review it?
>
> Thanks,
> Kimura Yukihiro
Hi Kimura,
The fix looks okay to me. Thank you for taking care about it.
I'm not aware much a
On Thu, 19 Oct 2023 02:19:35 GMT, Alex Menkov wrote:
>> All test cases in getclfld007 had 1 (or 0) field in test classes/interfaces.
>> The change adds several fields in one of the test classes to verify order of
>> the returned fields (as described by GetClassFields spec: "in the order they
>>
On Wed, 18 Oct 2023 11:25:19 GMT, Hannes Greule wrote:
>> See the bug description for more information.
>>
>> This implementation brings down the time to take a heap dump on the example
>> application in the bug report to <2 seconds on my machine.
>
> Hannes Greule has updated the pull request
> All test cases in getclfld007 had 1 (or 0) field in test classes/interfaces.
> The change adds several fields in one of the test classes to verify order of
> the returned fields (as described by GetClassFields spec: "in the order they
> occur in the class file").
> Field order in the class file
On Thu, 7 Sep 2023 02:19:10 GMT, Yi Yang wrote:
>> This patch reduce ~16%(24s->20s) pahse 2 merge time during dumping 32g heap
>> with 96threads and fixes a memory leak of compressor
>>
>> You might argue why this is Linux-only optimization, because sendfile
>> requires at least socket fd in o
On Wed, 18 Oct 2023 23:47:43 GMT, Serguei Spitsyn wrote:
>> Johannes Bechberger has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add suggested fixes
>
> test/jdk/com/sun/jdi/JdwpOnThrowTest.java line 94:
>
>> 92:
On Wed, 18 Oct 2023 01:40:18 GMT, Alex Menkov wrote:
>> All test cases in getclfld007 had 1 (or 0) field in test classes/interfaces.
>> The change adds several fields in one of the test classes to verify order of
>> the returned fields (as described by GetClassFields spec: "in the order they
>>
On Wed, 18 Oct 2023 01:40:18 GMT, Alex Menkov wrote:
>> All test cases in getclfld007 had 1 (or 0) field in test classes/interfaces.
>> The change adds several fields in one of the test classes to verify order of
>> the returned fields (as described by GetClassFields spec: "in the order they
>>
On Wed, 18 Oct 2023 01:40:18 GMT, Alex Menkov wrote:
>> All test cases in getclfld007 had 1 (or 0) field in test classes/interfaces.
>> The change adds several fields in one of the test classes to verify order of
>> the returned fields (as described by GetClassFields spec: "in the order they
>>
On Wed, 18 Oct 2023 01:40:18 GMT, Alex Menkov wrote:
>> All test cases in getclfld007 had 1 (or 0) field in test classes/interfaces.
>> The change adds several fields in one of the test classes to verify order of
>> the returned fields (as described by GetClassFields spec: "in the order they
>>
On Wed, 18 Oct 2023 21:48:33 GMT, Johannes Bechberger
wrote:
>> Fix `onthrow` issue by passing the event info to the `initialize` method.
>>
>> This prevents `jdb` from receiving a broken exception event and throwing an
>> internal NullPointerException, upon attaching to the JDWP-agent.
>
> Jo
On Sat, 14 Oct 2023 18:07:45 GMT, Alan Bateman wrote:
> JVMTI is notified after a virtual thread unmounts. Right not, this
> notification is done after the virtual thread has finished parking or
> yielding so it's possible for the virtual to continue, and be mounted on a
> different carrier, b
On Wed, 18 Oct 2023 21:48:33 GMT, Johannes Bechberger
wrote:
>> Fix `onthrow` issue by passing the event info to the `initialize` method.
>>
>> This prevents `jdb` from receiving a broken exception event and throwing an
>> internal NullPointerException, upon attaching to the JDWP-agent.
>
> Jo
On Wed, 18 Oct 2023 21:48:33 GMT, Johannes Bechberger
wrote:
>> Fix `onthrow` issue by passing the event info to the `initialize` method.
>>
>> This prevents `jdb` from receiving a broken exception event and throwing an
>> internal NullPointerException, upon attaching to the JDWP-agent.
>
> Jo
On Wed, 18 Oct 2023 21:40:54 GMT, Christoph Langer wrote:
>> Johannes Bechberger has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add suggested fixes
>
> test/jdk/com/sun/jdi/OnThrowTest.java line 2:
>
>> 1: /*
>> 2: * Copyright (c) 202
> Fix `onthrow` issue by passing the event info to the `initialize` method.
>
> This prevents `jdb` from receiving a broken exception event and throwing an
> internal NullPointerException, upon attaching to the JDWP-agent.
Johannes Bechberger has updated the pull request incrementally with one
On Wed, 18 Oct 2023 21:38:05 GMT, Johannes Bechberger
wrote:
>> Fix `onthrow` issue by passing the event info to the `initialize` method.
>>
>> This prevents `jdb` from receiving a broken exception event and throwing an
>> internal NullPointerException, upon attaching to the JDWP-agent.
>
> Jo
> Fix `onthrow` issue by passing the event info to the `initialize` method.
>
> This prevents `jdb` from receiving a broken exception event and throwing an
> internal NullPointerException, upon attaching to the JDWP-agent.
Johannes Bechberger has updated the pull request incrementally with one
On Wed, 18 Oct 2023 20:28:53 GMT, Christoph Langer wrote:
>> Johannes Bechberger has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add suggested modification
>
> src/jdk.jdwp.agent/share/native/libjdwp/debugInit.c line 631:
>
>> 629: * I
On Wed, 18 Oct 2023 21:04:48 GMT, Christoph Langer wrote:
>> Johannes Bechberger has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add suggested modification
>
> test/jdk/com/sun/jdi/JdwpOnThrowTest.java line 29:
>
>> 27: import com.sun.j
On Tue, 17 Oct 2023 19:54:24 GMT, Johannes Bechberger
wrote:
>> Fix `onthrow` issue by passing the event info to the `initialize` method.
>>
>> This prevents `jdb` from receiving a broken exception event and throwing an
>> internal NullPointerException, upon attaching to the JDWP-agent.
>
> Jo
On Wed, 11 Oct 2023 20:11:09 GMT, Christoph Langer wrote:
>> Johannes Bechberger has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add suggested modification
>
> LGTM
> Changes look good. I'm approving, but I think also @RealCLanger shoul
On Thu, 2 Feb 2023 12:54:06 GMT, Boris Ulasevich wrote:
> This is another pull request to replace
> https://github.com/openjdk/jdk/pull/10025 change which was blocked as not
> acceptable (see
> https://github.com/openjdk/jdk/pull/10025#pullrequestreview-1228216330)
>
> The objections to chang
On Wed, 18 Oct 2023 01:40:18 GMT, Alex Menkov wrote:
>> All test cases in getclfld007 had 1 (or 0) field in test classes/interfaces.
>> The change adds several fields in one of the test classes to verify order of
>> the returned fields (as described by GetClassFields spec: "in the order they
>>
On Tue, 17 Oct 2023 19:54:24 GMT, Johannes Bechberger
wrote:
>> Fix `onthrow` issue by passing the event info to the `initialize` method.
>>
>> This prevents `jdb` from receiving a broken exception event and throwing an
>> internal NullPointerException, upon attaching to the JDWP-agent.
>
> Jo
On Wed, 18 Oct 2023 07:07:45 GMT, Johannes Bechberger
wrote:
>> test/jdk/com/sun/jdi/JdwpOnThrowTest.java line 121:
>>
>>> 119: private static String ATTACH_CONNECTOR =
>>> "com.sun.jdi.SocketAttach";
>>> 120: // cache socket attaching connector
>>> 121: private static AttachingCon
On Fri, 13 Oct 2023 01:38:13 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add call to publish in parallel gc and update counter
On Wed, 18 Oct 2023 11:21:24 GMT, Hannes Greule wrote:
> Fixed the wrong indent. Thank you for your review. Do I need another one or
> can we proceed?
Hotspot changes require 2 reviewers
-
PR Comment: https://git.openjdk.org/jdk/pull/16083#issuecomment-1769017339
On Sat, 14 Oct 2023 20:17:31 GMT, Hannes Greule wrote:
>> See the bug description for more information.
>>
>> This implementation brings down the time to take a heap dump on the example
>> application in the bug report to <2 seconds on my machine.
>
> Hannes Greule has updated the pull request
> See the bug description for more information.
>
> This implementation brings down the time to take a heap dump on the example
> application in the bug report to <2 seconds on my machine.
Hannes Greule has updated the pull request incrementally with one additional
commit since the last revisio
I would like to fix this issue
because the test dose not work as intended.
Could someone please review it?
Thanks,
Kimura Yukihiro
-
Commit messages:
- 8318410: [TESTBUG]
jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese
Windows
Changes: https://git.o
On Wed, 18 Oct 2023 00:01:08 GMT, Chris Plummer wrote:
> Does that mean the open is done by the debugger before the debuggee even
> throws the exception, and that just leaves the debugger blocked on the open
> until the debuggee does an accept?
Yes. This is for three reasons:
1. server mode i
34 matches
Mail list logo
