On Wed, 18 Oct 2023 07:34:19 GMT, Kimura Yukihiro <kyukih...@openjdk.org> wrote:
> I would like to fix this issue
> because the test dose not work as intended.
> Could someone please review it?
>
> Thanks,
> Kimura Yukihiro
Hi Kimura,
The fix looks okay to me. Thank you for taking care about it.
I'm not aware much about all these encoding names and their correctness.
How did you test all these languages?
Thanks,
Serguei
test/jdk/java/lang/instrument/BootClassPath/Setup.java line 49:
> 47: String premainClass = args[1];
> 48: boolean isCygwin = false;
> 49: if (args.length==3 && args[2].equals("CYGWIN")) {
Nit: Could you, please, add spaces around `==`?
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16235#pullrequestreview-1686650051
PR Review Comment: https://git.openjdk.org/jdk/pull/16235#discussion_r1364868689
