On Wed, 18 Oct 2023 21:04:48 GMT, Christoph Langer <clan...@openjdk.org> wrote:
>> Johannes Bechberger has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add suggested modification
>
> test/jdk/com/sun/jdi/JdwpOnThrowTest.java line 29:
>
>> 27: import com.sun.jdi.connect.Connector;
>> 28: import com.sun.jdi.connect.IllegalConnectorArgumentsException;
>> 29: import com.sun.jdi.connect.ListeningConnector;
>
> Unneeded imports:
> import com.sun.jdi.connect.ListeningConnector;
> import com.sun.jdi.request.EventRequestManager;
> import jdk.test.lib.Utils;
>
> import java.net.Inet4Address;
> import java.net.Inet6Address;
> import java.net.InetAddress;
Good catch.
> test/jdk/com/sun/jdi/lib/jdb/Debuggee.java line 195:
>
>> 193:
>> 194: String getTransport() {
>> 195: if (address == null) {
>
> Is the address check appropriate/required here (in the getTransport() method)?
It is wrong, should have been a check for `transport == null`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16145#discussion_r1364561405
PR Review Comment: https://git.openjdk.org/jdk/pull/16145#discussion_r1364559620
