Re: [openstreetmap/openstreetmap-website] Add short links to OSM objects (Issue #5244)

2024-10-02 Thread Andy Allan via rails-dev
I don't think this is important enough to spend much time on. Using the osm.org domain helps, and I think is sufficient. That's available today, and works, and so there's not much more to do here. After that, we're only discussing a small number of characters changing e.g. `changeset -> c` whic

[openstreetmap/openstreetmap-website] Add devcontainer configuration (Issue #5264)

2024-10-16 Thread Andy Allan via rails-dev
We added support for Docker-based development in [2021](https://github.com/openstreetmap/openstreetmap-website/pull/2409) (based on a PR started in 2019). At this time there were no clear conventions for setting up docker-based development environments, so we did our own thing. Nowadays, a numb

Re: [openstreetmap/openstreetmap-website] Added workflow for PR labeling using Danger (PR #4988)

2024-10-16 Thread Andy Allan via rails-dev
@gravitystorm pushed 1 commit. 33d6580f414714408f74872ab9ef5b73c4b92972 Rephrase translation label, and fix link to docs -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4988/files/e307b9037a05fb6ea0a8790cb6f6e0824781e949..33d6580f414714408f74872ab9ef5b73c4b929

Re: [openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)

2024-10-16 Thread Andy Allan via rails-dev
@gravitystorm commented on this pull request. > @@ -280,8 +280,8 @@ resource :profile, :only => [:edit, :update] # friendships - match "/user/:display_name/make_friend" => "friendships#make_friend", :via => [:get, :post], :as => "make_friend" - match "/user/:display_name/remove_friend

Re: [openstreetmap/openstreetmap-website] Re-enable javascript unit tests (#2595)

2024-10-16 Thread Andy Allan via rails-dev
Fixed by @kcne in #5216 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2595#issuecomment-2417317079 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Re-enable javascript unit tests (#2595)

2024-10-16 Thread Andy Allan via rails-dev
Closed #2595 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2595#event-14684076309 You are receiving this because you are subscribed to this thread. Message ID: ___ rai

Re: [openstreetmap/openstreetmap-website] Automate some code review comments (Issue #4912)

2024-10-16 Thread Andy Allan via rails-dev
I've merged both these PRs, so this issue can be closed. If anyone has ideas for how to automate more aspects of reviewing pull requests, please open an issue! The more that we can do automatically, the quicker that contributors will get feedback, and the more likely they are to update their P

Re: [openstreetmap/openstreetmap-website] Add pull request template (PR #4919)

2024-10-16 Thread Andy Allan via rails-dev
Merged #4919 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4919#event-14684006832 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Add pull request template (PR #4919)

2024-10-16 Thread Andy Allan via rails-dev
Thanks for the suggestion @rkoeze and for making changes based on the feedback. I've merged this now, let's see how it goes! Thanks also to @tordans and @nenad-vujicic for reviewing this PR, it's appreciated. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetma

Re: [openstreetmap/openstreetmap-website] Automate some code review comments (Issue #4912)

2024-10-16 Thread Andy Allan via rails-dev
Closed #4912 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/4912#event-14684034773 You are receiving this because you are subscribed to this thread. Message ID: ___ rai

[openstreetmap/openstreetmap-website] Replace router.js with Turbo (Issue #5265)

2024-10-16 Thread Andy Allan via rails-dev
We have a router.js file, which allows page navigation without full page reloads. However, this functionality is also provided, along with a lot more things, by Turbo. We should figure out how to remove our router.js. This would ideally be done incrementally, but if necessary could be implement

[openstreetmap/openstreetmap-website] Avoid linking to redirects on the osmfoundation website (PR #5266)

2024-10-16 Thread Andy Allan via rails-dev