I've been asked why we can't merge either #5327 or #5340 to remove the darken
filter.
Normally, maintainers can merge any pull request that they are happy with, and
personally I'd be happy to merge these, since they both fit with my proposals
at
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2488361637
. (Although one has a merge commit so can't be merged for technical reasons.)
However, the PR that implemented the filter (#4712) was created by another
maintainer and merged by a third maintainer, and so I need to respect that and
not unilaterally undo their decisions. Since the third maintainer doesn't want
to discuss dark mode any longer, then @AntonKhorev and I need to come to
agreement on the way forward.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2504188456
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/issues/5328/2504188...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
