No offense, but letting someone else decide is such a lazy solution. You are
the developers, this is your app. So why can't you decide? Do you not have the
time/energy or what is the reason?
>It is the choice of the cartographers.
Why? Why can't the users change the way the map is displayed in
>Something to remember if SVG filters will be used: Firefox ignores filter
>definitions if they are behind a display: none.
@hlfan Looks like it's fixed now.
>Do you mean layering filters or changing the Map Tile URL under the heading
>Map Tile URL?
I wanted to test different layers like Cycle
> I made a little utility to try out filter combinations more easily:
> https://codepen.io/hlfan/full/GRVVGog For convenient editing in the dev
> tools, the outputted filter is stored in a custom property and the filter is
> also applied to the SVG that holds the filters.
@hlfan This is really
In 6 months no one has noticed anything wrong with it or realized that a better
proposal already exists? Crazy.
At this rate it will probably take us 6 more months to get that filter removed
and 6 years to discuss the 2 filters we're proposing.
--
Reply to this email directly or view it on Git
@Wilhem275
>It's not a fear, it's an absolute certainty that the output will be a mess 😄
Exactly what's happening here:
I messed something up back then and couldn't be bothered to edit the screenshot
afterwards, since it was just about showing the new options. Here is what the
preview actually l
>The main issue I see is that your proposal adds a 'theme' to a layer.
It adds a theme to the whole map. The user can turn it on or off, but they have
no control over specific layers.
>A 'dark mode' (as this issue calls it) is from a user perspective a layer.
No, this is what I'm proposing:
Dark theme toggle depends on system settings (just like now), but user can
override it by pressing the toggle button in top left corner. The setting will
be remembe
> Just deploy it, we’ll see if many people complain 😅
Since most Firefox users browse modern websites just fine, I suspect not many.
But [here's a UI
proposal](https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2480755496)
that would let you quickly disable the filt
> I'd rank the Options 4 > 1 > 3 > 2 (current), since these performance issues
> came up.
I'm sorry, but I think it's an exaggeration to call it that. There aren't
performance issues, it's a bug in Firefox that affects an unknown amount of
users. It's unfortunate that some people experience it,
>For years nobody could produce viable pull requests implementing dark mode.
>https://github.com/openstreetmap/openstreetmap-website/pull/2532 and
>https://github.com/openstreetmap/openstreetmap-website/pull/3028 were
>overriding a ton of css, justifying it with arguments like osm-website doesn'
> @pkrasicki And you can drag the map smoothly? I have a huge increase in input
> lag when dragging the dark map.
It's smooth for me on a 10 years old CPU running Firefox 128.4.0esr. Sometimes
it's laggy when I have the dev tools open, but that happens regardless if the
filter is enabled or not
Maybe you can see it and I can't, because of your monitor's higher refresh rate
(I'm not sure about your laptop, though) or because I'm testing on 1080p.
Thanks for finding those bug reports. We could include an option to disable the
filter for the people affected by this bug (so allow them to h
> Have you tried a more complex filter like `brightness(0.6) invert(1)
> contrast(3) hue-rotate(200deg) saturate(0.3) brightness(0.7)` on Firefox?
@Nekzuris Yes, you can test that specific filter [on this
site](https://issviewer.com).
Here is how to easily test different filters yourself.
1. Go
>Couldn't the dark mode have waited for the release of the vector.osm.org tiles?
@hlfan There is nothing wrong with incremental progress. The issue here is that
the devs have been ignoring our dark map discussion for years and did something
without talking to the community, which turned out to b
So why have dark mode if the main element of the app isn't dark? If you want to
have an option to configure this, I can understand that, it might be a good
idea. But having a dark map in dark mode seems like a sane default for a **map
viewer** application.
--
Reply to this email directly or vi
Of course dark mode isn't about contrast. It's about brightness. People either
don't want to stare at a bright screen all day/night or they want to conserve
battery on mobile. That's why we need a dark theme and a dark map and why other
map applications have them. That's why option 1 is not a so
1. Have a problem, i.e. lack of dark mode.
2. The proper solution is difficult.
3. People propose temporary workarounds and submit PRs to fix the problem.
4. Reject their PRs and ignore their proposals, listing an infinite amount of
side problems that would need to be considered first.
5. The disc
In that issue you're not talking about our specific ideas for filters, you
didn't show screenshots or said how to test them. You are just discussing
different approaches. Option 1 is do nothing. Option 2 is your workaround that
you've just implemented. Option 3 is our workaround. Option 4 is the
@pkrasicki commented on this pull request.
> @@ -504,7 +504,13 @@ body.small-nav {
@include color-mode(dark) {
.leaflet-tile-container,
.mapkey-table-entry td:first-child > * {
-filter: brightness(.8);
+filter: invert(100%) hue-rotate(180deg) brightness(95%) contrast(90%);
@Dr-Mx
Alternative proposal:
`filter: brightness(0.6) invert(1) contrast(3) hue-rotate(200deg) saturate(0.3)
brightness(0.7);`
You can test it here: https://issviewer.com
Full source code: https://github.com/pkras
>This issue has always struggled to be actionable, since there are at least 3
>different topics to consider
It failed to be actionable, because developers have rejected PRs and
suggestions from contributors. Now they've completely ignored our proposed
solution for a dark map and went with somet
@pkrasicki commented on this pull request.
> @@ -504,7 +504,13 @@ body.small-nav {
@include color-mode(dark) {
.leaflet-tile-container,
.mapkey-table-entry td:first-child > * {
-filter: brightness(.8);
+filter: invert(100%) hue-rotate(180deg) brightness(95%) contrast(90%);
But is
@kcne
>Would you know which class should be targeted to apply this effect to the map?
I'm not using the latest version of Leaflet, so I don't know if anything has
changed, but back then I did this:
JS code:
```js
const mapElementId = "map";
map = L.map(mapElementId,
{
attributionControl
29 matches
Mail list logo
