@hlfan Great work! I didn't even know there was a feature like that. And 
recently I've even thought of using WebGL shaders for a more advanced filter 
(there is a Leaflet plugin for that). Anyway, which of the options you've 
tested you think would be best? Gamma is already a big improvement over the 
current situation. Invert still seems better, but even with more control that 
we got here it might not be usable for all layers.

@Wilhem275 I'm not a map expert, but I don't think a map is like a photo at 
all. It's not satellite images, it's just a bunch of data that we want to 
display to the user in the most intuitive way possible. As long at the 
information is still visible and easy to understand, changing the colors **a 
little bit** isn't a big deal. Obviously nothing should be done without testing 
and discussion.

>Because the main purpouse of dark modes is not to alter colours altogether, 
>it's to avoid large fields of pure bright white. As you'll find in Wikipedia 
>or default Gmail's backgrounds (or Github, now that I see it).

And in order to do that, you have to alter colors. You change the background 
color and then you change other colors too, because colors that work well on a 
white background usually don't work well on a dark background. Developing a 
dark theme requires changing colors.

>This was done so well that, I think, a toggle switch is NOT needed at all. I 
>don't think you'll find any dark mode user wishing to keep OSM non-map 
>elements white.

There might be people who want to enjoy dark/light theme without changing their 
system settings.

>Also, @pkrasicki examples with filtering are actually quite good for night 
>reading, but again I wouldn't like to have them forced on my permanently 
>dark-set browser. I understand they operate at site level, but is there a way 
>to channel them as a layer choice instead of forcing them upon any layer?

[This 
proposal](https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2480755496)
 would let you easily disable the filters by changing the map theme to light.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2481319542
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/issues/5328/2481319...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to