>For years nobody could produce viable pull requests implementing dark mode.
>https://github.com/openstreetmap/openstreetmap-website/pull/2532 and
>https://github.com/openstreetmap/openstreetmap-website/pull/3028 were
>overriding a ton of css, justifying it with arguments like osm-website doesn't
>change much therefore we can afford it
>https://github.com/openstreetmap/openstreetmap-website/pull/2532#issuecomment-585434930.
They were viable and it was probably the only way without migrating to
Bootstrap 5. That's how the site was written, it's nobody's fault.
>Why would anyone use your invert+rotate filter you've been promoting in
>https://github.com/openstreetmap/openstreetmap-website/issues/2332 if the
>entire site doesn't have a dark mode?
I've never proposed to have dark map without dark theme.
>Tracestrack on low zooms doesn't look good even we ignore shadows. The colors
>are completely off.
Can we tweak the colors for this particular layer?
>You won't be able to restore shadows by slightly tweaking, unless you mean
>stop doing invert+rotate.
That's valid criticism and I have no solution to this. Is it a deal breaker (I
genuinely don't know)?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2480692337
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/issues/5328/2480692...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
