Merged, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5437#issuecomment-2598896243
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
Merged #5437 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5437#event-15980674827
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5508 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5508#event-15980663813
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5508#issuecomment-2598894180
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
Merged #5509 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5509#event-15980656428
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5509#issuecomment-2598893179
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
> what if we do `@user.soft_destroy!` inside `update` too?
OK, that sounds like a good compromise to me!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5437#issuecomment-2593753133
You are receiving this because you are subscribe
> As it stands this only works correctly for the transport layer that has a
> dark variant - for all other layers it disables the filtering when in dark
> mode.
I think it's important here to note that we decided in #5328 that only filters
approved by the cartographers should be applied. Since
I'm just coming back to this one, and perhaps there might be a way forward. The
[API docs
show](https://edgeapi.rubyonrails.org/classes/ActiveJob/Exceptions/ClassMethods.html#method-i-discard_on)
that `discard_on` can take a block, which allows us to access both the error
and the job. So could
> Looks like there is one feature in 2022 that is an issue for Safari 15 and
> the Chrome 87/92 outliers are also a bit more limited but of the rest is OK I
> think?
That's how I'm reading it too. I'm not sure why some people might be on those
old versions, my guess is that upgrades are blocked
Thank you @Yatharths11 for making your pull request to this project!
Unfortunately, as @hlfan has pointed out, it doesn't quite resolve the problem.
You need to change your code, as he describes.
Please feel free to either reopen this PR when you have made the fix, or you
could open a new PR in
Closed #4176.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4176#event-15940846844
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Closed #5361.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5361#event-15940890391
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
@kimberlymarkley Thank you for your PR!
I agree with @tomhughes, that the shadow is part of the accessibility needs for
keyboard navigation. And additionally, if we did decide to remove the shadow,
we would do so using the class approach, rather than custom CSS.
So I'm going to decline this PR,
Looks good to me. Merged, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5433#issuecomment-2592788092
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #5433 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5433#event-15940655180
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Since there's no other comments here, I'm happy to merge. We can always revisit
this if we find a different approach.
Thanks @AntonKhorev
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5449#issuecomment-2592768380
You are recei
Merged #5449 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5449#event-15940564235
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
There were more links in the translations of that page. I've updated all of the
translations today.
However, I've just found more pages, e.g.
https://wiki.openstreetmap.org/wiki/Ko:Beginners_Guide_1.2.2 that link to
either `create-account.html` or `forgot-password.html`. My personal feeling is
Merged #5501 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5501#event-15939081965
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
I think you can `update` the `status`, but you can't `destroy` the `status`.
You can `destroy` the `user`.
So I think refactoring the `set_status` is good but I think the destroy method
should stay in the same place.
--
Reply to this email directly or view it on GitHub:
https://github.com/open
Our system specs (and our teaspoon specs) don't work on Ubuntu, due to
incompatibilities with firefox snap. We should document that they don't work,
or we should document how to make them work, or (ideally) figure out if there's
a way to get them to work automatically.
The root of the problem i
> oops, sorry, my mistake, I didn't see the `.` ...
I feel your pain! erb_lint is unusual in that it doesn't have a default path.
Most of our linters (like rubocop) use `.` if no path is specified.
> I think a warning in CONTRIBUTING.md would be welcome for beginners like me!
I agree. There are
@gravitystorm commented on this pull request.
> +assert_redirected_to diary_entry_path(user, user.diary_entries.last)
entry = DiaryEntry.last
> Maybe if we use `assert_difference "DiaryEntry.count"`, we should also use
> `DiaryEntry.last` (or change `assert_difference`).
I've gone fo
@gravitystorm pushed 1 commit.
55e3f90dd47bd96970cd0d9e55fb56e70dd8cc75 Show diary entry after creation
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5484/files/5abd806909cc9624215a374520d55362886f7a15..55e3f90dd47bd96970cd0d9e55fb56e70dd8cc75
You are receivi
@gravitystorm pushed 1 commit.
14b33b9433244c34b8809fcbe6528a077b1709ad Restrict version of dry-schema for
ruby 3.1.2 compatibility
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5483/files/818d942ac60c9be99bf5693af8a17d49e39932c8..14b33b9433244c34b8809fcbe65
Merged, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5462#issuecomment-2578473041
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
Merged #5462 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5462#event-15858772960
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
I didn't spot this in #5357
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5486
-- Commit Summary --
* Update documentation to avoid erb_lint deprecations
-- File Changes --
M CONTRIBUTING.md (2)
-- Patch Li
> Does anyone need the `#show` page?
No, I guess not.
I've done a small amount of research into this, to see what other similar
applications do - just to see if there's any conventions. Github, Mastodon and
Discourse all show forms and don't appear to have a show/edit split. Mastodon
has its s
> Because the main tests are using Ubuntu,
"github-flavoured-ubuntu", i.e. they don't use the ubuntu ruby distribution
packages anyway. That's why we can use a matrix of ruby versions in CI. So they
are using 3.1.latest on both Ubuntu 22.04 and 24.04.
> Unfortunately the ruby lifecycle and the
> Why has this downgraded us all the way to `1.13.0` when we were on `1.13.4`
> before I updated yesterday?
Sorry, that's my mistake, related to the order I was testing things locally.
I've pushed an updated version.
--
Reply to this email directly or view it on GitHub:
https://github.com/open
@gravitystorm requested changes on this pull request.
Looks good to me, one small change in the tests.
I also appreciate the tests are slightly refactored, and this is an improvement.
> @@ -25,12 +25,12 @@ def test_terms_presented_at_login
assert_template "sessions/new"
post "/login",
@gravitystorm commented on this pull request.
> +assert_redirected_to diary_entry_path(user, user.diary_entries.last)
entry = DiaryEntry.last
Yes, I thought that too. I could refactor that as part of this PR, or
separately. Which would you prefer? (and do you have any preferences for
One option would be to keep the `#show` and `#edit` pages as they are now, but
to link directly to the `#edit` page from the menu. That way, if the user
presses refresh after a failed update, they will see the `#show` page.
--
Reply to this email directly or view it on GitHub:
https://github.c
This allows users to review their post and use the social share buttons more
easily.
Refs #1391
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5484
-- Commit Summary --
* Show diary entry after creation
-- File
I've made a PR which will resolve the immediate problem.
A better fix would be for debian to add the bugfix to their ruby version. Does
anyone know if debian ruby packagers are responsive to these kind of bug
reports? I'm surprised that they don't incorporate the patch versions
automatically (t
https://bugs.ruby-lang.org/issues/18673 affects some methods using anonymous
blocks, and was fixed in ruby 3.1.3. However, debian/bookworm ruby 3.1 package
is based on 3.1.2 and does not yet contain this fix.
Since bookworm is used in our Docker build, and also used in production by
OSMF, then
Almost certainly this commit in dry-schema is the trigger:
https://github.com/dry-rb/dry-schema/commit/e1a940f78695668eff3109c42ceec6cca7c89355
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5482#issuecomment-2577983658
You are
In
https://github.com/openstreetmap/openstreetmap-website/commit/045f0ac1bec2797b1e8f743d88d1a58687af24c7
we updated dry-schema from 1.13.4 to 1.14.0. We're now getting build failures
with the message:
```
SyntaxError:
/var/lib/gems/3.1.0/gems/dry-schema-1.14.0/lib/dry/schema/dsl.rb:185: no
a
I think so - I'm currently trying to narrow down which gem is causing this.
dry-schema is the most likely culprit at the moment.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/commit/045f0ac1bec2797b1e8f743d88d1a58687af24c7#commitcomm
Closed #5481 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5481#event-15851750135
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
As @HolgerJeromin says, the speed of zoom is controlled by Leaflet, so it's not
something we are going to fix here.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5481#issuecomment-2577331021
You are receiving this because you
Does the OSMF have any stats about what percentage of visitors to the website
this would affect? I'm assuming that there's going to a be a proportion of
people using browsers that don't support ECMAScript 2022 since that's only a
couple of years old.
My guess would include older Android device
Fixed by #5417
> We have enough unused code in helpers.
Yes, there's lots of other code to fix too, of course. We can work through each
thing you mention individually.
> I wish i was active at the time issue was raised to do it instead.
No worries, there's plenty more work for everyone!
--
Closed #5415 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5415#event-15715319200
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
Merged #5417 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5417#event-15715288240
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Thanks for the refactoring!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5417#issuecomment-2553357017
You are receiving this because you are subscribed to this thread.
Message ID:
__
Merged #5388 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5388#event-15705677103
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5388#issuecomment-2551713385
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
The implementation of render_social_share_buttons can be refactored in a number
of ways:
* `html_safe` **must not be used**. It does not convert strings to a safe
representation, it is an assertion that the string is always safe given every
possible input. This method is probably too complex fo
I think that using a popup window for the social sharing functionality isn't a
great user experience, but I would like to have a more detailed discussion
about the pros and cons.
In my mind, either one of these would be preferable:
* Links open in a new tab, or
* Use a [bootstrap modal
dialog](
Merged #5413 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5413#event-15704922466
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
I think this is unrelated to OAuth. I belive it's another way of asking for
non-db preferences, so I'm closing this in favour of #5324
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5407#issuecomment-2551569005
You are receivi
Merged, thanks
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5411#issuecomment-2551565358
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev m
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5413#issuecomment-2551593371
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
Merged thanks. Feels to me like some tests are missing from the original PR,
which might have caught this.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5412#issuecomment-2551563781
You are receiving this because you are subscri
This seems reasonable to me, but it's marked as a draft. Is there something
else that needs working on first, or is it just the merge conflicts now?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5388#issuecomment-2551501150
You
Merged #5411 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5411#event-15704766492
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5412 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5412#event-15704748998
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
> anonymous users
I think you mean users who are not logged in - "anonymous users" is the term we
use for accounts with `user.data_public == false`. They are quite rare now
since [they haven't been permitted for a long
time](https://wiki.openstreetmap.org/wiki/Anonymous_edits).
As for preferen
Closed #5407 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5407#event-15704788689
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
@gravitystorm requested changes on this pull request.
I'm very happy to see this work, thanks @hlfan!
The code looks fine to me, but I'm not a javascript expert so maybe there are
better ways to write parts.
Two other changes requested:
* Please rework your commits (e.g. using `git rebase -i`)
> What's the source(s) of all the javascript in `vendor/`?
OK, I found the answer for the cal-heatmap part of the code, which is available
as an npm module. In which case, using package.json will allow us to upgrade to
new versions automatically, and would be the preferred option.
--
Reply to
What's the source(s) of all the javascript in `vendor/`? I would expect to see
`Vendorfile` updated, or preferably if these are sourced from e.g. node
modules, then they should be included in package.json and added using the
assets pipeline. If any of these are source files, i.e. written just fo
Closed #5400 as completed via #5406.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5400#event-15683867907
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5406#issuecomment-2548108284
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
Merged #5406 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5406#event-15683867603
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
I should clarify here that this issue is "fixed" in that #5406 means the site
now won't return a 500 error for the OAuth login flow.
The read-only status on www.osm.org is still ongoing, and is a matter for the
OSMF OWG.
--
Reply to this email directly or view it on GitHub:
https://github.com/
Closed #5409 as not planned.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5409#event-15683850135
You are receiving this because you are subscribed to this thread.
Message ID:
___
r
> The next question is why?
I think I've answered this multiple times already. The cartographers should be
in charge of what should be shown for their maps in each desired mode. We
should not apply any filters unless the cartographers have asked for them.
That's "why".
> But of course the nega
> @gravitystorm Are you against setting map mode to light by default for now?
I'm not quite sure what you mean here. I'm against changing any default
preferences (they should remain `auto` by default), if that's what you are
asking.
Here's two tables that might help. The first shows how the "de
> Should the OpenCycleMap layer stay dimmed with reduced contrast as it
> currently is or should another filter (if any) be chosen to optimize the map
> for dark mode?
I'd prefer to see the OpenCycleMap layer displayed normally in dark mode (i.e.
with no filter) for now. I think either we will
> So we're moving from _let's have the map dark in some unspecified manner_ to
> _let's have the map not dark but still call it dark_ (by default when the
> browser reports dark color scheme preference). That's probably not what you
> want.
I want to see all filters removed from all map layers,
Closing this, since it was an alternative to #5339 / #5362 which is now merged.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5337#issuecomment-2536634839
You are receiving this because you are subscribed to this thread.
Message
Closed #5337.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5337#event-15622212025
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
See #5328 for background.
As the cartographer for the `transport` featured layer, I would like this
project to use the `transport-dark` variant when our maps are shown in dark
mode.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/iss
Some people are asking why this is taking a long time to fix, but from my own
side unfortunately personal circumstances have had a large part to play. Thank
you to everyone for you patience.
I haven't seen any substantial counter-proposal to my "option 4c" suggestion
("Cartographers choose") ea
Thanks @AntonKhorev , I think this works well.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5362#issuecomment-2536543710
You are receiving this because you are subscribed to this thread.
Message ID:
___
Merged #5339 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5339#event-15621756654
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5362 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5362#event-15621756178
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5390 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5390#event-15619240864
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5390#issuecomment-2536078545
You are receiving this because you are subscribed to this thread.
Message ID:
___
@JoeCelaster Please see [our Contributing
Guide](https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md#assigning-issues)
section "Assigning Issues".
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5
> Should cartographers have the choice to use a specific style _and_ a filter
> or is it an exclusive or? Because this would change how I would implement
> this choice.
I'm sorry, I don't understand your question.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstr
This allows us to enable output safety checks for all code within erb files.
`rubocop --auto-gen-config` ignores code within the erb files, so it is easier
to maintain an exclusion on the helper than inside the layout.
You can view, comment on, or merge this pull request online at:
https://gi
They have standardized on underscores. See
https://github.com/Shopify/erb_lint/pull/360
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5357
-- Commit Summary --
* Resolve erb_lint deprecations
-- File Changes --
> It wasn't created by another maintainer. Compare the dates of #4712 and #4911.
I don't think that matters, you're a maintainer now! :smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2504379378
You are
Merged, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4316#issuecomment-2504376554
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
Merged #4316 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4316#event-1541989
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #840 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/840#event-15455162268
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails
Implemented in
https://github.com/openstreetmap/openstreetmap-website/pull/5284,
https://github.com/openstreetmap/openstreetmap-website/pull/5304,
https://github.com/openstreetmap/openstreetmap-website/pull/5310,
https://github.com/openstreetmap/openstreetmap-website/pull/5314,
https://github.
I think if we both agree to add a new preference with 3 options, there's no
need to split that into different pull requests for each option! :smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5339#issuecomment-2504289732
You
> "let's make everyone have no filter until _the cartographers_ let them have
> some filter"?
Technically that depends on the discussion in #5328. It doesn't strictly matter
how dark mode maps are implemented, in order to have this preference available
and useful.
But yes, since my preference
I would prefer #5339
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5337#issuecomment-2504202626
You are receiving this because you are subscribed to this thread.
Message ID:
___
rail
I think the preference should have three options - auto (default), light and
dark. In auto mode, either the browser color-mode should be used, or if that's
not available, we should use light mode.
See
https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2504102012
fo
I've been asked why we can't merge either #5327 or #5340 to remove the darken
filter.
Normally, maintainers can merge any pull request that they are happy with, and
personally I'd be happy to merge these, since they both fit with my proposals
at
https://github.com/openstreetmap/openstreetmap-
I don't approve of this PR, because I believe the cartographers, not the
developers, should choose what their "dark mode maps" look like. See
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2488361637
--
Reply to this email directly or view it on GitHub:
https://
> Your original description of _Option 4b_ didn't include implementing
> preferences, it had "we shouldn't control those colours in dark mode", that's
> completely different now. It even looks like you agree to change this too:
> "We don't control what colours are used on the maps in light mode"
> can you move specific comments to a new issue about improving communication
> or would we have to start that from scratch again there? Does github have a
> feature like Discourse or just "mark as off-topic"?
No, we can't move comments to a new thread. So please everyone, stay on topic.
We're
1 - 100 of 189 matches
Mail list logo
