> As it stands this only works correctly for the transport layer that has a 
> dark variant - for all other layers it disables the filtering when in dark 
> mode.

I think it's important here to note that we decided in #5328 that only filters 
approved by the cartographers should be applied. Since currently no 
cartographers have chosen any filters, then it's expected that any existing 
filtering (e.g. `darken`) would be removed by default, until we hear back from 
some other cartographers.

@hlfan could you also work on the point that @tomhughes raised with regards to 
setting classes instead of using inline styles? 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5426#issuecomment-2593558235
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5426/c2593558...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to