@gravitystorm requested changes on this pull request.
Looks good to me, one small change in the tests.
I also appreciate the tests are slightly refactored, and this is an improvement.
> @@ -25,12 +25,12 @@ def test_terms_presented_at_login
assert_template "sessions/new"
post "/login", :params => { :username => user.email, :password => "test",
:referer => "/diary/new" }
# but now we need to look at the terms
- assert_redirected_to :controller => :users, :action => :terms, :referer =>
"/diary/new"
+ assert_redirected_to "/account/terms?#{{ :referer => '/diary/new'
}.to_query}"
```ruby
assert_redirected_to account_terms_path(:referer => "/diary/new")
```
... is a bit easier to read
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5462#pullrequestreview-2537851315
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5462/review/2537851...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
