Re: [Qemu-devel] [PATCH] tcg-optimize: Fold sub r,0,x to neg r,x

2013-02-23 Thread Blue Swirl
On Tue, Feb 19, 2013 at 7:03 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/optimize.c | 33 - > 1 file changed, 32 insertions(+), 1 deletion(-) > > I noticed this while looking at other dumps. This seems like it > should be considere

Re: [Qemu-devel] [PATCH 11/38] target-i386: Use mulu2 and muls2

2013-02-23 Thread Blue Swirl
Applying: target-i386: Use mulu2 and muls2 error: patch failed: target-i386/helper.h:14 error: target-i386/helper.h: patch does not apply error: patch failed: target-i386/int_helper.c:374 error: target-i386/int_helper.c: patch does not apply error: patch failed: target-i386/translate.c:4111 error:

Re: [Qemu-devel] [PATCH] xhci: fix bad print specifier

2013-02-23 Thread Blue Swirl
Thanks, applied. On Thu, Feb 21, 2013 at 9:58 PM, Hervé Poussineau wrote: > This fixes the following compilation error: > hw/usb/hcd-xhci.c:1156:17: error: format ‘%llx’ expects argument of type > ‘long long unsigned int’, but argument 4 has type ‘unsigned int’ > > Signed-off-by: Hervé Poussineau

Re: [Qemu-devel] [PATCH V2 0/4] Misc Leon3 fixes

2013-02-23 Thread Blue Swirl
Thanks, applied all. On Tue, Feb 19, 2013 at 4:22 PM, Fabien Chouteau wrote: > V2: > - Put the typo fix (gptimer -> apbuart) in a separate patch. > > Fabien Chouteau (1): > Typo: replace gptimer by apbuart > > Ronald Hecht (3): > grlib-apbuart: Add support of various flags > Added LEON MM

Re: [Qemu-devel] [PATCH v2 14/15] target-sparc: Refactor debug output macros

2013-02-23 Thread Blue Swirl
; Inline DEBUG_{MXCC,ASI} in ldst_helper.c. > > Signed-off-by: Andreas Färber Acked-by: Blue Swirl > --- > target-sparc/cpu.c | 38 +--- > target-sparc/ldst_helper.c | 221 > +++- > 2 Dateien geändert, 158 Zeilen hinz

Re: [Qemu-devel] [PATCH v2] Replace all setjmp()/longjmp() with sigsetjmp()/siglongjmp()

2013-02-23 Thread Blue Swirl
Actually I applied this and not v1, sorry for the confusion. On Wed, Feb 20, 2013 at 3:21 PM, Peter Maydell wrote: > The setjmp() function doesn't specify whether signal masks are saved and > restored; on Linux they are not, but on BSD (including MacOSX) they are. > We want to have consistent beh

Re: [Qemu-devel] [PATCH] qemu-log: Remove qemu_log_try_set_file() and its users

2013-02-23 Thread Blue Swirl
On Mon, Feb 18, 2013 at 11:36 AM, Peter Maydell wrote: > On 16 February 2013 13:52, Blue Swirl wrote: >> On Tue, Feb 12, 2013 at 4:13 PM, Peter Maydell >> wrote: >>> Remove the function qemu_log_try_set_file() and its users (which >>> are all in TCG code

Re: [Qemu-devel] [PATCH] disas/i386.c: Add explicit braces round empty for-loop body

2013-02-23 Thread Blue Swirl
Thanks, applied. On Sat, Feb 2, 2013 at 5:17 PM, Peter Maydell wrote: > Add explicit braces round an empty for-loop body; this fits > QEMU style and is easier to read than an inconspicuous semicolon > at the end of the line. It also silences a clang warning: > > disas/i386.c:4723:49: warning: for

Re: [Qemu-devel] [PATCH v2] ui/vnc: VA API based H.264 encoding for VNC

2013-02-23 Thread Blue Swirl
On Fri, Feb 22, 2013 at 2:31 PM, Verbeiren, David wrote: > On Wed, Feb 13, 2013 at 22:16, Blue Swirl wrote: >>> +/* RGBA => NV12 */ >>> +for (i = 0; i < h264->pic_height; ++i) { >>> +dst_y = (pdst + image.offsets[0]) + i*image.pitche

Re: [Qemu-devel] [PATCH] Replace all setjmp()/longjmp() with sigsetjmp()/siglongjmp()

2013-02-23 Thread Blue Swirl
Thanks, applied. On Sun, Feb 17, 2013 at 2:44 PM, Peter Maydell wrote: > The setjmp() function doesn't specify whether signal masks are saved and > restored; on Linux they are not, but on BSD (including MacOSX) they are. > QEMU never wants to save and restore signal masks, because it uses threads

Re: [Qemu-devel] [PATCH 00/38] Add double-word addition and widening multiply tcg ops

2013-02-23 Thread Blue Swirl
Thanks, applied all. On Wed, Feb 20, 2013 at 7:51 AM, Richard Henderson wrote: > ... and use them where appropriate in the targets. As can be seen, > most targets can make use of a widening multiply. And if one is > sufficiently clever, one can use add2 to significantly improve carry > generati

Re: [Qemu-devel] [PATCH 00/57] target-i386 eflags cleanup and bmi/adx extensions

2013-02-23 Thread Blue Swirl
Thanks, applied. On Thu, Jan 24, 2013 at 4:02 AM, Richard Henderson wrote: > This is a re-working of Paolo's eflags cleanup from October, which > I consider a pre-requisite to implementing the ADX extension. I've > rearranged most of the patches in trivial ways, and some quite > significantly. >

Re: [Qemu-devel] [PATCH] target-i386: Use mulu2 and muls2

2013-02-27 Thread Blue Swirl
Thanks, applied. On Tue, Feb 26, 2013 at 8:06 PM, Richard Henderson wrote: > These correspond very closely to the insns that we're emulating. > > Signed-off-by: Richard Henderson > --- > target-i386/helper.h | 4 -- > target-i386/int_helper.c | 40 > target-i386/translate.c

[Qemu-devel] [PATCH] tcg-sparc: fix build

2013-02-27 Thread Blue Swirl
Fix build breakage by 803d805bcef4ea7b7d6ef0b4929263e1160d6b3c: make tcg_out_addsub2() always available. Signed-off-by: Blue Swirl --- tcg/sparc/tcg-target.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index 6d489fc

Re: [Qemu-devel] [PATCH] check-qjson: More thorough testing of UTF-8 in strings

2013-02-27 Thread Blue Swirl
On Mon, Feb 4, 2013 at 5:19 PM, Markus Armbruster wrote: > Test cases are scraped from Markus Kuhn's UTF-8 decoder capability and > stress test at > http://www.cl.cam.ac.uk/~mgk25/ucs/examples/UTF-8-test.txt > > Unfortunately, both JSON parser and formatter misbehave right now. > This test expects

Re: [Qemu-devel] [RfC PATCH] vga: add mmio bar to standard vga

2012-09-19 Thread Blue Swirl
On Tue, Sep 18, 2012 at 9:51 AM, Gerd Hoffmann wrote: > This patch adds a mmio bar to the qemu standard vga which allows to > access the standard vga registers and bochs dispi interface registers > via mmio. > > Cc: Benjamin Herrenschmidt > Signed-off-by: Gerd Hoffmann > --- > hw/vga-pci.c |

Re: [Qemu-devel] [RFC PATCH 10/16] qcow2: Delay the COW

2012-09-19 Thread Blue Swirl
On Tue, Sep 18, 2012 at 11:40 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/qcow2-cluster.c | 29 + > block/qcow2.c | 31 --- > block/qcow2.h | 10 ++ > 3 files changed, 67 insertions(+), 3 de

Re: [Qemu-devel] [PATCH] Added more entries to the LEON processor configuration register

2012-09-19 Thread Blue Swirl
On Tue, Sep 18, 2012 at 1:29 PM, Ronald Hecht wrote: > Signed-off-by: Ronald Hecht > --- > target-sparc/helper.h |1 + > target-sparc/ldst_helper.c |6 ++ > target-sparc/translate.c | 10 +++--- > 3 files changed, 10 insertions(+), 7 deletions(-) > > diff --git a/target-

Re: [Qemu-devel] [PATCH 0/5] tcg: movcond

2012-09-19 Thread Blue Swirl
On Tue, Sep 18, 2012 at 9:11 PM, Aurelien Jarno wrote: > On Tue, Sep 18, 2012 at 07:23:55AM -0700, Richard Henderson wrote: >> As recently discussed, with the optional fallback to setcond. >> >> I include a patch to target-alpha to test correctness both >> before and after implementing the opcode

Re: [Qemu-devel] [PATCH RFC] hw/grlib: SMP support added to LEON interrupt controller

2012-09-19 Thread Blue Swirl
On Wed, Sep 19, 2012 at 3:30 PM, Ronald Hecht wrote: > This patch adds SMP support to the LEON SPARC interrupt controller. > I don't like that CPU status (halted/not halted) is accessed directly > from the interrupt controller. How can this be implemented more elegant? > Ideally the CPUSPARCState

Re: [Qemu-devel] [PATCH 04/12] qapi: add "unix" to the set of reserved words

2012-09-19 Thread Blue Swirl
On Wed, Sep 19, 2012 at 4:02 PM, Paolo Bonzini wrote: > Il 19/09/2012 17:58, Paolo Bonzini ha scritto: >> Il 19/09/2012 17:46, Peter Maydell ha scritto: >>> On 19 September 2012 15:31, Paolo Bonzini wrote: It is #defined to 1. Signed-off-by: Paolo Bonzini --- scripts/qa

Re: [Qemu-devel] directory hierarchy

2012-09-19 Thread Blue Swirl
On Wed, Sep 19, 2012 at 12:54 PM, Avi Kivity wrote: > On 09/14/2012 10:51 PM, Blue Swirl wrote: >>> >>> exec: >> >> These files need cleanup so that TCG code gets into tcg/. Maybe also >> TB and CPUTLB handling. > > Some of that could be done by addin

Re: [Qemu-devel] [PATCH] linux-user: Add naive implementation of capget() syscall

2012-09-22 Thread Blue Swirl
On Wed, Sep 19, 2012 at 3:09 PM, Karol Lewandowski wrote: > libcap, library used to manipulate posix file capabilities uses > getcap() to query version of capabilities supported by running > kernel. Information obtained from this syscall is then used to > initialize data structures that can be use

Re: [Qemu-devel] [PATCH v6 08/13] m25p80: Initial implementation of SPI flash device

2012-09-22 Thread Blue Swirl
On Thu, Sep 20, 2012 at 1:37 AM, Peter Crosthwaite wrote: > On Thu, Sep 20, 2012 at 4:25 AM, Blue Swirl wrote: >> On Tue, Sep 18, 2012 at 2:11 AM, Peter A. G. Crosthwaite >>> +int64_t dirty_page; >>> + >>> +uint64_t waddr; >>> +int

Re: [Qemu-devel] [RfC PATCH] vga: add mmio bar to standard vga

2012-09-22 Thread Blue Swirl
On Thu, Sep 20, 2012 at 5:43 AM, Gerd Hoffmann wrote: > Hi, > >>> +vbe_ioport_write_index(&d->vga, 0, index); >>> +return vbe_ioport_read_data(&d->vga, 0); >> >> These functions are only available with CONFIG_BOCHS_VBE #defined, so >> this code should be conditional as well. >> >> But bu

Re: [Qemu-devel] [PATCH] Added more entries to the LEON processor configuration register

2012-09-22 Thread Blue Swirl
On Thu, Sep 20, 2012 at 7:15 AM, Ronald Hecht wrote: > On 09/19/2012 08:56 PM, Blue Swirl wrote: >>> >>> --- a/target-sparc/translate.c >>> +++ b/target-sparc/translate.c >>> @@ -2590,13 +2590,9 @@ static void disas_sparc_insn(D

Re: [Qemu-devel] [PATCH RFC] hw/grlib: SMP support added to LEON interrupt controller

2012-09-22 Thread Blue Swirl
On Thu, Sep 20, 2012 at 7:27 AM, Ronald Hecht wrote: > On 09/19/2012 09:19 PM, Blue Swirl wrote: >> >> On Wed, Sep 19, 2012 at 3:30 PM, Ronald Hecht wrote: >> >>> >>> This patch adds SMP support to the LEON SPARC interrupt controller. >>> I d

Re: [Qemu-devel] directory hierarchy

2012-09-22 Thread Blue Swirl
On Thu, Sep 20, 2012 at 11:31 AM, Avi Kivity wrote: > On 09/19/2012 10:57 PM, Blue Swirl wrote: >> On Wed, Sep 19, 2012 at 12:54 PM, Avi Kivity wrote: >>> On 09/14/2012 10:51 PM, Blue Swirl wrote: >>>>> >>>>> exec: >>>> >>>&

Re: [Qemu-devel] [PATCH] ehci: Fix interrupt packet MULT handling

2012-09-22 Thread Blue Swirl
On Thu, Sep 20, 2012 at 3:38 PM, Hans de Goede wrote: > There are several issues with our handling of the MULT epcap field > of interrupt qhs, which this patch fixes. > > 1) When we don't execute a transaction because of the transaction counter > being 0, p->async stays EHCI_ASYNC_NONE, and the ne

Re: [Qemu-devel] [PATCH v5 00/17] Allow changing of Hypervisor CPUIDs.

2012-09-22 Thread Blue Swirl
On Sat, Sep 22, 2012 at 12:13 AM, Don Slutz wrote: > Also known as Paravirtualization CPUIDs. > > This is primarily done so that the guest will think it is running > under vmware when hypervisor-vendor=vmware is specified as a > property of a cpu. Please use checkpatch.pl to check for missing bra

Re: [Qemu-devel] [Qemu-ppc] RFC: NVRAM for pseries machine

2012-09-22 Thread Blue Swirl
On Fri, Sep 21, 2012 at 3:08 AM, David Gibson wrote: > Below is a patch which implements the (PAPR mandated) NVRAM for the > pseries machine. It raises a couple of generic questions. > > First, this adds a new "nvram" machine option which is used to give a > block device id to back the NVRAM so i

Re: [Qemu-devel] [RFC PATCH v3 06/19] Implement "-dimm" command line option

2012-09-22 Thread Blue Swirl
On Fri, Sep 21, 2012 at 11:17 AM, Vasilis Liaskovitis wrote: > Example: > "-dimm id=dimm0,size=512M,node=0,populated=off" There should not be a need to introduce a new top level option, instead you should just use -device, like -device dimm,base=0,id=dimm0,size=512M,node=0,populated=off That wou

Re: [Qemu-devel] [RFC PATCH v3 07/19] acpi_piix4: Implement memory device hotplug registers

2012-09-22 Thread Blue Swirl
On Fri, Sep 21, 2012 at 11:17 AM, Vasilis Liaskovitis wrote: > A 32-byte register is used to present up to 256 hotplug-able memory devices > to BIOS and OSPM. Hot-add and hot-remove functions trigger an ACPI hotplug > event through these. Only reads are allowed from these registers. > > An ACPI ho

Re: [Qemu-devel] [RFC PATCH v3 08/19] pc: calculate dimm physical addresses and adjust memory map

2012-09-22 Thread Blue Swirl
On Fri, Sep 21, 2012 at 11:17 AM, Vasilis Liaskovitis wrote: > Dimm physical address offsets are calculated automatically and memory map is > adjusted accordingly. If a DIMM can fit before the PCI_HOLE_START (currently > 0xe000), it will be added normally, otherwise its physical address will b

Re: [Qemu-devel] [RFC PATCH v3 00/19] ACPI memory hotplug

2012-09-22 Thread Blue Swirl
On Fri, Sep 21, 2012 at 11:17 AM, Vasilis Liaskovitis wrote: > This is v3 of the ACPI memory hotplug functionality. Only x86_64 target is > supported > for now. > > Overview: > > Dimm device layout is modeled with a new qemu command line > > "-dimm id=name,size=sz,node=pxm,populated=on|off" > > T

Re: [Qemu-devel] [Qemu-ppc] RFC: NVRAM for pseries machine

2012-09-22 Thread Blue Swirl
On Sat, Sep 22, 2012 at 2:16 PM, Alexander Graf wrote: > > > On 22.09.2012, at 15:31, Blue Swirl wrote: > >> On Fri, Sep 21, 2012 at 3:08 AM, David Gibson >> wrote: >>> Below is a patch which implements the (PAPR mandated) NVRAM for the >>> pseri

Re: [Qemu-devel] [PATCH v2] Add infrastructure for QIDL-based device serialization

2012-09-22 Thread Blue Swirl
On Fri, Sep 21, 2012 at 4:24 PM, Michael Roth wrote: > On Fri, Sep 21, 2012 at 05:57:42PM +0200, Paolo Bonzini wrote: >> Il 21/09/2012 16:07, Michael Roth ha scritto: >> > >> > QIDL_DECLARE(SerialDevice) { >> > SysBusDevice parent; >> > >> > uint8_t thr; /* transmi

Re: [Qemu-devel] [PATCH 05/10] tcg/mips: use stack for TCG temps

2012-09-22 Thread Blue Swirl
On Fri, Sep 21, 2012 at 4:43 PM, Aurelien Jarno wrote: > Use stack instead of temp_buf array in CPUState for TCG > temps. > > Signed-off-by: Aurelien Jarno > --- > tcg/mips/tcg-target.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/tcg/mips/tcg-target.c b/

Re: [Qemu-devel] [PATCH v2 0/7] tcg: movcond (ppc32 version)

2012-09-22 Thread Blue Swirl
On Fri, Sep 21, 2012 at 8:10 PM, malc wrote: > diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c > index 26c4b33..0fb6fc7 100644 > --- a/tcg/ppc/tcg-target.c > +++ b/tcg/ppc/tcg-target.c > @@ -390,6 +390,7 @@ static int tcg_target_const_match(tcg_target_long val, > #define ORCXO31(412)

Re: [Qemu-devel] [PATCH v2 10/10] tcg/optimize: add constant folding for deposit

2012-09-22 Thread Blue Swirl
On Sat, Sep 22, 2012 at 9:41 AM, Aurelien Jarno wrote: > On Fri, Sep 21, 2012 at 04:22:53PM -0700, Richard Henderson wrote: >> On 09/21/2012 12:43 PM, Aurelien Jarno wrote: >> > +tmp = ((1ull << args[4]) - 1); >> > +tmp = (temps[args[1]].val & ~(tmp << args[3])) >>

Re: [Qemu-devel] [RFC v2 2/2] target-arm: Add support for Cortex-R4F

2012-09-22 Thread Blue Swirl
On Sat, Sep 22, 2012 at 11:45 AM, Andreas Färber wrote: > With QOM ARMCPU we can now distinguish between -cpu cortex-r4 and > -cpu cortex-r4f despite identical MIDR. > > Signed-off-by: Andreas Färber > --- > target-arm/cpu.c | 47 +++ > 1 Datei geänd

Re: [Qemu-devel] [PATCH v3 00/10] target-xtensa: implement FP coprocessor option

2012-09-22 Thread Blue Swirl
On Wed, Sep 19, 2012 at 12:23 AM, Max Filippov wrote: > This series implements floating point coprocessor and coprocessor context > options for xtensa and fixes a couple of bugs to make it work. Thanks, applied all. > > Changes v2->v3: > - add comment to the NO_SIGNALING_NANS definition > - rewo

Re: [Qemu-devel] [PATCH 05/10] tcg/mips: use stack for TCG temps

2012-09-22 Thread Blue Swirl
On Sat, Sep 22, 2012 at 5:25 PM, Aurelien Jarno wrote: > On Sat, Sep 22, 2012 at 02:37:35PM +0000, Blue Swirl wrote: >> On Fri, Sep 21, 2012 at 4:43 PM, Aurelien Jarno wrote: >> > Use stack instead of temp_buf array in CPUState for TCG >> > temps. >> >

Re: [Qemu-devel] [PATCH v3 00/14] Sparc TCG cleanup

2012-09-22 Thread Blue Swirl
On Sat, Sep 22, 2012 at 2:04 AM, Richard Henderson wrote: > Changes since v2: > * Patch 4 split out from patch 5 (afaerber feedback) > * TB chaining preserves wrt retranslation > * Last patch for branch retranslation is new > > The patch set is rebased on cfb75cb9807463ebe18b127096b48b5d0db1

Re: [Qemu-devel] [PATCH] net/socket: Fix compiler warning (regression for MinGW)

2012-09-22 Thread Blue Swirl
On Sat, Sep 22, 2012 at 6:17 PM, Stefan Weil wrote: > Am 22.09.2012 20:01, schrieb Michael Tokarev: > >> On 22.09.2012 20:32, Stefan Hajnoczi wrote: >>> >>> On Thu, Sep 20, 2012 at 09:32:19PM +0200, Stefan Weil wrote: Add a type cast which was removed by commit 213fd5087e2e4e2da10ad

Re: [Qemu-devel] [PATCH] w32: Add implementation of gmtime_r, localtime_r

2012-09-23 Thread Blue Swirl
On Sat, Sep 22, 2012 at 8:26 PM, Stefan Weil wrote: > Those functions are missing in MinGW. > > Some versions of MinGW-w64 include defines for gmtime_r and localtime_r. > Older versions of these macros are buggy (they return a pointer to a > static variable), therefore we don't want them. Newer ve

Re: [Qemu-devel] [PATCH] linux-user: Add naive implementation of capget() syscall

2012-09-23 Thread Blue Swirl
On Sat, Sep 22, 2012 at 11:23 PM, Erik de Castro Lopo wrote: > Blue Swirl wrote: > >> This is not correct. The structure needs to be converted field by >> field to host native format, especially endianness. > > I'm working in a similar syscall implementation (POSI

Re: [Qemu-devel] directory hierarchy

2012-09-23 Thread Blue Swirl
On Sun, Sep 23, 2012 at 8:25 AM, Avi Kivity wrote: > On 09/22/2012 04:15 PM, Blue Swirl wrote: >> > >> >> This could have nice cleanup effects though and for example enable >> >> generic 'info vmtree' to discover VA->PA mappings for any

[Qemu-devel] [PATCH] gic: avoid a warning from clang

2012-09-23 Thread Blue Swirl
ield 'pending' is effectively 8 bits wide, so the masking has no effect except for avoiding the warning. Signed-off-by: Blue Swirl --- hw/arm_gic_internal.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/arm_gic_internal.h b/hw/arm_gic_internal.h index db4fa

Re: [Qemu-devel] [PATCH] w32: Add implementation of gmtime_r, localtime_r

2012-09-23 Thread Blue Swirl
On Sun, Sep 23, 2012 at 4:27 PM, Stefan Weil wrote: >> On Sat, Sep 22, 2012 at 8:26 PM, Stefan Weil wrote: >>> Those functions are missing in MinGW. >>> >>> Some versions of MinGW-w64 include defines for gmtime_r and localtime_r. >>> Older versions of these macros are buggy (they return a pointer

Re: [Qemu-devel] [PATCH] w32: Add implementation of gmtime_r, localtime_r

2012-09-23 Thread Blue Swirl
On Sat, Sep 22, 2012 at 8:26 PM, Stefan Weil wrote: > Those functions are missing in MinGW. > > Some versions of MinGW-w64 include defines for gmtime_r and localtime_r. > Older versions of these macros are buggy (they return a pointer to a > static variable), therefore we don't want them. Newer ve

Re: [Qemu-devel] [RFC PATCH v3 06/19] Implement "-dimm" command line option

2012-09-29 Thread Blue Swirl
On Mon, Sep 24, 2012 at 10:42 AM, Vasilis Liaskovitis wrote: > On Sat, Sep 22, 2012 at 01:46:57PM +0000, Blue Swirl wrote: >> On Fri, Sep 21, 2012 at 11:17 AM, Vasilis Liaskovitis >> wrote: >> > Example: >> > "-dimm id=dimm0,size=512M,node=0,populated=of

Re: [Qemu-devel] [PATCH] gic: avoid a warning from clang

2012-09-29 Thread Blue Swirl
On Mon, Sep 24, 2012 at 2:56 PM, Peter Maydell wrote: > On 24 September 2012 14:22, Peter Maydell wrote: >> On 23 September 2012 17:33, Blue Swirl wrote: >>> Avoid this warning: >>> CCarm-softmmu/hw/arm/../arm_gic.o >>> /src/qemu/hw/arm/../arm_gic.c:432

Re: [Qemu-devel] [RFC PATCH v3 08/19] pc: calculate dimm physical addresses and adjust memory map

2012-09-29 Thread Blue Swirl
On Mon, Sep 24, 2012 at 3:27 PM, Vasilis Liaskovitis wrote: > On Sat, Sep 22, 2012 at 02:15:28PM +0000, Blue Swirl wrote: >> > + >> > +/* Function to configure memory offsets of hotpluggable dimms */ >> > + >> > +target_phys_addr_

Re: [Qemu-devel] [PATCH 09/17] aio: prepare for introducing GSource-based dispatch

2012-09-29 Thread Blue Swirl
On Tue, Sep 25, 2012 at 12:55 PM, Paolo Bonzini wrote: > This adds a GPollFD to each AioHandler. It will then be possible to > attach these GPollFDs to a GSource, and from there to the main loop. > aio_wait examines the GPollFDs and avoids calling select() if any > is set (similar to what it does

Re: [Qemu-devel] [PATCH 1/6] savevm: Add VMSTATE_UINT64_EQUAL helpers

2012-09-29 Thread Blue Swirl
On Wed, Sep 26, 2012 at 3:21 AM, David Gibson wrote: > The savevm code already includes a number of *_EQUAL helpers which act as > sanity checks verifying that the configuration of the saved state matches > that of the machine we're loading into to work. Variants already exist > for 8 bit 16 bit

Re: [Qemu-devel] [PATCH v2 3/4] serial: add windows inf file for the pci card to docs

2012-09-29 Thread Blue Swirl
On Wed, Sep 26, 2012 at 12:14 PM, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > docs/qemupciserial.inf | 107 > > 1 files changed, 107 insertions(+), 0 deletions(-) > create mode 100644 docs/qemupciserial.inf > > diff --git a/docs

Re: [Qemu-devel] [PATCH v4] Align PCI capabilities in pci_find_space

2012-09-29 Thread Blue Swirl
On Wed, Sep 26, 2012 at 6:51 PM, Matt Renzelmann wrote: > The current implementation of pci_find_space does not correctly align > PCI capabilities in the PCI configuration space. It also does not > support PCI-Express devices. This patch fixes these issues. > > Thanks to Alex Williamson for feed

Re: [Qemu-devel] [Qemu-ppc] RFC: NVRAM for pseries machine

2012-09-29 Thread Blue Swirl
On Wed, Sep 26, 2012 at 8:51 PM, Alexander Graf wrote: > > > On 26.09.2012, at 22:03, Anthony Liguori wrote: > >> Alexander Graf writes: >> >>> On 22.09.2012, at 15:31, Blue Swirl wrote: >>> >>>> On Fri, Sep 21, 2012 at 3:08 AM, David Gibso

Re: [Qemu-devel] [PATCH] CODING_STYLE: Define how to handle acronyms in CamelCase

2012-09-29 Thread Blue Swirl
On Wed, Sep 26, 2012 at 9:59 PM, Anthony Liguori wrote: > Alex Williamson writes: > >> When creating structure names in CamelCase, it's easy to have >> back-to-back capitals when using acronyms (ex. PCIINTxRoutingNotifier, >> QEMUSGList, VFIOINTx). In the worst case these can look like macros, >

Re: [Qemu-devel] [PATCH] gic: avoid a warning from clang

2012-09-29 Thread Blue Swirl
On Sat, Sep 29, 2012 at 11:44 AM, Peter Maydell wrote: > On 29 September 2012 12:25, Blue Swirl wrote: >> On Mon, Sep 24, 2012 at 2:56 PM, Peter Maydell >> wrote: >>> On 24 September 2012 14:22, Peter Maydell wrote: >>>> On 23 September 2012 17:33, Blue Sw

Re: [Qemu-devel] [PATCH 07/12] tcg-sparc: Use Z constraint for %g0

2012-09-29 Thread Blue Swirl
On Thu, Sep 27, 2012 at 1:55 AM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/sparc/tcg-target.c | 109 > ++--- > tcg/sparc/tcg-target.h | 5 ++- > 2 files changed, 60 insertions(+), 54 deletions(-) > > diff --git a/tcg/sp

Re: [Qemu-devel] [PATCH 09/12] tcg-sparc: Drop use of Bicc in favor of BPcc

2012-09-29 Thread Blue Swirl
On Thu, Sep 27, 2012 at 1:55 AM, Richard Henderson wrote: > Now that we're always sparcv9, we can not bother using Bicc for > 32-bit branches and BPcc for 64-bit branches and instead always > use BPcc. But then the branch range is smaller (19 bits). The code buffer is 32M, wouldn't we use BPcc fo

Re: [Qemu-devel] [Qemu-ppc] RFC: NVRAM for pseries machine

2012-09-29 Thread Blue Swirl
On Sat, Sep 29, 2012 at 12:54 PM, Alexander Graf wrote: > > > On 29.09.2012, at 13:46, Blue Swirl wrote: > >> On Wed, Sep 26, 2012 at 8:51 PM, Alexander Graf wrote: >>> >>> >>> On 26.09.2012, at 22:03, Anthony Liguori wrote: >>> >>&

Re: [Qemu-devel] [PATCH 2/7] tcg: Optimize add2 + sub2

2012-09-30 Thread Blue Swirl
On Thu, Sep 27, 2012 at 5:19 PM, Richard Henderson wrote: > We can't do complete constant folding because we lack "mov2", > or the ability to insert opcodes in the stream. But we can > at least canonicalize add2 operand ordering and simplify > add2 to add when the lowpart adds a constant 0. Coul

Re: [Qemu-devel] instruction execution permission

2012-09-30 Thread Blue Swirl
On Sun, Sep 30, 2012 at 4:06 AM, Xin Tong wrote: > In QEMU x86, is a basicblock is translated with CPL of 0, can the > translation block be executed in CPL of 3 ? TB flags are defined by cpu_get_tb_cpu_state(), you can find the x86 version in target-i386/cpu.h. > > Xin >

Re: [Qemu-devel] [big lock] Discussion about the convention of device's DMA each other after breaking down biglock

2012-09-30 Thread Blue Swirl
On Sun, Sep 30, 2012 at 8:13 AM, Avi Kivity wrote: > On 09/29/2012 11:20 AM, liu ping fan wrote: >> >> Do we have iommus in qemu now, > > We do, but they're hacked into the scsi layer, see hw/sun4m_iommu.c. I > don't know if it's a standalone iommu on real hardware or whether it is > part of the

Re: [Qemu-devel] [big lock] Discussion about the convention of device's DMA each other after breaking down biglock

2012-09-30 Thread Blue Swirl
On Sun, Sep 30, 2012 at 11:17 AM, Avi Kivity wrote: > On 09/30/2012 01:04 PM, Blue Swirl wrote: >> On Sun, Sep 30, 2012 at 8:13 AM, Avi Kivity wrote: >>> On 09/29/2012 11:20 AM, liu ping fan wrote: >>>> >>>> Do we have iommus in qemu now, >>>

Re: [Qemu-devel] [PATCH 18/22] target-i386: parse cpu_model string into set of stringified properties

2012-09-30 Thread Blue Swirl
On Wed, Sep 26, 2012 at 8:32 PM, Igor Mammedov wrote: > cpu_model string does represent features in following format: > ([+-]feat)|(feat=foo)|(feat) > which makes it impossible directly use property infrastructure > to set features on CPU. > This patch introduces parser that splits CPU name from

Re: [Qemu-devel] [PATCH 0/5] i386: cpu: remove duplicate feature names

2012-09-30 Thread Blue Swirl
On Thu, Sep 6, 2012 at 8:05 PM, Eduardo Habkost wrote: > The problem: > > - Some features are report at the same time on both CPUID[1].EDX and >CPUID[8000_0001].EDX on AMD CPUs (e.g. fpu, tsc, msr, pae, mmx). > - "-cpu ,+feature" should enable the bit only on CPUID[1] if >it's not an AMD

Re: [Qemu-devel] [PATCH] esp: On qemu-system-sparc's esp, TC is not set properly

2012-09-30 Thread Blue Swirl
On Tue, Sep 25, 2012 at 6:15 PM, Ryo ONODERA wrote: > Hi, > > From: Ryo ONODERA , Date: Wed, 26 Sep 2012 02:44:35 +0900 > >> I does not understand hw/esp.c fully. >> This patch supresses esp/TC related errors on NetBSD/sparc 5.1.2 or 6.0_RC2. >> >> Please review the patch. >> >> This is patch for

Re: [Qemu-devel] [PATCH] kvm: Set default accelerator to "kvm" if the host supports it

2012-10-03 Thread Blue Swirl
On Mon, Oct 1, 2012 at 4:20 PM, Anthony Liguori wrote: > Jan Kiszka writes: > >> If we built a target for a host that supports KVM in principle, set the >> default accelerator to KVM as well. This also means the start of QEMU >> will fail to start if KVM support turns out to be unavailable at >>

Re: [Qemu-devel] [PATCH] tcg: remove obsolete jmp op

2012-10-03 Thread Blue Swirl
: Andrzej Zaborowski > Cc: Richard Henderson > Cc: Vassili Karpov (malc) > Cc: Alexander Graf > Cc: Blue Swirl Acked-by: Blue Swirl > Cc: Stefan Weil > Signed-off-by: Aurelien Jarno > --- > tcg/README |7 +-- > tcg/arm/tcg-target.c |7 -

Re: [Qemu-devel] [PATCH 1/5] s390: use sync regs for register transfer

2012-10-03 Thread Blue Swirl
On Tue, Oct 2, 2012 at 7:33 AM, Jens Freimann wrote: > From: Christian Borntraeger > > Newer kernels provide the guest registers in kvm_run. Lets use > those if available (i.e. the capability is set). This avoids > ioctls on cpu_synchronize_state making intercepts faster. > > In addition, we have

Re: [Qemu-devel] [PATCH 18/22] target-i386: parse cpu_model string into set of stringified properties

2012-10-03 Thread Blue Swirl
On Tue, Oct 2, 2012 at 11:28 AM, Eric Blake wrote: > On 09/30/2012 06:16 AM, Blue Swirl wrote: >> On Wed, Sep 26, 2012 at 8:32 PM, Igor Mammedov wrote: >>> cpu_model string does represent features in following format: >>> ([+-]feat)|(feat=foo)|(feat) >>> wh

Re: [Qemu-devel] [RFC 17/18] target-i386: topology & APIC ID utility functions (v2)

2012-10-03 Thread Blue Swirl
case x2APIC is going to be used) > - Coding style changes > - Use TARGET_I386_TOPOLOGY_H instead of __QEMU_X86_TOPOLOGY_H__ > - Rename topo_make_apic_id() to topo_apicid_for_cpu() > - Rename __make_apicid() to topo_make_apicid() > - Spaces around operators on test-x86-cpuid.c,

Re: [Qemu-devel] [RFC v1 03/22] kvm: use separate MemoryListeners for memory and I/O

2012-10-03 Thread Blue Swirl
On Wed, Oct 3, 2012 at 4:03 PM, Avi Kivity wrote: > The construct > >if (address_space == get_system_memory()) { >// memory thing >} else { >// io thing >} > > fails if we have more than two address spaces. Use a separate listener > for memory and I/O, and utilize Memo

Re: [Qemu-devel] [RFC v1 17/22] memory: use AddressSpace for MemoryListener filtering

2012-10-03 Thread Blue Swirl
On Wed, Oct 3, 2012 at 4:04 PM, Avi Kivity wrote: > Using the AddressSpace type reduces confusion, as you can't accidentally > supply the MemoryRegion you're interested in. > > Signed-off-by: Avi Kivity > --- > exec-memory.h | 3 +++ > exec.c| 10 +- > hw/vfio_pci.c | 3 +-- >

Re: [Qemu-devel] [RFC v1 19/22] memory: per-AddressSpace dispatch

2012-10-03 Thread Blue Swirl
On Wed, Oct 3, 2012 at 4:04 PM, Avi Kivity wrote: > Currently we use a global radix tree to dispatch memory access. This only > works with a single address space; to support multiple address spaces we > make the radix tree a member of AddressSpace (via an intermediate structure > AddressSpaceDisp

Re: [Qemu-devel] [PATCH] qemu-ga: ga_open_pidfile(): add new line to pidfile

2012-10-03 Thread Blue Swirl
On Wed, Oct 3, 2012 at 5:25 PM, Luiz Capitulino wrote: > FHS dictates that pid files should end with a new line. > > Signed-off-by: Luiz Capitulino > --- > qemu-ga.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-ga.c b/qemu-ga.c > index b747470..afd685e 100644 > -

Re: [Qemu-devel] [RFC v1 00/22] Integrate DMA into the memory API

2012-10-03 Thread Blue Swirl
On Wed, Oct 3, 2012 at 4:03 PM, Avi Kivity wrote: > Most of the work on the memory API focused on memory access targets - the > memory regions > and how they are composed into an address space. This patchset tackles the > initator > side of the question - how to originate accesses. > > The Addr

Re: [Qemu-devel] [RFC v1 03/22] kvm: use separate MemoryListeners for memory and I/O

2012-10-04 Thread Blue Swirl
On Thu, Oct 4, 2012 at 6:33 AM, Avi Kivity wrote: > On 10/03/2012 10:16 PM, Blue Swirl wrote: >> > +static MemoryListener kvm_io_listener = { >> >> const >> > > There is a list link field in there. It's a mixed data/ops structure > (perhaps we shoul

Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally

2012-10-04 Thread Blue Swirl
On Thu, Oct 4, 2012 at 10:36 AM, Avi Kivity wrote: > The hassle and compile time overhead of maintaining both 32-bit and 64-bit > capable source isn't worth the tiny performance advantage which is seen on > a minority of configurations. Switch to compiling libhw only once, with > target_phys_addr

Re: [Qemu-devel] [RFC v1 17/22] memory: use AddressSpace for MemoryListener filtering

2012-10-04 Thread Blue Swirl
On Thu, Oct 4, 2012 at 10:17 AM, Avi Kivity wrote: > On 10/03/2012 10:16 PM, Blue Swirl wrote: >>> @@ -141,7 +141,7 @@ static bool memory_listener_match(MemoryListener >>> *listener, >>> #define MEMORY_LISTENER_UPDATE_REGION(fr, as, dir, callback)\

Re: [Qemu-devel] [RFC v1 19/22] memory: per-AddressSpace dispatch

2012-10-04 Thread Blue Swirl
On Thu, Oct 4, 2012 at 6:38 AM, Avi Kivity wrote: > On 10/03/2012 10:24 PM, Blue Swirl wrote: >> > >> > #else >> > -void cpu_physical_memory_rw(target_phys_addr_t addr, uint8_t *buf, >> > -int len, int is_write) >> >

Re: [Qemu-devel] [RFC v1 19/22] memory: per-AddressSpace dispatch

2012-10-04 Thread Blue Swirl
On Thu, Oct 4, 2012 at 5:19 PM, Avi Kivity wrote: > On 10/04/2012 07:13 PM, Blue Swirl wrote: >> On Thu, Oct 4, 2012 at 6:38 AM, Avi Kivity wrote: >>> On 10/03/2012 10:24 PM, Blue Swirl wrote: >>>> > >>>> > #else >>>> > -vo

Re: [Qemu-devel] [RFC v1 19/22] memory: per-AddressSpace dispatch

2012-10-04 Thread Blue Swirl
On Thu, Oct 4, 2012 at 7:05 PM, Anthony Liguori wrote: > Blue Swirl writes: > >> On Thu, Oct 4, 2012 at 5:19 PM, Avi Kivity wrote: >>> On 10/04/2012 07:13 PM, Blue Swirl wrote: >>>> On Thu, Oct 4, 2012 at 6:38 AM, Avi Kivity wrote: >>>&

Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally

2012-10-05 Thread Blue Swirl
On Fri, Oct 5, 2012 at 5:39 AM, Stefan Weil wrote: > Am 05.10.2012 04:10, schrieb Anthony Liguori: > >> Avi Kivity writes: >> >>> The hassle and compile time overhead of maintaining both 32-bit and >>> 64-bit >>> capable source isn't worth the tiny performance advantage which is seen >>> on >>> a

Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501)

2012-10-05 Thread Blue Swirl
On Fri, Oct 5, 2012 at 2:15 PM, Paolo Bonzini wrote: > Il 05/10/2012 15:58, Anthony Liguori ha scritto: >> Paolo Bonzini writes: >> >>> Il 05/10/2012 14:43, Jan Kiszka ha scritto: This "| 1" might be the problem. Anthony, are you relying on it in qemu-test and/or can you work o

Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-10-05 Thread Blue Swirl
On Fri, Oct 5, 2012 at 2:28 PM, Paolo Bonzini wrote: > Il 05/10/2012 15:20, Alberto Garcia ha scritto: >> On Fri, Aug 31, 2012 at 06:09:11PM +0200, Andreas Färber wrote: >> Ping >>> >>> We are currently in Hard Freeze, new devices will not get accepted >>> before the release, and our review m

Re: [Qemu-devel] [PATCH] build: rm libhw

2012-10-05 Thread Blue Swirl
On Fri, Oct 5, 2012 at 4:06 PM, Anthony Liguori wrote: > Signed-off-by: Anthony Liguori > --- > Makefile|2 +- > Makefile.hw | 22 -- > Makefile.objs |2 ++ > Makefile.target |1 - > configure |5 - > 5 files changed, 3 insertions(+),

Re: [Qemu-devel] [PATCH v6 3/4] vfio: vfio-pci device assignment driver

2012-10-05 Thread Blue Swirl
On Fri, Oct 5, 2012 at 5:11 PM, Alex Williamson wrote: > On Fri, 2012-10-05 at 16:54 +0000, Blue Swirl wrote: >> On Wed, Sep 26, 2012 at 5:19 PM, Alex Williamson >> wrote: >> > + >> > +typedef struct QEMU_PACKED VFIOIRQSetFD { >> > +struct

Re: [Qemu-devel] [PATCH v6 3/4] vfio: vfio-pci device assignment driver

2012-10-05 Thread Blue Swirl
On Fri, Oct 5, 2012 at 5:33 PM, Alex Williamson wrote: > On Fri, 2012-10-05 at 17:22 +0000, Blue Swirl wrote: >> On Fri, Oct 5, 2012 at 5:11 PM, Alex Williamson >> wrote: >> > On Fri, 2012-10-05 at 16:54 +, Blue Swirl wrote: >> >> On Wed, Sep 26, 2012 at 5

Re: [Qemu-devel] [PATCH 3/4] qemu-config: Add -drive fd and opaque options

2012-10-05 Thread Blue Swirl
On Fri, Oct 5, 2012 at 6:07 PM, Corey Bryant wrote: > These new options can be used for passing drive file descriptors > on the command line, instead of using the file option to specify > a file name. > > These new command line options mirror the existing add-fd QMP > command which allows an fd to

[Qemu-devel] Win2k broken by kvmvapic

2012-10-07 Thread Blue Swirl
Hi, Win2k does not work in HEAD, it resets the machine. I bisected this to 0b57e287138728f72d88b06e69b970c5d745c44a, but that does not look so buggy. Digging deeper, the problem is introduced by kvmvapic: Breakpoint 1, cpu_physical_memory_write_rom (addr=0xca300, buf=0x7fffec66b500 "", len=0x

Re: [Qemu-devel] [PATCH] qemu-barrier: Fix compilation on i386 hosts

2012-10-07 Thread Blue Swirl
On Sat, Oct 6, 2012 at 10:46 AM, Stefan Weil wrote: > Commit 610b823ef66b993660f1ab1447a769f190e4f3b3 uses QEMU_GNUC_PREREQ > on i386 hosts. > > That macro is defined in qemu-common.h which is not always included > before qemu-barrier.h, so compilation on i386 hosts was broken. This broke sparc-s

Re: [Qemu-devel] [PATCH] exec: Don't request an address for code_gen_buffer if -fpie

2012-10-07 Thread Blue Swirl
On Thu, Oct 4, 2012 at 9:31 PM, Richard Henderson wrote: > The hard-coded addresses inside code_gen_alloc only make sense if > we're building an executable that will actually run at the address > we've put into the linker scripts. > > When we're building with -fpie, the executable will run at some

Re: [Qemu-devel] Win2k broken by kvmvapic

2012-10-07 Thread Blue Swirl
On Sun, Oct 7, 2012 at 5:24 PM, Jan Kiszka wrote: > On 2012-10-07 17:23, Blue Swirl wrote: >> Hi, >> >> Win2k does not work in HEAD, it resets the machine. I bisected this to >> 0b57e287138728f72d88b06e69b970c5d745c44a, but that does not look so >> buggy. >

Re: [Qemu-devel] [PATCH] tcg: Remove redundant pointer from TCGContext

2012-10-07 Thread Blue Swirl
Thanks, applied. On Thu, Oct 4, 2012 at 6:29 PM, Stefan Weil wrote: > The pointer entry 'temps' always refers to the array entry 'static_temps'. > Removing the pointer and renaming 'static_temps' to 'temps' reduces the > size of TCGContext (4 or 8 byte) and allows better code generation. > > Sign

Re: [Qemu-devel] [PATCH 00/23] target-sparc comparison improvements

2012-10-07 Thread Blue Swirl
On Fri, Oct 5, 2012 at 11:54 PM, Richard Henderson wrote: > Most of the patches are cleanup. Some of the middle patches that > make use of setcond and movcond where apropriate do improve code > generation. But more important that that, we no longer have tcg > temporaries that are live across bas

<    2   3   4   5   6   7   8   9   10   11   >