On Tue, Oct 2, 2012 at 11:28 AM, Eric Blake <ebl...@redhat.com> wrote: > On 09/30/2012 06:16 AM, Blue Swirl wrote: >> On Wed, Sep 26, 2012 at 8:32 PM, Igor Mammedov <imamm...@redhat.com> wrote: >>> cpu_model string does represent features in following format: >>> ([+-]feat)|(feat=foo)|(feat) >>> which makes it impossible directly use property infrastructure >>> to set features on CPU. >>> This patch introduces parser that splits CPU name from cpu_model and >>> converts legacy features string into canonized set of strings that >>> is compatible with property manipulation infrastructure. >>> > >>> + >>> + *cpu_name = strtok_r(s, ",", &sptr); >> >> This would break build since strtok_r() isn't available on Mingw, it's > > Correct. Microsoft is stuck in the past when it comes to standard > conformance. > >> not Posix either. > > Huh? http://pubs.opengroup.org/onlinepubs/9699919799/functions/strtok_r.html > strtok_r has been part of POSIX since pthreads were added.
Sorry, I missed that strtok_r() was sharing the entry with strtok(). > > -- > Eric Blake ebl...@redhat.com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >
