On Thu, Oct 4, 2012 at 6:33 AM, Avi Kivity <a...@redhat.com> wrote: > On 10/03/2012 10:16 PM, Blue Swirl wrote: >> > +static MemoryListener kvm_io_listener = { >> >> const >> > > There is a list link field in there. It's a mixed data/ops structure > (perhaps we should make it a traditional ->ops-> pointer).
I grepped for MemoryListener and in hw/xen_pt.c 'const' already exists, so it looked OK but the code actually copies the structure to writable memory. > > -- > I have a truly marvellous patch that fixes the bug which this > signature is too narrow to contain. >