Re: [PULL 10/11] crypto: push error reporting into TLS session I/O APIs

2024-08-27 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Aug 12, 2024 at 05:38:41PM +0200, Thomas Huth wrote: >> On 24/07/2024 11.47, Daniel P. Berrangé wrote: >> > The current TLS session I/O APIs just return a synthetic errno >> > value on error, which has been translated from a gnutls error >> > value. This loose

Re: [RFC PATCH 2/3] target/riscv: add Ssdbltrp extension support

2024-08-27 Thread Clément Léger
On 27/08/2024 07:35, Tommy Wu wrote: > On Thu, Apr 18, 2024 at 9:40 PM Clément Léger wrote: >> >> The Ssdbltrp extension allows handling trap when being in non-reentrant >> state (mainly during exception handling) for S-mode [1]. This patch add >> support for this extension as an experimental e

Re: [PATCH v1 09/15] tcg/riscv: Implement vector cmp ops

2024-08-27 Thread LIU Zhiwei
On 2024/8/14 17:39, Richard Henderson wrote: On 8/13/24 21:34, LIU Zhiwei wrote: From: TANG Tiancheng 1.Address immediate value constraints in RISC-V Vector Extension 1.0 for comparison instructions. 2.Extend comparison results from mask registers to SEW-width elements,    following recomme

Re: [PATCH v1 10/15] tcg/riscv: Implement vector not/neg ops

2024-08-27 Thread LIU Zhiwei
On 2024/8/14 17:45, Richard Henderson wrote: On 8/13/24 21:34, LIU Zhiwei wrote: @@ -2312,6 +2314,12 @@ static void tcg_out_vec_op(TCGContext *s, TCGOpcode opc,   case INDEX_op_xor_vec:   tcg_out_opc_vv(s, OPC_VXOR_VV, a0, a1, a2, true);   break; +    case INDEX_op_not_vec

Re: [PATCH v1 14/15] tcg/riscv: Implement vector roti/v/x shi ops

2024-08-27 Thread LIU Zhiwei
On 2024/8/14 17:55, Richard Henderson wrote: On 8/13/24 21:34, LIU Zhiwei wrote: +    case INDEX_op_shli_vec: +    if (a2 > 31) { +    t2 = tcg_temp_new_i32(); +    tcg_gen_movi_i32(t2, (int32_t)a2); +    tcg_gen_shls_vec(vece, v0, v1, t2); Drop the movi, just pas

Re: [PATCH] virtio/vhost-user: fix qemu crash when hotunplug vhost-user-net device

2024-08-27 Thread Stefano Garzarella
On Wed, Aug 07, 2024 at 05:55:08PM GMT, yaozhenguo wrote: When hotplug and hotunplug vhost-user-net device quickly. I'd replace the . with , qemu will crash. BT is as below: 0 __pthread_kill_implementation () at /usr/lib64/libc.so.6 1 raise () at /usr/lib64/libc.so.6 2 abort () at /usr/li

Re: [PATCH v1 15/15] tcg/riscv: Enable vector TCG host-native

2024-08-27 Thread LIU Zhiwei
On 2024/8/14 18:15, Richard Henderson wrote: On 8/13/24 21:34, LIU Zhiwei wrote: From: TANG Tiancheng Signed-off-by: TANG Tiancheng Reviewed-by: Liu Zhiwei ---   tcg/riscv/tcg-target.h | 10 +++---   1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tcg/riscv/tcg-target.h b/t

[PATCH v1] softmmu/physmem: fix memory leak in dirty_memory_extend()

2024-08-27 Thread David Hildenbrand
As reported by Peter, we might be leaking memory when removing the highest RAMBlock (in the weird ram_addr_t space), and adding a new one. We will fail to realize that we already allocated bitmaps for more dirty memory blocks, and effectively discard the pointers to them. Fix it by getting rid of

Re: [PATCH v3 2/7] tests/functional: Convert mips64el Fuloong2e avocado test (2/2)

2024-08-27 Thread Philippe Mathieu-Daudé
On 27/8/24 07:27, Thomas Huth wrote: On 26/08/2024 22.59, Philippe Mathieu-Daudé wrote: On 26/8/24 11:10, Thomas Huth wrote: On 24/08/2024 18.08, Philippe Mathieu-Daudé wrote: Straight forward conversion. Update the SHA1 hashes to SHA256 hashes since SHA1 should not be used anymore nowadays.

Re: [PATCH 1/4] tests/functional: Add a class containing Linux kernel helpers

2024-08-27 Thread Philippe Mathieu-Daudé
Hi Thomas, On 27/8/24 07:34, Thomas Huth wrote: On 27/08/2024 00.10, Philippe Mathieu-Daudé wrote: Use the 'linux_kernel' namespace to provide common helpers to functional tests booting a Linux kernel. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé ---   tests/functional/qem

Re: [PATCH 1/1] include/qemu/bitops.h: Add deposit8 for uint8_t bit operation

2024-08-27 Thread Peter Maydell
On Mon, 26 Aug 2024 at 22:01, Jason Fan wrote: > > Signed-off-by: Jason Fan > --- > include/qemu/bitops.h | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git a/include/qemu/bitops.h b/include/qemu/bitops.h > index 2c0a2fe751..d01c4b42f2 100644 > --- a/include/qemu/

Re: [PATCH v2 3/6] target/riscv: Add support for Control Transfer Records extension CSRs.

2024-08-27 Thread Frank Chang
Rajnesh Kanwal 於 2024年6月19日 週三 下午11:27寫道: > > This commit adds support for [m|s|vs]ctrcontrol, sctrstatus and > sctrdepth CSRs handling. > > Signed-off-by: Rajnesh Kanwal > --- > target/riscv/cpu.h | 5 ++ > target/riscv/cpu_cfg.h | 2 + > target/riscv/csr.c | 128 +++

Re: [PATCH 1/1] allow using a higher icount

2024-08-27 Thread Alex Bennée
Elisha Hollander writes: > Signed-off-by: Elisha Hollander What is the use-case for this patch? If you are simply looking to slow the emulated system down please have a look at: https://qemu.readthedocs.io/en/master/about/emulation.html#limit-instructions-per-second which uses the plugin

Re: [PATCH] docs/sphinx: fix extra stuff in TOC after freeform QMP sections

2024-08-27 Thread Markus Armbruster
John Snow writes: > Freeform sections with titles are currently generating a TOC entry for > the first paragraph in the section after the header, which is not what > we want. > > (Easiest to observe directly in the QMP reference manual's > "Introduction" section.) > > When freeform sections are p

[PATCH v4 0/7] tests/functional: Convert few MIPS avocado tests

2024-08-27 Thread Philippe Mathieu-Daudé
Since v3: - Use linux_kernel_wait_for_pattern (Thomas) $ RESCUE_YL_PATH=/path/to/fuloong2e/rescue-yl \ QEMU_TEST_ALLOW_UNTRUSTED_CODE=1 \ QEMU_TEST_FLAKY_TESTS=1 \ QEMU_TEST_TIMEOUT_EXPECTED=1 \ make check-functional V=1 ▶ 2/17 test_empty_cpu_model.EmptyCPUModel.test

[PATCH v4 2/7] tests/functional: Convert mips64el Fuloong2e avocado test (2/2)

2024-08-27 Thread Philippe Mathieu-Daudé
Straight forward conversion. Update the SHA1 hashes to SHA256 hashes since SHA1 should not be used anymore nowadays. Add extract_from_deb() method in qemu_test.utils package. Signed-off-by: Philippe Mathieu-Daudé --- tests/avocado/boot_linux_console.py | 21 -- tests/fun

[PATCH v4 4/7] tests/functional: Convert mips64el 5KEc Malta avocado tests

2024-08-27 Thread Philippe Mathieu-Daudé
Straight forward conversion. Update the SHA1 hashes to SHA256 hashes since SHA1 should not be used anymore nowadays. Signed-off-by: Philippe Mathieu-Daudé --- tests/avocado/boot_linux_console.py | 74 tests/functional/test_mips64el_malta.py | 77 +

[PATCH v4 7/7] tests/functional: Convert mips32eb 4Kc Malta avocado tests

2024-08-27 Thread Philippe Mathieu-Daudé
Straight forward conversion. Update the SHA1 hashes to SHA256 hashes since SHA1 should not be used anymore nowadays. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + tests/avocado/boot_linux_console.py | 63 -- tests/functional/meson.build

[PATCH v4 1/7] tests/functional: Convert mips64el Fuloong2e avocado test (1/2)

2024-08-27 Thread Philippe Mathieu-Daudé
Straight forward conversion. Update the SHA1 hashes to SHA256 hashes since SHA1 should not be used anymore nowadays. Since the asset is expected locally and the test is guarded with RESCUE_YL_PATH, keep it under the 'quick' category. $ RESCUE_YL_PATH=/path/to/rescue-yl QEMU_TEST_ALLOW_UNTRUSTED

[PATCH v4 5/7] tests/functional: Convert mips32el Malta YAMON avocado test

2024-08-27 Thread Philippe Mathieu-Daudé
Straight forward conversion using the Python standard zipfile module instead of avocado.utils package. Update the SHA1 hashes to SHA256 hashes since SHA1 should not be used anymore nowadays. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- MAINTAINERS

[PATCH v4 6/7] tests/functional: Convert nanomips Malta avocado tests

2024-08-27 Thread Philippe Mathieu-Daudé
Straight forward conversion. Update the SHA1 hashes to SHA256 hashes since SHA1 should not be used anymore nowadays. $ QEMU_TEST_ALLOW_UNTRUSTED_CODE=1 \ make check-functional-mipsel ... ▶ 4/4 test_mipsel_malta.MaltaMachineConsole.test_mips_malta32el_nanomips_16k_up OK ▶ 4/4 tes

[PATCH v4 3/7] tests/functional: Convert mips64el I6400 Malta avocado tests

2024-08-27 Thread Philippe Mathieu-Daudé
Straight forward conversion. Update the SHA1 hashes to SHA256 hashes since SHA1 should not be used anymore nowadays. Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + tests/avocado/machine_mips_malta.py | 108

Re: [PATCH v17 00/13] Support blob memory and venus on qemu

2024-08-27 Thread Alex Bennée
Dmitry Osipenko writes: > Hello, > > This series enables Vulkan Venus context support on virtio-gpu. > > All virglrender and almost all Linux kernel prerequisite changes > needed by Venus are already in upstream. For kernel there is a pending > KVM patchset that fixes mapping of compound pages ne

[PATCH] mark with for-crc32 in a consistent manner

2024-08-27 Thread Michael Tokarev
in many cases, is only included for crc32 function, and in some of them, there's a comment saying that, but in a different way. In one place (hw/net/rtl8139.c), there was another #include added between the comment and include. Make all such comments to be on the same line as #include, make it c

[PULL 1/1] docs/sphinx: fix extra stuff in TOC after freeform QMP sections

2024-08-27 Thread Markus Armbruster
From: John Snow Freeform sections with titles are currently generating a TOC entry for the first paragraph in the section after the header, which is not what we want. (Easiest to observe directly in the QMP reference manual's "Introduction" section.) When freeform sections are parsed, we create

[PULL 0/1] QAPI patches patches for 2024-08-27

2024-08-27 Thread Markus Armbruster
I'm nominating this fix for v9.1 because it can only affect generated documentation, and CI should protect us from surprise build breaks. Feel free to delay it to v9.2 if you think even that is too much risk or simply too much trouble to be worthwhile. The following changes since commit afaee42f77

Re: [RFC-PATCH v2] vhost-user: add a request-reply lock

2024-08-27 Thread Prasad Pandit
Hello Michael, all Sorry about a late reply, catching up with emails after long PTOs. On Mon, 19 Aug 2024 at 21:20, Michael S. Tsirkin wrote: >> makes sense. >> Acked-by: Michael S. Tsirkin >> But do not post v2 as reply to v1 pls. * Yes, okay. Thank you for the review. I sent in reply to v1

Re: [PATCH v3] vhost-user: Do not wait for reply for not sent VHOST_USER_SET_LOG_BASE

2024-08-27 Thread Prasad Pandit
On Thu, 1 Aug 2024 at 20:32, BillXiang wrote: > > From: "Michael S. Tsirkin" > > How do things work now after 7c211eb078c4 then? > > It does not really work after 7c211eb078c4 and it's my mistake. > I forgot to submit the code to check vq_index in 7c211eb078c4. > * vhost_user_set_log_base() sends

Re: [PATCH v9 08/12] qapi/acpi-hest: add an interface to do generic CPER error injection

2024-08-27 Thread Markus Armbruster
Mauro Carvalho Chehab writes: > Creates a QMP command to be used for generic ACPI APEI hardware error > injection (HEST) via GHESv2, and add support for it for ARM guests. > > Error injection uses ACPI_HEST_SRC_ID_QMP source ID to be platform > independent. This is mapped at arch virt bindings, d

Re: [PATCH v3] vhost-user: Do not wait for reply for not sent VHOST_USER_SET_LOG_BASE

2024-08-27 Thread BillXiang
> From: "Prasad Pandit" > Date:  Tue, Aug 27, 2024, 19:06 > Subject:  Re: [PATCH v3] vhost-user: Do not wait for reply for not sent > VHOST_USER_SET_LOG_BASE > To: "BillXiang" > Cc: "Michael S. Tsirkin", > On Thu, 1 Aug 2024 at 20:32, BillXiang wrote: > > > From: "Michael S. Tsirkin" > > > How

[PATCH v9 3/9] configure, meson: detect Rust toolchain

2024-08-27 Thread Manos Pitsidianakis
From: Paolo Bonzini Include the correct path and arguments to rustc in the native and cross files (native compilation is needed for procedural macros). Signed-off-by: Paolo Bonzini --- configure | 50 -- meson.build | 8 +++- 2 files chang

[PATCH v9 6/9] meson.build: add HAVE_GLIB_WITH_ALIGNED_ALLOC flag

2024-08-27 Thread Manos Pitsidianakis
Rust crates, introduced from the next commit onwards, use the glib allocator API and need to know whether g_aligned_alloc etc are available. This commit adds a define in config_host_data that depends on glib version >= 2.72. Signed-off-by: Manos Pitsidianakis --- meson.build | 4 1 file ch

[PATCH v9 0/9] Add Rust build support, ARM PL011 device impl

2024-08-27 Thread Manos Pitsidianakis
Hello everyone, This series adds: - build system support for the Rust compiler - a small Rust library, qemu-api, which includes bindings to QEMU's C interface generated with bindgen, and qemu-api-macros, a procedural macro library. - a proof of concept ARM PL011 device implementation in Rust,

[PATCH v9 9/9] rust: add PL011 device model

2024-08-27 Thread Manos Pitsidianakis
This commit adds a re-implementation of hw/char/pl011.c in Rust. How to build: 1. Configure a QEMU build with: --enable-system --target-list=aarch64-softmmu --enable-rust 2. Launching a VM with qemu-system-aarch64 should use the Rust version of the pl011 device Co-authored-by: Junjie Mao

[PATCH v9 2/9] build-sys: Add rust feature option

2024-08-27 Thread Manos Pitsidianakis
Add rust feature in meson.build, configure, to prepare for adding Rust code in the followup commits. Signed-off-by: Manos Pitsidianakis --- MAINTAINERS | 5 + meson.build | 25 - Kconfig | 1 + Kconfig.host

[PATCH v9 1/9] Require meson version 1.5.0

2024-08-27 Thread Manos Pitsidianakis
From: Paolo Bonzini This is needed for Rust support. Signed-off-by: Paolo Bonzini --- meson.build| 2 +- python/scripts/vendor.py | 4 ++-- python/wheels/meson-1.2.3-py3-none-any.whl | Bin 964928 -> 0 bytes python/wheels/meson-1.5.0-py3-no

[PATCH v9 8/9] rust: add utility procedural macro crate

2024-08-27 Thread Manos Pitsidianakis
This commit adds a helper crate library, qemu-api-macros for derive (and other procedural) macros to be used along qemu-api. It needs to be a separate library because in Rust, procedural macros, or macros that can generate arbitrary code, need to be special separate compilation units. Only one ma

[PATCH v9 5/9] .gitattributes: add Rust diff and merge attributes

2024-08-27 Thread Manos Pitsidianakis
Set rust source code to diff=rust (built-in with new git versions) and merge=binary for Cargo.lock files (they should not be merged but auto-generated by cargo) Reviewed-by: Alex Bennée Reviewed-by: Zhao Liu Signed-off-by: Manos Pitsidianakis --- .gitattributes | 3 +++ 1 file changed, 3 inser

[PATCH v9 4/9] rust: add bindgen step as a meson dependency

2024-08-27 Thread Manos Pitsidianakis
Add bindings_rs target for generating rust bindings to target-independent qemu C APIs. The bindings need be created before any rust crate that uses them is compiled. The bindings.rs file will end up in BUILDDIR/bindings.rs and have the same name as a target: ninja bindings.rs Signed-off-by: P

[PATCH v9 7/9] rust: add crate to expose bindings and interfaces

2024-08-27 Thread Manos Pitsidianakis
Add rust/qemu-api, which exposes rust-bindgen generated FFI bindings and provides some declaration macros for symbols visible to the rest of QEMU. Co-authored-by: Junjie Mao Co-authored-by: Paolo Bonzini Signed-off-by: Junjie Mao Signed-off-by: Paolo Bonzini Signed-off-by: Manos Pitsidianakis

Re: [PATCH] mark with for-crc32 in a consistent manner

2024-08-27 Thread Philippe Mathieu-Daudé
+Richard On 27/8/24 12:02, Michael Tokarev wrote: in many cases, is only included for crc32 function, and in some of them, there's a comment saying that, but in a different way. In one place (hw/net/rtl8139.c), there was another #include added between the comment and include. Make all such c

Re: [PATCH] hw/ppc: fix decrementer with BookE timers

2024-08-27 Thread Clément Chigot
Hey, Gentle ping Thanks Clément On Mon, Jul 29, 2024 at 10:33 AM Clément Chigot wrote: > > Hi, > > Gentle ping + CC missing maintainers. > > Thanks Clément > > On Mon, Jul 15, 2024 at 10:46 AM Clément Chigot wrote: > > > > The BookE decrementer stops at 0, meaning that it won't decremented > >

Re: [PATCH for-9.2 v6 08/12] hw/riscv/riscv-iommu: add Address Translation Cache (IOATC)

2024-08-27 Thread Daniel Henrique Barboza
On 8/26/24 11:44 PM, Tomasz Jeznach wrote: On Fri, Aug 23, 2024 at 10:18 AM Daniel Henrique Barboza wrote: On 8/20/24 12:27 PM, Jason Chien wrote: Hi Daniel, On 2024/8/1 下午 11:43, Daniel Henrique Barboza wrote: From: Tomasz Jeznach The RISC-V IOMMU spec predicts that the IOMMU can us

Re: [PATCH 1/1] allow using a higher icount

2024-08-27 Thread Elisha Hollander
Oh nice, I didn't know that On Tue, Aug 27, 2024, 12:39 Alex Bennée wrote: > Elisha Hollander writes: > > > Signed-off-by: Elisha Hollander > > What is the use-case for this patch? > > If you are simply looking to slow the emulated system down please have a > look at: > > > https://qemu.readth

Re: [PATCH] mark with for-crc32 in a consistent manner

2024-08-27 Thread Mark Cave-Ayland
On 27/08/2024 11:02, Michael Tokarev wrote: in many cases, is only included for crc32 function, and in some of them, there's a comment saying that, but in a different way. In one place (hw/net/rtl8139.c), there was another #include added between the comment and include. Make all such comment

Re: [PATCH v3] kvm: replace fprintf with error_report/printf() in kvm_init()

2024-08-27 Thread Ani Sinha
> On 27 Aug 2024, at 12:00 PM, Markus Armbruster wrote: > > Philippe Mathieu-Daudé writes: > >> Hi Ani, >> >> On 9/8/24 08:49, Ani Sinha wrote: >>> error_report() is more appropriate for error situations. Replace fprintf >>> with >>> error_report. Cosmetic. No functional change. >>> CC: qe

Re: [PATCH v3] kvm: replace fprintf with error_report/printf() in kvm_init()

2024-08-27 Thread Markus Armbruster
Ani Sinha writes: >> On 27 Aug 2024, at 12:00 PM, Markus Armbruster wrote: >> >> Philippe Mathieu-Daudé writes: >> >>> Hi Ani, >>> >>> On 9/8/24 08:49, Ani Sinha wrote: error_report() is more appropriate for error situations. Replace fprintf with error_report. Cosmetic. No fu

Re: [PATCH v3 2/7] tests/functional: Convert mips64el Fuloong2e avocado test (2/2)

2024-08-27 Thread Thomas Huth
On 27/08/2024 11.16, Philippe Mathieu-Daudé wrote: On 27/8/24 07:27, Thomas Huth wrote: On 26/08/2024 22.59, Philippe Mathieu-Daudé wrote: On 26/8/24 11:10, Thomas Huth wrote: On 24/08/2024 18.08, Philippe Mathieu-Daudé wrote: Straight forward conversion. Update the SHA1 hashes to SHA256 hash

Re: [PATCH 1/4] tests/functional: Add a class containing Linux kernel helpers

2024-08-27 Thread Thomas Huth
On 27/08/2024 11.21, Philippe Mathieu-Daudé wrote: Hi Thomas, On 27/8/24 07:34, Thomas Huth wrote: On 27/08/2024 00.10, Philippe Mathieu-Daudé wrote: Use the 'linux_kernel' namespace to provide common helpers to functional tests booting a Linux kernel. Suggested-by: Thomas Huth Signed-off-by

[PATCH 1/2] tests/functional: Add the LinuxKernelTest for testing the Linux boot process

2024-08-27 Thread Thomas Huth
Copy the LinuxKernelTest from tests/acceptance/boot_linux_console.py to be able to convert the related tests to the functional test framework in the following patches. Signed-off-by: Thomas Huth --- tests/functional/qemu_test/__init__.py| 1 + tests/functional/qemu_test/linuxkernel.py | 41

[PATCH 0/2] tests/functional: Add LinuxKernelTest class and convert Q800 test

2024-08-27 Thread Thomas Huth
Here's how I'd suggest to convert the tests from tests/avocado/boot_linux_console.py : Copy the whole LinuxKernelTest class (well, let's drop extract_from_rpm for now since it is completely unused), so we can copy the test code with only some few modifications (using the Q800 test as an example her

[PATCH 2/2] tests/functional: Convert the m68k Q800 Avocado test into a functional test

2024-08-27 Thread Thomas Huth
Just had to update the asset checksum to use SHA256 instead of SHA1, but apart from that it is a pretty much straightforward conversion. Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + tests/avocado/boot_linux_console.py | 24 --- tests/functional/meson

Re: [PATCH v3] vhost-user: Do not wait for reply for not sent VHOST_USER_SET_LOG_BASE

2024-08-27 Thread Prasad Pandit
On Tue, 27 Aug 2024 at 16:50, BillXiang wrote: > it's better to be consistent to use vhost_user_per_device_request for those > per-device messages, right? * ...consistent to use? Could you please elaborate a little? Thank you. --- - Prasad

Re: [PATCH v3 4/4] tests/tcg/aarch64: Extend MTE gdbstub tests to system mode

2024-08-27 Thread Gustavo Romero
Hi Phil! On 8/26/24 3:10 AM, Philippe Mathieu-Daudé wrote: Hi Gustavo, On 25/8/24 16:52, Gustavo Romero wrote: Extend MTE gdbstub tests to also run in system mode (share tests between user mode and system mode). The tests will only run if a version of GDB that supports MTE on baremetal is avai

Re: [PATCH 0/7] pc-bios/s390-ccw: Merge the netboot loader into s390-ccw.img

2024-08-27 Thread Thomas Huth
On 26/08/2024 19.07, Jared Rossi wrote: Hi Thomas, I just wanted to get your thoughts on the status of the netboot loader merge. I see that the first patch from this series was merged, but not the others. Is there any issue with the rest of the changes? Hi Jared, there's no issue with that p

Re: [PATCH v3] vhost-user: Do not wait for reply for not sent VHOST_USER_SET_LOG_BASE

2024-08-27 Thread BillXiang
> From: "Prasad Pandit" > Date:  Tue, Aug 27, 2024, 20:37 > Subject:  Re: [PATCH v3] vhost-user: Do not wait for reply for not sent > VHOST_USER_SET_LOG_BASE > To: "BillXiang" > Cc: "Michael S. Tsirkin", > On Tue, 27 Aug 2024 at 16:50, BillXiang wrote: > > it's better to be consistent to use v

Re: [PATCH 0/7] pc-bios/s390-ccw: Merge the netboot loader into s390-ccw.img

2024-08-27 Thread Jared Rossi
On 8/27/24 8:43 AM, Thomas Huth wrote: I think it's maybe best if you'd include my patches at the top of your patch series, so you could also rework them in case you need something to be changed there. That way, we also do not have to rebuild the binaries in the git repo multiple times and ju

Re: [PATCH v4 15/35] tests/functional: enable pre-emptive caching of assets

2024-08-27 Thread Thomas Huth
On 23/08/2024 09.28, Philippe Mathieu-Daudé wrote: Hi, On 21/8/24 10:27, Thomas Huth wrote: From: Daniel P. Berrangé Many tests need to access assets stored on remote sites. We don't want to download these during test execution when run by meson, since this risks hitting test timeouts when da

Re: [PATCH v4 7/7] tests/qtest: Delete previous boot file

2024-08-27 Thread Thomas Huth
On 26/08/2024 17.26, Peter Xu wrote: On Fri, Aug 23, 2024 at 03:13:12PM +0900, Akihiko Odaki wrote: A test run may create boot files several times. Delete the previous boot file before creating a new one. Signed-off-by: Akihiko Odaki Reviewed-by: Michael S. Tsirkin Acked-by: Thomas Huth I

Re: [PATCH] vhost-user: add NEED_REPLY flag

2024-08-27 Thread Stefano Garzarella
On Mon, Aug 12, 2024 at 12:53:19PM GMT, 陆知行 wrote: Hi, can someone review this patch? I find requests which call vhost_user_get_u64 does not set NEED_REPLY flag Can you provide an example to trigger this issue? Also, with this change all calls to vhost_user_get_u64() will set that flag, is t

Re: [PATCH V2 1/1] virtio-pci: Add lookup subregion of VirtIOPCIRegion MR

2024-08-27 Thread Stefano Garzarella
On Tue, Aug 20, 2024 at 07:56:31PM GMT, Gao Shiyuan wrote: When VHOST_USER_PROTOCOL_F_HOST_NOTIFIER feature negotiated and virtio_queue_set_host_notifier_mr success on system blk device's queue, the VM can't load MBR if the notify region's address above 4GB. Assign the address of notify region i

Re: [PATCH v4 15/15] hw/misc/aspeed_hace: Fix SG Accumulative hashing

2024-08-27 Thread Cédric Le Goater
On 8/7/24 21:51, Alejandro Zeise wrote: Make the Aspeed HACE module use the new qcrypto accumulative hashing functions when in scatter-gather accumulative mode. A hash context will maintain a "running-hash" as each scatter-gather chunk is received. Previously each scatter-gather "chunk" was cach

[PATCH] target-i386: Walk NPT in guest real mode

2024-08-27 Thread Alexander Graf
When translating virtual to physical address with a guest CPU that supports nested paging (NPT), we need to perform every page table walk access indirectly through the NPT, which we correctly do. However, we treat real mode (no page table walk) special: In that case, we currently just skip any wal

Re: [PATCH v4 7/7] tests/qtest: Delete previous boot file

2024-08-27 Thread Fabiano Rosas
Thomas Huth writes: > On 26/08/2024 17.26, Peter Xu wrote: >> On Fri, Aug 23, 2024 at 03:13:12PM +0900, Akihiko Odaki wrote: >>> A test run may create boot files several times. Delete the previous boot >>> file before creating a new one. >>> >>> Signed-off-by: Akihiko Odaki >>> Reviewed-by: Mich

Re: [PATCH v4 7/7] tests/qtest: Delete previous boot file

2024-08-27 Thread Peter Maydell
On Tue, 27 Aug 2024 at 15:03, Fabiano Rosas wrote: > > Thomas Huth writes: > > > On 26/08/2024 17.26, Peter Xu wrote: > >> On Fri, Aug 23, 2024 at 03:13:12PM +0900, Akihiko Odaki wrote: > >>> A test run may create boot files several times. Delete the previous boot > >>> file before creating a new

Re: [PATCH v4 15/35] tests/functional: enable pre-emptive caching of assets

2024-08-27 Thread Thomas Huth
On 27/08/2024 15.16, Thomas Huth wrote: On 23/08/2024 09.28, Philippe Mathieu-Daudé wrote: Hi, On 21/8/24 10:27, Thomas Huth wrote: From: Daniel P. Berrangé Many tests need to access assets stored on remote sites. We don't want to download these during test execution when run by meson, since

[PATCH v4 2/2] kvm: refactor core virtual machine creation into its own function

2024-08-27 Thread Ani Sinha
Refactoring the core logic around KVM_CREATE_VM into its own separate function so that it can be called from other functions in subsequent patches. There is no functional change in this patch. CC: pbonz...@redhat.com CC: zhao1@intel.com CC: cfont...@suse.de CC: arm...@redhat.com CC: qemu-triv.

[PATCH 0/2] Some refactoring

2024-08-27 Thread Ani Sinha
replace fprintf() with error_report() in kvm_init() refactor code in kvm_init() to move core vm creation operation to its own function. CC: qemu-triv...@nongnu.org CC: qemu-devel@nongnu.org CC: zhao1@intel.com CC: pbonz...@redhat.com CC: arm...@redhat.com Ani Sinha (2): kvm: replace fprintf

[PATCH v4 1/2] kvm: replace fprintf with error_report/printf() in kvm_init()

2024-08-27 Thread Ani Sinha
error_report() is more appropriate for error situations. Replace fprintf with error_report. Cosmetic. No functional change. CC: qemu-triv...@nongnu.org CC: zhao1@intel.com CC: arm...@redhat.com Reviewed-by: Zhao Liu Signed-off-by: Ani Sinha --- accel/kvm/kvm-all.c | 40 ++---

Re: [PATCH v4 2/2] kvm: refactor core virtual machine creation into its own function

2024-08-27 Thread Peter Maydell
On Tue, 27 Aug 2024 at 16:11, Ani Sinha wrote: > > Refactoring the core logic around KVM_CREATE_VM into its own separate function > so that it can be called from other functions in subsequent patches. There is > no functional change in this patch. What subsequent patches? This is patch 2 of 2...

Re: [RFC v3 3/3] vhost: Allocate memory for packed vring

2024-08-27 Thread Eugenio Perez Martin
On Wed, Aug 21, 2024 at 2:20 PM Sahil wrote: > > Hi, > > Sorry for the late reply. > > On Tuesday, August 13, 2024 12:23:55 PM GMT+5:30 Eugenio Perez Martin wrote: > > [...] > > > I think I have understood what's going on in "vhost_vdpa_svq_map_rings", > > > "vhost_vdpa_svq_map_ring" and "vhost_vd

Re: [PATCH] hw/cxl: Support aborting background commands

2024-08-27 Thread Jonathan Cameron via
On Tue, 13 Aug 2024 15:12:55 -0700 Davidlohr Bueso wrote: > As of 3.1 spec, background commands can be canceled with a new > abort command. Implement the support, which is advertised in > the CEL. No ad-hoc context undoing is necessary as all the > command logic of the running bg command is done

Re: [PATCH v4 2/2] kvm: refactor core virtual machine creation into its own function

2024-08-27 Thread Ani Sinha
On Tue, 27 Aug, 2024, 8:59 pm Peter Maydell, wrote: > On Tue, 27 Aug 2024 at 16:11, Ani Sinha wrote: > > > > Refactoring the core logic around KVM_CREATE_VM into its own separate > function > > so that it can be called from other functions in subsequent patches. > There is > > no functional chan

Re: [PATCH v4 19/34] modules: check arch on qom lookup

2024-08-27 Thread Philippe Mathieu-Daudé
Hi, (old patch) On 24/6/21 12:38, Gerd Hoffmann wrote: With target-specific modules we can have multiple modules implementing the same object. Therefore we have to check the target arch on lookup to find the correct module. "multiple modules implementing the same object." seems a design mist

[PATCH v12 0/3] Support message-based DMA in vfio-user server

2024-08-27 Thread Mattias Nissler
This series adds basic support for message-based DMA in qemu's vfio-user server. This is useful for cases where the client does not provide file descriptors for accessing system memory via memory mappings. My motivating use case is to hook up device models as PCIe endpoints to a hardware design. Th

[PATCH v12 3/3] vfio-user: Fix memory region reference accounting

2024-08-27 Thread Mattias Nissler
The memory regions created for DMA regions where leaking the original reference the object is initialized with. This happened since we insert the memory region as a subregion, but don't keep the reference obtained when creating the object. Thus, drop the reference after inserting the DMA memory reg

Re: [PATCH v10 1/8] memory: prevent dma-reentracy issues

2024-08-27 Thread Igor Mammedov
On Wed, 21 Aug 2024 15:25:18 +0200 Igor Mammedov wrote: > On Thu, 27 Apr 2023 17:10:06 -0400 > Alexander Bulekov wrote: > > > Add a flag to the DeviceState, when a device is engaged in PIO/MMIO/DMA. > > This flag is set/checked prior to calling a device's MemoryRegion > > handlers, and set when

[PATCH v12 1/3] Update subprojects/libvfio-user

2024-08-27 Thread Mattias Nissler
Brings in assorted bug fixes. The following are of particular interest with respect to message-based DMA support: * bb308a2 "Fix address calculation for message-based DMA" Corrects a bug in DMA address calculation. * 1569a37 "Pass server->client command over a separate socket pair" Adds suppo

[PATCH v12 2/3] vfio-user: Message-based DMA support

2024-08-27 Thread Mattias Nissler
Wire up support for DMA for the case where the vfio-user client does not provide mmap()-able file descriptors, but DMA requests must be performed via the VFIO-user protocol. This installs an indirect memory region, which already works for pci_dma_{read,write}, and pci_dma_map works thanks to the ex

Re: [PATCH] hw/ppc: fix decrementer with BookE timers

2024-08-27 Thread Philippe Mathieu-Daudé
Adding Cédric On 27/8/24 13:49, Clément Chigot wrote: Hey, Gentle ping Thanks Clément On Mon, Jul 29, 2024 at 10:33 AM Clément Chigot wrote: Hi, Gentle ping + CC missing maintainers. Thanks Clément On Mon, Jul 15, 2024 at 10:46 AM Clément Chigot wrote: The BookE decrementer stops at

Re: [PATCH v4 7/7] tests/qtest: Delete previous boot file

2024-08-27 Thread Fabiano Rosas
Peter Maydell writes: > On Tue, 27 Aug 2024 at 15:03, Fabiano Rosas wrote: >> >> Thomas Huth writes: >> >> > On 26/08/2024 17.26, Peter Xu wrote: >> >> On Fri, Aug 23, 2024 at 03:13:12PM +0900, Akihiko Odaki wrote: >> >>> A test run may create boot files several times. Delete the previous boot

Re: [PATCH v2 1/2] plugins: add plugin API to read guest memory

2024-08-27 Thread Pierrick Bouvier
On 8/26/24 19:18, Rowan Hart wrote: Signed-off-by: Rowan Hart --- include/qemu/qemu-plugin.h | 32 +++- plugins/api.c| 20 plugins/qemu-plugins.symbols | 1 + 3 files changed, 52 insertions(+), 1 deletion(-) diff --git a/i

Re: [PATCH v2 2/2] plugins: add option to dump write argument to syscall plugin

2024-08-27 Thread Pierrick Bouvier
On 8/26/24 19:18, Rowan Hart wrote: Signed-off-by: Rowan Hart --- docs/about/emulation.rst| 14 - tests/tcg/plugins/syscall.c | 117 2 files changed, 130 insertions(+), 1 deletion(-) diff --git a/docs/about/emulation.rst b/docs/about/emulation.r

Re: [RFC PATCH v3 12/24] hw/arm: add basic support for the RT500 SoC

2024-08-27 Thread Philippe Mathieu-Daudé
On 27/8/24 08:45, Octavian Purdila wrote: Add basic support for the RT500 SoC. It supports enough peripherals to run the NXP's microXpresso SDK hello world example. The patch includes an automatically generated header which contains peripheral base addreses and interrupt numbers. The header can

Re: [PATCH v4 03/14] hw/riscv: add RISC-V IOMMU base emulation

2024-08-27 Thread Tomasz Jeznach
On Thu, Jul 4, 2024 at 7:20 AM Jason Chien wrote: > > Hi Danial, > > On 2024/6/25 上午 04:18, Daniel Henrique Barboza wrote: > > From: Tomasz Jeznach > > > > The RISC-V IOMMU specification is now ratified as-per the RISC-V > > international process. The latest frozen specifcation can be found at: >

Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion

2024-08-27 Thread Peter Xu
On Tue, Aug 27, 2024 at 01:14:51PM +0900, Akihiko Odaki wrote: > On 2024/08/27 4:42, Peter Xu wrote: > > On Mon, Aug 26, 2024 at 06:10:25PM +0100, Peter Maydell wrote: > > > On Mon, 26 Aug 2024 at 16:22, Peter Xu wrote: > > > > > > > > On Fri, Aug 23, 2024 at 03:13:11PM +0900, Akihiko Odaki wrote

Re: [PATCH v1] softmmu/physmem: fix memory leak in dirty_memory_extend()

2024-08-27 Thread Peter Maydell
On Tue, 27 Aug 2024 at 09:37, David Hildenbrand wrote: > > As reported by Peter, we might be leaking memory when removing the > highest RAMBlock (in the weird ram_addr_t space), and adding a new one. > > We will fail to realize that we already allocated bitmaps for more > dirty memory blocks, and

Re: [EXT] Re: [PATCH] hw/cxl: Fix background completion percentage calculation

2024-08-27 Thread Jonathan Cameron via
On Tue, 27 Aug 2024 16:01:54 + ajay.opensrc wrote: > > From: Davidlohr Bueso > > > > On Mon, 29 Jul 2024, ajay.open...@micron.com wrote:\n > > >From: Ajay Joshi > > > > > >The current completion percentage calculation does not account for the > > >relative time since the start of the bac

[PATCH 0/2] QEMU DCD emulation support fix

2024-08-27 Thread nifan . cxl
From: Fan Ni In Ira's latest DCD kernel patchset[1], the More flag support has been added. While testing it with mainstream Qemu, I identified two issues with Qemu. 1. For a DC extent add request with more than one extents, the More flag for the last one is not correctly set. 2. The function cxl

[PATCH 1/2] hw/mem/cxl_type3: Fix More flag setting for dynamic capacity event records

2024-08-27 Thread nifan . cxl
From: Fan Ni Per cxl spec r3.1, for multiple dynamic capacity event records grouped via the More flag, the last record in the sequence should clear the More flag. Before the change, the More flag of the event record is cleared before the loop of inserting records into the event log, which will l

[PATCH 2/2] hw/cxl/cxl_event: Fix interrupt triggering for dynamic capacity events grouped via More flag

2024-08-27 Thread nifan . cxl
From: Fan Ni When inserting multiple dynamic capacity event records grouped via More flag, we should only trigger interrupt after the last record is inserted into the event log. Achieving the goal by letting cxl_event_insert return true only for the insertion of the last dynamic capacity event re

Re: [PATCH v1] softmmu/physmem: fix memory leak in dirty_memory_extend()

2024-08-27 Thread Stefan Hajnoczi
On Tue, 27 Aug 2024 at 04:38, David Hildenbrand wrote: > > As reported by Peter, we might be leaking memory when removing the > highest RAMBlock (in the weird ram_addr_t space), and adding a new one. > > We will fail to realize that we already allocated bitmaps for more > dirty memory blocks, and

Re: [EXT] Re: [PATCH] hw/cxl: Fix background completion percentage calculation

2024-08-27 Thread ajay . opensrc
> From: Davidlohr Bueso > > On Mon, 29 Jul 2024, ajay.open...@micron.com wrote:\n > >From: Ajay Joshi > > > >The current completion percentage calculation does not account for the > >relative time since the start of the background activity, this leads to > >showing incorrect start percentage vs

Re: [PATCH] Add vhost-user-spi and vhost-user-spi-pci devices

2024-08-27 Thread Alex Bennée
Haixu Cui writes: Apologies for the delay in getting to this. > This work is based on the virtio-spi spec, virtio-spi driver introduced by > the following patch series: > - https://github.com/oasis-tcs/virtio-spec/tree/virtio-1.4/device-types/spi > - https://lwn.net/Articles/966715/ > > To tes

Re: [PATCH v1] softmmu/physmem: fix memory leak in dirty_memory_extend()

2024-08-27 Thread David Hildenbrand
On 27.08.24 18:52, Stefan Hajnoczi wrote: On Tue, 27 Aug 2024 at 04:38, David Hildenbrand wrote: As reported by Peter, we might be leaking memory when removing the highest RAMBlock (in the weird ram_addr_t space), and adding a new one. We will fail to realize that we already allocated bitmaps

Re: [PATCH v1] softmmu/physmem: fix memory leak in dirty_memory_extend()

2024-08-27 Thread Stefan Hajnoczi
On Tue, 27 Aug 2024 at 13:24, David Hildenbrand wrote: > > On 27.08.24 18:52, Stefan Hajnoczi wrote: > > On Tue, 27 Aug 2024 at 04:38, David Hildenbrand wrote: > >> > >> As reported by Peter, we might be leaking memory when removing the > >> highest RAMBlock (in the weird ram_addr_t space), and a

Re: [PATCH] hw/ppc: fix decrementer with BookE timers

2024-08-27 Thread Cédric Le Goater
Hello Clément, On 7/15/24 10:46, Clément Chigot wrote: The BookE decrementer stops at 0, meaning that it won't decremented towards "negative" values. However, the current logic is inverted: decr is updated solely when the resulting value would be negative. How did you hit the issue ? which mac

[PATCH v6 02/19] migration/multifd: Inline page_size and page_count

2024-08-27 Thread Fabiano Rosas
The MultiFD*Params structures are for per-channel data. Constant values should not be there because that needlessly wastes cycles and storage. The page_size and page_count fall into this category so move them inline in multifd.h. Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas --- migration/

[PATCH v6 10/19] migration/multifd: Isolate ram pages packet data

2024-08-27 Thread Fabiano Rosas
While we cannot yet disentangle the multifd packet from page data, we can make the code a bit cleaner by setting the page-related fields in a separate function. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas --- migration/multifd.c| 99 ++

[PATCH v6 06/19] migration/multifd: Make MultiFDPages_t:offset a flexible array member

2024-08-27 Thread Fabiano Rosas
We're about to use MultiFDPages_t from inside the MultiFDSendData payload union, which means we cannot have pointers to allocated data inside the pages structure, otherwise we'd lose the reference to that memory once another payload type touches the union. Move the offset array into the end of the

  1   2   3   >