> From: "Prasad Pandit"<ppan...@redhat.com> > Date: Tue, Aug 27, 2024, 19:06 > Subject: Re: [PATCH v3] vhost-user: Do not wait for reply for not sent > VHOST_USER_SET_LOG_BASE > To: "BillXiang"<xiangwench...@dayudpu.com> > Cc: "Michael S. Tsirkin"<m...@redhat.com>, <qemu-devel@nongnu.org> > On Thu, 1 Aug 2024 at 20:32, BillXiang <xiangwench...@dayudpu.com> wrote: > > > From: "Michael S. Tsirkin"<m...@redhat.com> > > > How do things work now after 7c211eb078c4 then? > > > > It does not really work after 7c211eb078c4 and it's my mistake. > > I forgot to submit the code to check vq_index in 7c211eb078c4. > > > > * vhost_user_set_log_base() sends set log message only when (vq_index == 0), > -> > https://github.com/qemu/qemu/commit/c98ac64cfb53ccb862a80e818c3a19bdd386e61e > === > + /* Send only once with first queue pair */ > + if (dev->vq_index != 0) { > + return 0; > + } > === > > This should help to keep things working, no? > --- > - Prasad
Yes, that works. But I think it's better to be consistent to use vhost_user_per_device_request for those per-device messages, right?
